fix some type errors

elastic · Mar 12, 2024 · 6d90c80 · 6d90c80
1 parent 0e221e8
commit 6d90c80
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/x-pack/plugins/security_solution/public/timelines/components/open_timeline/helpers.test.ts b/x-pack/plugins/security_solution/public/timelines/components/open_timeline/helpers.test.ts
@@ -853,7 +853,7 @@ describe('helpers', () => {
             updated: 1585233356356,
             noteId: 'note-id',
             note: 'I am a note',
-            timelineId: null,
+            timelineId: 'testId',
             version: 'testVersion',
           },
         ],
@@ -871,7 +871,7 @@ describe('helpers', () => {
             note: 'I am a note',
             user: 'unknown',
             saveObjectId: 'note-id',
-            timelineId: null,
+            timelineId: 'testId',
             version: 'testVersion',
           },
         ],

diff --git a/x-pack/plugins/security_solution/server/lib/timeline/saved_object/notes/saved_object.ts b/x-pack/plugins/security_solution/server/lib/timeline/saved_object/notes/saved_object.ts
@@ -113,7 +113,6 @@ const createNote = async ({
   const userInfo = request.user;
 
   const shallowCopyOfNote = { ...note };
-  let timelineVersion: string | undefined;
 
   if (note.timelineId == null) {
     const { timeline: timelineResult } = await createTimeline({
@@ -124,7 +123,6 @@ const createNote = async ({
     });
 
     shallowCopyOfNote.timelineId = timelineResult.savedObjectId;
-    timelineVersion = timelineResult.version;
   }
 
   const noteWithCreator = overrideOwner