allow_no_index return default to false

elastic · Jan 10, 2023 · 77620d1 · 77620d1
1 parent 6978eb6
commit 77620d1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/plugins/data_views/common/data_views/data_views.ts b/src/plugins/data_views/common/data_views/data_views.ts
@@ -526,7 +526,7 @@ export class DataViewsService {
     return this.apiClient.getFieldsForWildcard({
       type: dataView.type,
       rollupIndex: dataView?.typeMeta?.params?.rollup_index,
-      allowNoIndex: dataView.allowNoIndex,
+      allowNoIndex: true, // dataView.allowNoIndex,  - what should we do when setting this?
       pattern: dataView.getIndexPattern(),
       metaFields,
     });

diff --git a/src/plugins/data_views/server/fetcher/lib/es_api.ts b/src/plugins/data_views/server/fetcher/lib/es_api.ts
@@ -66,7 +66,7 @@ export async function callFieldCapsApi(params: FieldCapsApiParams) {
     indices,
     indexFilter,
     fieldCapsOptions = {
-      allow_no_indices: true, // CHANGE TO DEFAULT TO TRUE
+      allow_no_indices: false,
       include_unmapped: false,
     },
     fields = ['*'],
@@ -82,6 +82,7 @@ export async function callFieldCapsApi(params: FieldCapsApiParams) {
       },
       { meta: true }
     );
+    // this may need twweaking based on allow_no_index
     if (caps.body.indices.length === 0) {
       const pattern = Array.isArray(indices) ? indices.join(',') : indices;
       throw new DataViewMissingIndices(pattern);

diff --git a/src/plugins/data_views/server/routes/fields_for.ts b/src/plugins/data_views/server/routes/fields_for.ts
@@ -85,7 +85,7 @@ const handler: RequestHandler<{}, IQuery, IBody> = async (context, request, resp
       type,
       rollupIndex,
       fieldCapsOptions: {
-        allow_no_indices: allowNoIndex || true,
+        allow_no_indices: allowNoIndex || false,
         includeUnmapped,
       },
       indexFilter,