Skip to content

Commit

Permalink
[Uptime] Donut chart loader position centered vertically (#50219) (#5…
Browse files Browse the repository at this point in the history
…0983)

* added height for snapshot como

* added constant for height
  • Loading branch information
shahzad31 authored Nov 18, 2019
1 parent c2a3991 commit 78af6c4
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,22 @@ interface SnapshotQueryResult {
snapshot?: SnapshotType;
}

interface SnapshotProps {
/**
* Height is needed, since by default charts takes height of 100%
*/
height?: string;
}

export type SnapshotComponentProps = SnapshotProps & UptimeGraphQLQueryProps<SnapshotQueryResult>;

/**
* This component visualizes a KPI and histogram chart to help users quickly
* glean the status of their uptime environment.
* @param props the props required by the component
*/
export const SnapshotComponent = ({
data,
loading,
}: UptimeGraphQLQueryProps<SnapshotQueryResult>) => (
<ChartWrapper loading={loading}>
export const SnapshotComponent = ({ data, loading, height }: SnapshotComponentProps) => (
<ChartWrapper loading={loading} height={height}>
<SnapshotHeading
down={get<number>(data, 'snapshot.counts.down', 0)}
total={get<number>(data, 'snapshot.counts.total', 0)}
Expand All @@ -49,4 +55,7 @@ export const SnapshotComponent = ({
* This component visualizes a KPI and histogram chart to help users quickly
* glean the status of their uptime environment.
*/
export const Snapshot = withUptimeGraphQL<SnapshotQueryResult>(SnapshotComponent, snapshotQuery);
export const Snapshot = withUptimeGraphQL<SnapshotQueryResult, SnapshotProps>(
SnapshotComponent,
snapshotQuery
);
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ interface StatusPanelProps {
sharedProps: { [key: string]: any };
}

const STATUS_CHART_HEIGHT = '160px';

export const StatusPanel = ({
absoluteDateRangeStart,
absoluteDateRangeEnd,
Expand All @@ -23,13 +25,13 @@ export const StatusPanel = ({
<EuiPanel>
<EuiFlexGroup gutterSize="l">
<EuiFlexItem grow={2}>
<Snapshot variables={sharedProps} />
<Snapshot variables={sharedProps} height={STATUS_CHART_HEIGHT} />
</EuiFlexItem>
<EuiFlexItem grow={10}>
<SnapshotHistogram
absoluteStartDate={absoluteDateRangeStart}
absoluteEndDate={absoluteDateRangeEnd}
height="160px"
height={STATUS_CHART_HEIGHT}
isResponsive={true}
variables={sharedProps}
/>
Expand Down

0 comments on commit 78af6c4

Please sign in to comment.