Skip to content

Commit

Permalink
[8.x] [ES|QL][Inspector] Display cluster details tab for CCS data sou…
Browse files Browse the repository at this point in the history
…rces (#195373) (#195750)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL][Inspector] Display cluster details tab for CCS data sources
(#195373)](#195373)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2024-10-10T11:33:41Z","message":"[ES|QL][Inspector]
Display cluster details tab for CCS data sources (#195373)\n\n##
Summary\r\n\r\nIt displays correctly the cluster details if they come in
the response.\r\nTo test it you will need a CCS index as the `_clusters`
property only\r\ncomes for these indexes.\r\n\r\nOther than that it just
works out of the bloom as the response is\r\nexactly the same as the
search api. If we were sending the response\r\ncorrectly in the
inspector (it wants: `rawResonse: {....}` and not just\r\nthe response
as we get it), it would have worked without any change from\r\nour
side.\r\n\r\n![image\r\n(63)](https://github.com/user-attachments/assets/c3a93616-4a6d-468c-8968-e1f1692cffc1)","sha":"a6e22cf581975cab828b62926484dc2104a19432","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.16.0"],"title":"[ES|QL][Inspector]
Display cluster details tab for CCS data
sources","number":195373,"url":"https://github.com/elastic/kibana/pull/195373","mergeCommit":{"message":"[ES|QL][Inspector]
Display cluster details tab for CCS data sources (#195373)\n\n##
Summary\r\n\r\nIt displays correctly the cluster details if they come in
the response.\r\nTo test it you will need a CCS index as the `_clusters`
property only\r\ncomes for these indexes.\r\n\r\nOther than that it just
works out of the bloom as the response is\r\nexactly the same as the
search api. If we were sending the response\r\ncorrectly in the
inspector (it wants: `rawResonse: {....}` and not just\r\nthe response
as we get it), it would have worked without any change from\r\nour
side.\r\n\r\n![image\r\n(63)](https://github.com/user-attachments/assets/c3a93616-4a6d-468c-8968-e1f1692cffc1)","sha":"a6e22cf581975cab828b62926484dc2104a19432"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195373","number":195373,"mergeCommit":{"message":"[ES|QL][Inspector]
Display cluster details tab for CCS data sources (#195373)\n\n##
Summary\r\n\r\nIt displays correctly the cluster details if they come in
the response.\r\nTo test it you will need a CCS index as the `_clusters`
property only\r\ncomes for these indexes.\r\n\r\nOther than that it just
works out of the bloom as the response is\r\nexactly the same as the
search api. If we were sending the response\r\ncorrectly in the
inspector (it wants: `rawResonse: {....}` and not just\r\nthe response
as we get it), it would have worked without any change from\r\nour
side.\r\n\r\n![image\r\n(63)](https://github.com/user-attachments/assets/c3a93616-4a6d-468c-8968-e1f1692cffc1)","sha":"a6e22cf581975cab828b62926484dc2104a19432"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
  • Loading branch information
kibanamachine and stratoula authored Oct 10, 2024
1 parent 38de3b9 commit 79bd103
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/plugins/data/common/search/expressions/esql.ts
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ export const getEsqlFn = ({ getStartDependencies }: EsqlFnArguments) => {
}),
})
.json(params)
.ok({ json: rawResponse, requestParams });
.ok({ json: { rawResponse }, requestParams });
},
error(error) {
logInspectorRequest()
Expand Down

0 comments on commit 79bd103

Please sign in to comment.