Skip to content

Commit

Permalink
address copy feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
alisonelizabeth committed Apr 14, 2021
1 parent 1accb03 commit 7b5817d
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export const DeprecationTabContent: FunctionComponent<CheckupTabProps> = ({
<p>
<FormattedMessage
id="xpack.upgradeAssistant.checkupTab.noIssues.nextStepsDetail"
defaultMessage="Check the {overviewTabButton} for next steps."
defaultMessage="Check the {overviewTabButton} for other Stack deprecations."
values={{
overviewTabButton: (
<EuiLink onClick={navigateToOverviewPage}>
Expand Down Expand Up @@ -110,11 +110,11 @@ export const DeprecationTabContent: FunctionComponent<CheckupTabProps> = ({
isLoading={isLoading}
loadData={refreshCheckupData}
currentFilter={currentFilter}
onFilterChange={(filter: LevelFilterOption) => setCurrentFilter(filter)}
onSearchChange={(newSearch: string) => setSearch(newSearch)}
onFilterChange={setCurrentFilter}
onSearchChange={setSearch}
availableGroupByOptions={availableGroupByOptions()}
currentGroupBy={currentGroupBy}
onGroupByChange={(groupBy: GroupByOption) => setCurrentGroupBy(groupBy)}
onGroupByChange={setCurrentGroupBy}
/>

<EuiSpacer />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ const i18nTexts = {
}),
pageDescription: i18n.translate('xpack.upgradeAssistant.esDeprecations.pageDescription', {
defaultMessage:
'Review the deprecated cluster and index settings. You
must resolve any critical issues before upgrading.',
'Review the deprecated cluster and index settings. You must resolve any critical issues before upgrading.',
}),
docLinkText: i18n.translate('xpack.upgradeAssistant.esDeprecations.docLinkText', {
defaultMessage: 'Documentation',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ const i18nTexts = {
getPageDescription: (nextMajor: string) =>
i18n.translate('xpack.upgradeAssistant.pageDescription', {
defaultMessage:
'Prepare to upgrade by identifying deprecated settings and updating
your configuration. Enable deprecation logging to see if your are using deprecated features that will not be available after you upgrade to Elastic {nextMajor}.',
'Prepare to upgrade by identifying deprecated settings and updating your configuration. Enable deprecation logging to see if your are using deprecated features that will not be available after you upgrade to Elastic {nextMajor}.',
values: {
nextMajor,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,14 @@ const i18nTexts = {
'xpack.upgradeAssistant.esDeprecationErrors.partiallyUpgradedWarningMessage',
{
defaultMessage:
'One or more Elasticsearch nodes have a newer version of Elasticsearch than Kibana.',
'Upgrade Kibana to the same version as your Elasticsearch cluster. One or more nodes in the cluster is running a different version than Kibana.',
}
),
upgradedMessage: i18n.translate(
'xpack.upgradeAssistant.esDeprecationErrors.upgradedWarningMessage',
{
defaultMessage: 'Your configuration is up to date. Kibana and all Elasticsearch nodes are running <version xyz>.',
defaultMessage:
'Your configuration is up to date. Kibana and all Elasticsearch nodes are running the same version.',
}
),
loadingError: i18n.translate('xpack.upgradeAssistant.esDeprecationErrors.loadingErrorMessage', {
Expand Down

0 comments on commit 7b5817d

Please sign in to comment.