Use versioned router

elastic · Sep 18, 2024 · 81429a4 · 81429a4
1 parent 42453a8
commit 81429a4
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 15 deletions.
diff --git a/x-pack/plugins/cloud/common/constants.ts b/x-pack/plugins/cloud/common/constants.ts
@@ -12,4 +12,4 @@ export const ELASTIC_SUPPORT_LINK = 'https://support.elastic.co/';
  */
 export const CLOUD_SNAPSHOTS_PATH = 'elasticsearch/snapshots/';
 
-export const ELASTICSEARCH_CONFIG_ROUTE = '/api/internal/elasticsearch_config';
+export const ELASTICSEARCH_CONFIG_ROUTE = '/api/internal/cloud/elasticsearch_config';
diff --git a/x-pack/plugins/cloud/public/plugin.tsx b/x-pack/plugins/cloud/public/plugin.tsx
@@ -12,7 +12,7 @@ import type { CoreSetup, CoreStart, Plugin, PluginInitializerContext } from '@kb
 import { registerCloudDeploymentMetadataAnalyticsContext } from '../common/register_cloud_deployment_id_analytics_context';
 import { getIsCloudEnabled } from '../common/is_cloud_enabled';
 import { parseDeploymentIdFromDeploymentUrl } from '../common/parse_deployment_id_from_deployment_url';
-import { CLOUD_SNAPSHOTS_PATH } from '../common/constants';
+import { CLOUD_SNAPSHOTS_PATH, ELASTICSEARCH_CONFIG_ROUTE } from '../common/constants';
 import { decodeCloudId, type DecodedCloudId } from '../common/decode_cloud_id';
 import { getFullCloudUrl } from '../common/utils';
 import { parseOnboardingSolution } from '../common/parse_onboarding_default_solution';
@@ -228,7 +228,9 @@ export class CloudPlugin implements Plugin<CloudSetup> {
       return this.elasticsearchConfig;
     }
     try {
-      const result = await http.get<ElasticsearchConfigType>('/api/internal/elasticsearch_config');
+      const result = await http.get<ElasticsearchConfigType>(ELASTICSEARCH_CONFIG_ROUTE, {
+        version: '1',
+      });
 
       this.elasticsearchConfig = { elasticsearchUrl: result.elasticsearch_url || undefined };
       return this.elasticsearchConfig;

diff --git a/x-pack/plugins/cloud/server/routes/elasticsearch_routes.ts b/x-pack/plugins/cloud/server/routes/elasticsearch_routes.ts
@@ -19,22 +19,17 @@ export function defineRoutes({
   logger: Logger;
   router: IRouter;
 }) {
-  router.get(
-    {
+  router.versioned
+    .get({
       path: ELASTICSEARCH_CONFIG_ROUTE,
-      validate: {},
-      options: {
-        access: 'internal',
-      },
-    },
-    async (context, request, response) => {
+      access: 'internal',
+    })
+    .addVersion({ version: '1', validate: {} }, async (context, request, response) => {
       const body: ElasticsearchConfigType = {
-        elasticsearch_url: elasticsearchUrl || '',
+        elasticsearch_url: elasticsearchUrl,
       };
       return response.ok({
         body,
-        headers: { 'content-type': 'application/json' },
       });
-    }
-  );
+    });
 }