Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@tsullivan
tsullivan committed Jan 27, 2020
1 parent 4fa362f commit 8583c10
Show file tree
Hide file tree
Showing 2 changed files with 106 additions and 33 deletions.
14 changes: 9 additions & 5 deletions x-pack/legacy/plugins/reporting/server/routes/jobs.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ beforeEach(() => {
};
});

const mockPlugins = {
security: null,
};

const getHits = (...sources) => {
return {
hits: {
Expand All @@ -67,7 +71,7 @@ test(`returns 404 if job not found`, async () => {
.getCluster('admin')
.callWithInternalUser.mockReturnValue(Promise.resolve(getHits()));

registerJobInfoRoutes(mockServer, exportTypesRegistry, mockLogger);
registerJobInfoRoutes(mockServer, mockPlugins, exportTypesRegistry, mockLogger);

const request = {
method: 'GET',
Expand All @@ -84,7 +88,7 @@ test(`returns 401 if not valid job type`, async () => {
.getCluster('admin')
.callWithInternalUser.mockReturnValue(Promise.resolve(getHits({ jobtype: 'invalidJobType' })));

registerJobInfoRoutes(mockServer, exportTypesRegistry, mockLogger);
registerJobInfoRoutes(mockServer, mockPlugins, exportTypesRegistry, mockLogger);

const request = {
method: 'GET',
Expand All @@ -103,7 +107,7 @@ describe(`when job is incomplete`, () => {
Promise.resolve(getHits({ jobtype: 'unencodedJobType', status: 'pending' }))
);

registerJobInfoRoutes(mockServer, exportTypesRegistry, mockLogger);
registerJobInfoRoutes(mockServer, mockPlugins, exportTypesRegistry, mockLogger);

const request = {
method: 'GET',
Expand Down Expand Up @@ -145,7 +149,7 @@ describe(`when job is failed`, () => {
.getCluster('admin')
.callWithInternalUser.mockReturnValue(Promise.resolve(hits));

registerJobInfoRoutes(mockServer, exportTypesRegistry, mockLogger);
registerJobInfoRoutes(mockServer, mockPlugins, exportTypesRegistry, mockLogger);

const request = {
method: 'GET',
Expand Down Expand Up @@ -190,7 +194,7 @@ describe(`when job is completed`, () => {
.getCluster('admin')
.callWithInternalUser.mockReturnValue(Promise.resolve(hits));

registerJobInfoRoutes(mockServer, exportTypesRegistry, mockLogger);
registerJobInfoRoutes(mockServer, mockPlugins, exportTypesRegistry, mockLogger);

const request = {
method: 'GET',
Expand Down
125 changes: 97 additions & 28 deletions x-pack/legacy/plugins/reporting/server/routes/lib/authorized_user_pre_routing.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
* you may not use this file except in compliance with the Elastic License.
*/

import expect from '@kbn/expect';
import { authorizedUserPreRoutingFactory } from './authorized_user_pre_routing';

describe('authorized_user_pre_routing', function() {
Expand Down Expand Up @@ -60,53 +59,107 @@ describe('authorized_user_pre_routing', function() {
return mockServer;
};
})();
const getMockLogger = () => ({ warn: jest.fn() });

const mockRequestRaw = {
body: {},
events: {},
headers: {},
isSystemRequest: false,
params: {},
query: {},
route: { settings: { payload: 'abc' }, options: { authRequired: true, body: {}, tags: [] } },
withoutSecretHeaders: true,
};
const getMockRequest = () => ({
...mockRequestRaw,
raw: { req: mockRequestRaw },
});

const getMockPlugins = pluginSet => {
return pluginSet || { security: null };
};

const getMockLogger = () => ({
warn: jest.fn(),
error: msg => {
throw new Error(msg);
},
});

it('should return with boom notFound when xpackInfo is undefined', async function() {
const mockServer = createMockServer({ xpackInfoUndefined: true });

const authorizedUserPreRouting = authorizedUserPreRoutingFactory(mockServer, getMockLogger());
const response = await authorizedUserPreRouting({});
expect(response.isBoom).to.be(true);
expect(response.output.statusCode).to.be(404);
const authorizedUserPreRouting = authorizedUserPreRoutingFactory(
mockServer,
{ security: null },
getMockLogger()
);
const response = await authorizedUserPreRouting(getMockRequest());
expect(response.isBoom).toBe(true);
expect(response.output.statusCode).toBe(404);
});

it(`should return with boom notFound when xpackInfo isn't available`, async function() {
const mockServer = createMockServer({ xpackInfoAvailable: false });

const authorizedUserPreRouting = authorizedUserPreRoutingFactory(mockServer, getMockLogger());
const response = await authorizedUserPreRouting();
expect(response.isBoom).to.be(true);
expect(response.output.statusCode).to.be(404);
const authorizedUserPreRouting = authorizedUserPreRoutingFactory(
mockServer,
getMockPlugins(),
getMockLogger()
);
const response = await authorizedUserPreRouting(getMockRequest());
expect(response.isBoom).toBe(true);
expect(response.output.statusCode).toBe(404);
});

it('should return with null user when security is disabled in Elasticsearch', async function() {
const mockServer = createMockServer({ securityEnabled: false });

const authorizedUserPreRouting = authorizedUserPreRoutingFactory(mockServer, getMockLogger());
const response = await authorizedUserPreRouting();
expect(response).to.be(null);
const authorizedUserPreRouting = authorizedUserPreRoutingFactory(
mockServer,
getMockPlugins(),
getMockLogger()
);
const response = await authorizedUserPreRouting(getMockRequest());
expect(response).toBe(null);
});

it('should return with boom unauthenticated when security is enabled but no authenticated user', async function() {
const mockServer = createMockServer({ user: null });
const mockServer = createMockServer({
user: null,
config: { 'xpack.reporting.roles.allow': ['.reporting_user'] },
});
const mockPlugins = getMockPlugins({
security: { authc: { getCurrentUser: () => null } },
});

const authorizedUserPreRouting = authorizedUserPreRoutingFactory(mockServer, getMockLogger());
const response = await authorizedUserPreRouting();
expect(response.isBoom).to.be(true);
expect(response.output.statusCode).to.be(401);
const authorizedUserPreRouting = authorizedUserPreRoutingFactory(
mockServer,
mockPlugins,
getMockLogger()
);
const response = await authorizedUserPreRouting(getMockRequest());
expect(response.isBoom).toBe(true);
expect(response.output.statusCode).toBe(401);
});

it(`should return with boom forbidden when security is enabled but user doesn't have allowed role`, async function() {
const mockServer = createMockServer({
user: { roles: [] },
config: { 'xpack.reporting.roles.allow': ['.reporting_user'] },
});
const mockPlugins = getMockPlugins({
security: { authc: { getCurrentUser: () => ({ roles: ['something_else'] }) } },
});

const authorizedUserPreRouting = authorizedUserPreRoutingFactory(mockServer, getMockLogger());
const response = await authorizedUserPreRouting();
expect(response.isBoom).to.be(true);
expect(response.output.statusCode).to.be(403);
const authorizedUserPreRouting = authorizedUserPreRoutingFactory(
mockServer,
mockPlugins,
getMockLogger()
);
const response = await authorizedUserPreRouting(getMockRequest());
expect(response.isBoom).toBe(true);
expect(response.output.statusCode).toBe(403);
});

it('should return with user when security is enabled and user has explicitly allowed role', async function() {
Expand All @@ -115,10 +168,19 @@ describe('authorized_user_pre_routing', function() {
user,
config: { 'xpack.reporting.roles.allow': ['.reporting_user'] },
});
const mockPlugins = getMockPlugins({
security: {
authc: { getCurrentUser: () => ({ roles: ['.reporting_user', 'something_else'] }) },
},
});

const authorizedUserPreRouting = authorizedUserPreRoutingFactory(mockServer, getMockLogger());
const response = await authorizedUserPreRouting();
expect(response).to.be(user);
const authorizedUserPreRouting = authorizedUserPreRoutingFactory(
mockServer,
mockPlugins,
getMockLogger()
);
const response = await authorizedUserPreRouting(getMockRequest());
expect(response).toEqual(user);
});

it('should return with user when security is enabled and user has superuser role', async function() {
Expand All @@ -127,9 +189,16 @@ describe('authorized_user_pre_routing', function() {
user,
config: { 'xpack.reporting.roles.allow': [] },
});
const mockPlugins = getMockPlugins({
security: { authc: { getCurrentUser: () => ({ roles: ['superuser', 'something_else'] }) } },
});

const authorizedUserPreRouting = authorizedUserPreRoutingFactory(mockServer, getMockLogger());
const response = await authorizedUserPreRouting();
expect(response).to.be(user);
const authorizedUserPreRouting = authorizedUserPreRoutingFactory(
mockServer,
mockPlugins,
getMockLogger()
);
const response = await authorizedUserPreRouting(getMockRequest());
expect(response).toEqual(user);
});
});

0 comments on commit 8583c10

Please sign in to comment.