Fix static value converter (#144034)

elastic · Oct 27, 2022 · 8eeb9e2 · 8eeb9e2
1 parent 7839589
commit 8eeb9e2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/static_value.test.ts b/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/static_value.test.ts
@@ -47,6 +47,11 @@ describe('convertToStaticValueColumn', () => {
       [{ series, metrics: [metric], dataView }, { visibleSeriesCount: 1 }],
       null,
     ],
+    [
+      'null if value is not specified',
+      [{ series, metrics: [metric], dataView }, { visibleSeriesCount: 2 }],
+      null,
+    ],
     [
       'static value column',
       [{ series, metrics: [{ ...metric, value: 'some value' }], dataView }],

diff --git a/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/static_value.ts b/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/static_value.ts
@@ -32,6 +32,9 @@ export const convertToStaticValueColumn = (
     return null;
   }
   const currentMetric = metrics[metrics.length - 1];
+  if (!currentMetric.value) {
+    return null;
+  }
   return {
     operationType: 'static_value',
     references: [],
@@ -68,7 +71,10 @@ export const convertStaticValueToFormulaColumn = (
     return null;
   }
   const currentMetric = metrics[metrics.length - 1];
-  return createFormulaColumn(currentMetric.value ?? '', {
+  if (!currentMetric.value) {
+    return null;
+  }
+  return createFormulaColumn(currentMetric.value, {
     series,
     metric: currentMetric,
     dataView,