Skip to content

Commit

Permalink
added height for snapshot como
Browse files Browse the repository at this point in the history
  • Loading branch information
shahzad31 committed Nov 11, 2019
1 parent 0491589 commit 908afe0
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,22 @@ interface SnapshotQueryResult {
snapshot?: SnapshotType;
}

interface SnapshotProps {
/**
* Height is needed, since by default charts takes height of 100%
*/
height?: string;
}

export type SnapshotComponentProps = SnapshotProps & UptimeGraphQLQueryProps<SnapshotQueryResult>;

/**
* This component visualizes a KPI and histogram chart to help users quickly
* glean the status of their uptime environment.
* @param props the props required by the component
*/
export const SnapshotComponent = ({
data,
loading,
}: UptimeGraphQLQueryProps<SnapshotQueryResult>) => (
<ChartWrapper loading={loading}>
export const SnapshotComponent = ({ data, loading, height }: SnapshotComponentProps) => (
<ChartWrapper loading={loading} height={height}>
<SnapshotHeading
down={get<number>(data, 'snapshot.counts.down', 0)}
total={get<number>(data, 'snapshot.counts.total', 0)}
Expand All @@ -49,4 +55,7 @@ export const SnapshotComponent = ({
* This component visualizes a KPI and histogram chart to help users quickly
* glean the status of their uptime environment.
*/
export const Snapshot = withUptimeGraphQL<SnapshotQueryResult>(SnapshotComponent, snapshotQuery);
export const Snapshot = withUptimeGraphQL<SnapshotQueryResult, SnapshotProps>(
SnapshotComponent,
snapshotQuery
);
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const StatusPanel = ({
<EuiPanel>
<EuiFlexGroup gutterSize="l">
<EuiFlexItem grow={2}>
<Snapshot variables={sharedProps} />
<Snapshot variables={sharedProps} height="160px" />
</EuiFlexItem>
<EuiFlexItem grow={10}>
<SnapshotHistogram
Expand Down

0 comments on commit 908afe0

Please sign in to comment.