Fixing bugs in the Shareable Runtime

elastic · Nov 1, 2019 · 9365d12 · 9365d12
1 parent f479f1e
commit 9365d12
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 9 deletions.
diff --git a/...gacy/plugins/canvas/public/components/workpad_header/control_settings/custom_interval.tsx b/...gacy/plugins/canvas/public/components/workpad_header/control_settings/custom_interval.tsx
@@ -54,7 +54,7 @@ export const CustomInterval = ({ gutterSize, buttonSize, onSubmit, defaultValue
         </EuiFlexItem>
 
         <EuiFlexItem grow={false}>
-          <EuiFormRow label="&nbsp;">
+          <EuiFormRow hasEmptyLabelSpace={true} compressed>
             <EuiButton
               disabled={isInvalid}
               size={buttonSize}

diff --git a/x-pack/legacy/plugins/canvas/shareable_runtime/components/canvas.module.scss b/x-pack/legacy/plugins/canvas/shareable_runtime/components/canvas.module.scss
@@ -18,5 +18,7 @@
 
 :global .kbnCanvas :local .page {
   position: absolute;
-  transform-origin: center center;
+  transform-origin: left top;
+  top: 0;
+  left: 0;
 }
diff --git a/x-pack/legacy/plugins/canvas/shareable_runtime/components/footer/page_preview.module.scss b/x-pack/legacy/plugins/canvas/shareable_runtime/components/footer/page_preview.module.scss
@@ -3,6 +3,7 @@
 :global .kbnCanvas :local .root {
   margin: 0 $euiSizeS;
   cursor: pointer;
+  flex-shrink: 0;
 }
 
 :global .kbnCanvas :local .root :global .canvasPage {

diff --git a/x-pack/legacy/plugins/canvas/shareable_runtime/components/footer/page_preview.tsx b/x-pack/legacy/plugins/canvas/shareable_runtime/components/footer/page_preview.tsx
@@ -58,13 +58,10 @@ export const PagePreviewComponent: FC<Props> = ({
   workpadWidth,
 }) => {
   const scale = height / workpadHeight;
-  const style = {
-    height: workpadHeight * scale,
-    width: workpadWidth * scale,
-  };
 
   const transform = {
-    ...style,
+    height: workpadHeight,
+    width: workpadWidth,
     transform: `scale3d(${scale}, ${scale}, 1)`,
   };
 
@@ -73,7 +70,10 @@ export const PagePreviewComponent: FC<Props> = ({
       className={css.root}
       onClick={() => onClick(index)}
       onKeyPress={() => onClick(index)}
-      style={style}
+      style={{
+        height: workpadHeight * scale,
+        width: workpadWidth * scale,
+      }}
     >
       <div className={css.preview} style={transform}>
         <PageComponent {...{ page }} height={workpadHeight} width={workpadWidth} />

diff --git a/x-pack/legacy/plugins/canvas/shareable_runtime/components/footer/title.tsx b/x-pack/legacy/plugins/canvas/shareable_runtime/components/footer/title.tsx
@@ -20,7 +20,7 @@ interface Props {
  */
 export const TitleComponent: FC<Props> = ({ title }) => (
   <EuiFlexGroup gutterSize="s" justifyContent="flexStart" alignItems="center">
-    <EuiFlexItem grow={false}>
+    <EuiFlexItem grow={false} style={{ flexShrink: 0 }}>
       <EuiLink href="https://www.elastic.co" title="Powered by Elastic.co">
         <EuiIcon type="logoElastic" size="l" />
       </EuiLink>

diff --git a/x-pack/legacy/plugins/canvas/shareable_runtime/template.html b/x-pack/legacy/plugins/canvas/shareable_runtime/template.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <html>
 
 <head>

diff --git a/x-pack/legacy/plugins/canvas/shareable_runtime/webpack.config.js b/x-pack/legacy/plugins/canvas/shareable_runtime/webpack.config.js
@@ -41,6 +41,7 @@ module.exports = {
         KIBANA_ROOT,
         'src/legacy/core_plugins/interpreter/public/types'
       ),
+      tinymath: path.resolve(KIBANA_ROOT, 'node_modules/tinymath/lib/tinymath.es5.js'),
     },
     extensions: ['.js', '.json', '.ts', '.tsx', '.scss'],
   },
-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    <!DOCTYPE html>
     <html>
     <head>
@@ Expand Down @@