Refactor UA telemetry constants by extracting it from common/types.

elastic · Oct 14, 2021 · 981e21b · 981e21b
1 parent b77716b
commit 981e21b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/x-pack/plugins/upgrade_assistant/common/constants.ts b/x-pack/plugins/upgrade_assistant/common/constants.ts
@@ -28,6 +28,9 @@ export const indexSettingDeprecations = {
 
 export const API_BASE_PATH = '/api/upgrade_assistant';
 
+// Telemetry constants
+export const UPGRADE_ASSISTANT_TELEMETRY = 'upgrade-assistant-telemetry';
+
 /**
  * This is the repository where Cloud stores its backup snapshots.
  */

diff --git a/x-pack/plugins/upgrade_assistant/common/types.ts b/x-pack/plugins/upgrade_assistant/common/types.ts
@@ -126,8 +126,6 @@ export interface ReindexWarning {
 }
 
 // Telemetry types
-export const UPGRADE_ASSISTANT_TYPE = 'upgrade-assistant-telemetry';
-export const UPGRADE_ASSISTANT_DOC_ID = 'upgrade-assistant-telemetry';
 export type UIOpenOption = 'overview' | 'elasticsearch' | 'kibana';
 export type UIReindexOption = 'close' | 'open' | 'start' | 'stop';
 

diff --git a/x-pack/plugins/upgrade_assistant/server/saved_object_types/telemetry_saved_object_type.ts b/x-pack/plugins/upgrade_assistant/server/saved_object_types/telemetry_saved_object_type.ts
@@ -7,11 +7,11 @@
 
 import { SavedObjectsType } from 'src/core/server';
 
-import { UPGRADE_ASSISTANT_TYPE } from '../../common/types';
+import { UPGRADE_ASSISTANT_TELEMETRY } from '../../common/constants';
 import { telemetrySavedObjectMigrations } from './migrations';
 
 export const telemetrySavedObjectType: SavedObjectsType = {
-  name: UPGRADE_ASSISTANT_TYPE,
+  name: UPGRADE_ASSISTANT_TELEMETRY,
   hidden: false,
   namespaceType: 'agnostic',
   mappings: {