Skip to content

Commit

Permalink
[build] Fix canvas shareable runtime (#149165)
Browse files Browse the repository at this point in the history
The canvas shareable runtime build uses webpack 4, which needs the
`--legacy-openssl-provider` flag after the recent Node 16 -> 18 upgrade.

Context: the runtime build is disabled by default in pull requests
because it's currently untested and adds ~3 minutes to build time. It is
enabled in our nightly snapshots pipeline, which we've been using as a
slower feedback loop for build issues.

## Testing
```
node x-pack/plugins/canvas/scripts/shareable_runtime.js
```
should exit 0
  • Loading branch information
jbudz authored Jan 18, 2023
1 parent 7365867 commit 9defcef
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions x-pack/plugins/canvas/scripts/shareable_runtime.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ run(
execa.sync(
process.execPath,
[
'--openssl-legacy-provider',
require.resolve('webpack-dev-server/bin/webpack-dev-server'),
'--config',
webpackConfig,
Expand Down Expand Up @@ -88,6 +89,7 @@ run(
execa.sync(
process.execPath,
[
'--openssl-legacy-provider',
require.resolve('webpack/bin/webpack'),
'--config',
webpackConfig,
Expand Down

0 comments on commit 9defcef

Please sign in to comment.