Skip to content

Commit

Permalink
[ML] Fix character escape & disable next step if misisng summaryCount…
Browse files Browse the repository at this point in the history
…Field
  • Loading branch information
qn895 committed Nov 5, 2020
1 parent d96a119 commit a3a0809
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion x-pack/plugins/ml/common/util/job_utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ export function basicJobAndDatafeedValidation(job: Job, datafeed: Datafeed): Val
const datafeedAggConfig = datafeed.aggregations ?? datafeed?.aggs;
if (datafeedAggConfig !== undefined && !job.analysis_config?.summary_count_field_name) {
valid = false;
messages.push({ id: '`missing_summary_count_field_name`' });
messages.push({ id: 'missing_summary_count_field_name' });
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@ export class JobValidator {
this.duplicateDetectors.valid &&
this.categorizerMissingPerPartition.valid &&
this.categorizerVaryingPerPartitionField.valid &&
this.summaryCountField.valid &&
!this.validating &&
(this._jobCreator.type !== JOB_TYPE.CATEGORIZATION ||
(this._jobCreator.type === JOB_TYPE.CATEGORIZATION && this.categorizationField))
Expand Down

0 comments on commit a3a0809

Please sign in to comment.