[ML] Remove export wildcard syntax for data visualizer plugin. (#123213)

Remove export wildcard syntax for data visualizer plugin.

x-pack/plugins/data_visualizer/kibana.json

@@ -30,9 +30,6 @@
     "fieldFormats",
     "uiActions"
   ],
-  "extraPublicDirs": [
-    "common"
-  ],
   "owner": {
     "name": "Machine Learning UI",
     "githubTeam": "ml-ui"

x-pack/plugins/data_visualizer/public/application/common/components/expanded_row/file_based_expanded_row.tsx

@@ -16,7 +16,7 @@ import {
   NumberContent,
 } from '../stats_table/components/field_data_expanded_row';
 import { GeoPointContent } from './geo_point_content/geo_point_content';
-import { JOB_FIELD_TYPES } from '../../../../../common';
+import { JOB_FIELD_TYPES } from '../../../../../common/constants';
 import type { FileBasedFieldVisConfig } from '../../../../../common/types/field_vis_config';
 
 export const FileBasedDataVisualizerExpandedRow = ({ item }: { item: FileBasedFieldVisConfig }) => {

x-pack/plugins/data_visualizer/public/application/common/components/expanded_row/geo_point_content_with_map/geo_point_content_with_map.tsx

@@ -13,7 +13,7 @@ import { DocumentStatsTable } from '../../stats_table/components/field_data_expa
 import { ExamplesList } from '../../examples_list';
 import { FieldVisConfig } from '../../stats_table/types';
 import { useDataVisualizerKibana } from '../../../../kibana_context';
-import { JOB_FIELD_TYPES } from '../../../../../../common';
+import { JOB_FIELD_TYPES } from '../../../../../../common/constants';
 import { ES_GEO_FIELD_TYPE, LayerDescriptor } from '../../../../../../../maps/common';
 import { EmbeddedMapComponent } from '../../embedded_map';
 import { ExpandedRowPanel } from '../../stats_table/components/field_data_expanded_row/expanded_row_panel';

x-pack/plugins/data_visualizer/public/application/common/components/expanded_row/index_based_expanded_row.tsx

@@ -7,7 +7,7 @@
 
 import React from 'react';
 import { GeoPointContentWithMap } from './geo_point_content_with_map';
-import { JOB_FIELD_TYPES } from '../../../../../common';
+import { JOB_FIELD_TYPES } from '../../../../../common/constants';
 import {
   BooleanContent,
   DateContent,

x-pack/plugins/data_visualizer/public/application/common/components/field_data_row/action_menu/actions.ts

@@ -17,7 +17,7 @@ import {
   dataVisualizerRefresh$,
   Refresh,
 } from '../../../../index_data_visualizer/services/timefilter_refresh_service';
-import { JOB_FIELD_TYPES } from '../../../../../../common';
+import { JOB_FIELD_TYPES } from '../../../../../../common/constants';
 import { VISUALIZE_GEO_FIELD_TRIGGER } from '../../../../../../../../../src/plugins/ui_actions/public';
 
 export function getActions(

x-pack/plugins/data_visualizer/public/application/common/components/field_data_row/action_menu/lens_utils.ts

@@ -18,7 +18,7 @@ import type {
   XYLayerConfig,
 } from '../../../../../../../lens/public';
 import { FieldVisConfig } from '../../stats_table/types';
-import { JOB_FIELD_TYPES } from '../../../../../../common';
+import { JOB_FIELD_TYPES } from '../../../../../../common/constants';
 
 interface ColumnsAndLayer {
   columns: Record<string, GenericIndexPatternColumn>;

x-pack/plugins/data_visualizer/public/application/common/components/field_type_icon/field_type_icon.test.tsx

@@ -9,7 +9,7 @@ import React from 'react';
 import { mount, shallow } from 'enzyme';
 
 import { FieldTypeIcon } from './field_type_icon';
-import { JOB_FIELD_TYPES } from '../../../../../common';
+import { JOB_FIELD_TYPES } from '../../../../../common/constants';
 
 describe('FieldTypeIcon', () => {
   test(`render component when type matches a field type`, () => {

x-pack/plugins/data_visualizer/public/application/common/components/field_type_icon/field_type_icon.tsx

@@ -10,7 +10,7 @@ import { EuiToolTip } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import { FieldIcon } from '@kbn/react-field';
 import { getJobTypeLabel } from '../../util/field_types_utils';
-import type { JobFieldType } from '../../../../../common';
+import type { JobFieldType } from '../../../../../common/types';
 import './_index.scss';
 
 interface FieldTypeIconProps {

x-pack/plugins/data_visualizer/public/application/common/components/fields_stats_grid/create_fields.ts

@@ -8,7 +8,7 @@
 import { FindFileStructureResponse } from '../../../../../../file_upload/common';
 import { getFieldNames, getSupportedFieldType } from './get_field_names';
 import { FileBasedFieldVisConfig } from '../stats_table/types';
-import { JOB_FIELD_TYPES } from '../../../../../common';
+import { JOB_FIELD_TYPES } from '../../../../../common/constants';
 import { roundToDecimalPlace } from '../utils';
 
 export function createFields(results: FindFileStructureResponse) {

x-pack/plugins/data_visualizer/public/application/common/components/fields_stats_grid/fields_stats_grid.tsx

@@ -8,7 +8,7 @@
 import React, { useMemo, FC, useState } from 'react';
 import { EuiFlexGroup, EuiSpacer } from '@elastic/eui';
 import type { FindFileStructureResponse } from '../../../../../../file_upload/common';
-import type { DataVisualizerTableState } from '../../../../../common';
+import type { DataVisualizerTableState } from '../../../../../common/types';
 import { DataVisualizerTable, ItemIdToExpandedRowMap } from '../stats_table';
 import type { FileBasedFieldVisConfig } from '../../../../../common/types/field_vis_config';
 import { FileBasedDataVisualizerExpandedRow } from '../expanded_row';

x-pack/plugins/data_visualizer/public/application/common/components/fields_stats_grid/filter_fields.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { JOB_FIELD_TYPES } from '../../../../../common';
+import { JOB_FIELD_TYPES } from '../../../../../common/constants';
 import type {
   FileBasedFieldVisConfig,
   FileBasedUnknownFieldVisConfig,

x-pack/plugins/data_visualizer/public/application/common/components/fields_stats_grid/get_field_names.ts

@@ -8,8 +8,8 @@
 import { difference } from 'lodash';
 import { ES_FIELD_TYPES } from '../../../../../../../../src/plugins/data/common';
 import type { FindFileStructureResponse } from '../../../../../../file_upload/common';
-import type { JobFieldType } from '../../../../../common';
-import { JOB_FIELD_TYPES } from '../../../../../common';
+import type { JobFieldType } from '../../../../../common/types';
+import { JOB_FIELD_TYPES } from '../../../../../common/constants';
 export function getFieldNames(results: FindFileStructureResponse) {
   const { mappings, field_stats: fieldStats, column_names: columnNames } = results;
 

x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx

@@ -23,7 +23,8 @@ import {
 import { i18n } from '@kbn/i18n';
 import { EuiTableComputedColumnType } from '@elastic/eui/src/components/basic_table/table_types';
 import { throttle } from 'lodash';
-import { JOB_FIELD_TYPES, JobFieldType, DataVisualizerTableState } from '../../../../../common';
+import { JOB_FIELD_TYPES } from '../../../../../common/constants';
+import type { JobFieldType, DataVisualizerTableState } from '../../../../../common/types';
 import { DocumentStat } from './components/field_data_row/document_stats';
 import { IndexBasedNumberContentPreview } from './components/field_data_row/number_content_preview';
 

x-pack/plugins/data_visualizer/public/application/common/components/stats_table/use_table_settings.ts

@@ -8,7 +8,7 @@
 import { Direction, EuiBasicTableProps, Pagination, PropertySort } from '@elastic/eui';
 import { useCallback, useMemo } from 'react';
 
-import { DataVisualizerTableState } from '../../../../../common';
+import type { DataVisualizerTableState } from '../../../../../common/types';
 
 const PAGE_SIZE_OPTIONS = [10, 25, 50, 100];
 

x-pack/plugins/data_visualizer/public/application/common/components/utils/utils.ts

@@ -7,7 +7,7 @@
 
 import { isEqual } from 'lodash';
 import type { AnalysisResult, InputOverrides } from '../../../../../../file_upload/common';
-import { MB, FILE_FORMATS } from '../../../../../common';
+import { MB, FILE_FORMATS } from '../../../../../common/constants';
 
 export const DEFAULT_LINES_TO_SAMPLE = 1000;
 const UPLOAD_SIZE_MB = 5;

x-pack/plugins/data_visualizer/public/application/common/util/field_types_utils.test.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { JOB_FIELD_TYPES } from '../../../../common';
+import { JOB_FIELD_TYPES } from '../../../../common/constants';
 import { getJobTypeLabel, jobTypeLabels } from './field_types_utils';
 
 describe('field type utils', () => {

x-pack/plugins/data_visualizer/public/application/common/util/field_types_utils.ts

@@ -6,7 +6,7 @@
  */
 
 import { i18n } from '@kbn/i18n';
-import { JOB_FIELD_TYPES } from '../../../../common';
+import { JOB_FIELD_TYPES } from '../../../../common/constants';
 import type { IndexPatternField } from '../../../../../../../src/plugins/data/common';
 import { KBN_FIELD_TYPES } from '../../../../../../../src/plugins/data/common';
 

x-pack/plugins/data_visualizer/public/application/file_data_visualizer/components/analysis_summary/analysis_summary.tsx

@@ -10,7 +10,7 @@ import React, { FC } from 'react';
 
 import { EuiTitle, EuiSpacer, EuiDescriptionList } from '@elastic/eui';
 import type { FindFileStructureResponse } from '../../../../../../file_upload/common';
-import { FILE_FORMATS } from '../../../../../common';
+import { FILE_FORMATS } from '../../../../../common/constants';
 
 export const AnalysisSummary: FC<{ results: FindFileStructureResponse }> = ({ results }) => {
   const items = createDisplayItems(results);

x-pack/plugins/data_visualizer/public/application/file_data_visualizer/components/edit_flyout/options/options.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { FILE_FORMATS } from '../../../../../../common/';
+import { FILE_FORMATS } from '../../../../../../common/constants';
 
 import {
   TIMESTAMP_OPTIONS,

x-pack/plugins/data_visualizer/public/application/file_data_visualizer/components/edit_flyout/overrides.js

@@ -23,7 +23,7 @@ import {
   EuiTextArea,
 } from '@elastic/eui';
 
-import { FILE_FORMATS } from '../../../../../common';
+import { FILE_FORMATS } from '../../../../../common/constants';
 
 import {
   getFormatOptions,

x-pack/plugins/data_visualizer/public/application/file_data_visualizer/components/edit_flyout/overrides.test.js

@@ -7,7 +7,7 @@
 
 import { mountWithIntl, shallowWithIntl } from '@kbn/test/jest';
 import React from 'react';
-import { FILE_FORMATS } from '../../../../../common';
+import { FILE_FORMATS } from '../../../../../common/constants';
 
 import { Overrides } from './overrides';
 

x-pack/plugins/data_visualizer/public/application/file_data_visualizer/components/file_data_visualizer_view/file_error_callouts.tsx

@@ -11,7 +11,7 @@ import React, { FC } from 'react';
 import { EuiCallOut, EuiSpacer, EuiButtonEmpty, EuiHorizontalRule } from '@elastic/eui';
 
 import numeral from '@elastic/numeral';
-import { FILE_SIZE_DISPLAY_FORMAT } from '../../../../../common';
+import { FILE_SIZE_DISPLAY_FORMAT } from '../../../../../common/constants';
 import { FindFileStructureErrorResponse } from '../../../../../../file_upload/common';
 
 interface FileTooLargeProps {

x-pack/plugins/data_visualizer/public/application/index_data_visualizer/components/index_data_visualizer_view/index_data_visualizer_view.tsx

@@ -39,7 +39,7 @@ import { JobFieldType, SavedSearchSavedObject } from '../../../../../common/type
 import { useDataVisualizerKibana } from '../../../kibana_context';
 import { FieldCountPanel } from '../../../common/components/field_count_panel';
 import { DocumentCountContent } from '../../../common/components/document_count_content';
-import { OMIT_FIELDS } from '../../../../../common';
+import { OMIT_FIELDS } from '../../../../../common/constants';
 import { kbnTypeToJobType } from '../../../common/util/field_types_utils';
 import { SearchPanel } from '../search_panel';
 import { ActionsPanel } from '../actions_panel';

x-pack/plugins/data_visualizer/public/application/index_data_visualizer/components/search_panel/field_type_filter.tsx

@@ -8,7 +8,7 @@
 import React, { FC, useMemo } from 'react';
 import { EuiFlexGroup, EuiFlexItem } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
-import { JobFieldType } from '../../../../../common';
+import type { JobFieldType } from '../../../../../common/types';
 import { FieldTypeIcon } from '../../../common/components/field_type_icon';
 import { MultiSelectPicker, Option } from '../../../common/components/multi_select_picker';
 import { jobTypeLabels } from '../../../common/util/field_types_utils';

x-pack/plugins/data_visualizer/public/application/index_data_visualizer/embeddables/grid_embeddable/grid_embeddable.tsx

@@ -39,7 +39,7 @@ import {
 } from '../../../common/components/stats_table';
 import { FieldVisConfig } from '../../../common/components/stats_table/types';
 import { getDefaultDataVisualizerListState } from '../../components/index_data_visualizer_view/index_data_visualizer_view';
-import { DataVisualizerTableState, SavedSearchSavedObject } from '../../../../../common';
+import type { DataVisualizerTableState, SavedSearchSavedObject } from '../../../../../common/types';
 import { DataVisualizerIndexBasedAppState } from '../../types/index_data_visualizer_state';
 import { IndexBasedDataVisualizerExpandedRow } from '../../../common/components/expanded_row/index_based_expanded_row';
 import { useDataVisualizerGridData } from '../../hooks/use_data_visualizer_grid_data';

x-pack/plugins/data_visualizer/public/application/index_data_visualizer/hooks/use_data_visualizer_grid_data.ts

@@ -24,12 +24,11 @@ import {
 } from '../../../../../../../src/plugins/data/common';
 import { FieldVisConfig } from '../../common/components/stats_table/types';
 import {
-  FieldRequestConfig,
   JOB_FIELD_TYPES,
-  JobFieldType,
   NON_AGGREGATABLE_FIELD_TYPES,
   OMIT_FIELDS,
-} from '../../../../common';
+} from '../../../../common/constants';
+import type { FieldRequestConfig, JobFieldType } from '../../../../common/types';
 import { kbnTypeToJobType } from '../../common/util/field_types_utils';
 import { getActions } from '../../common/components/field_data_row/action_menu';
 import { DataVisualizerGridInput } from '../embeddables/grid_embeddable/grid_embeddable';

x-pack/plugins/data_visualizer/public/application/index_data_visualizer/hooks/use_field_stats.ts

@@ -18,7 +18,7 @@ import type {
   Field,
 } from '../../../../common/types/field_stats';
 import { useDataVisualizerKibana } from '../../kibana_context';
-import type { FieldRequestConfig } from '../../../../common';
+import type { FieldRequestConfig } from '../../../../common/types';
 import type { DataVisualizerIndexBasedAppState } from '../types/index_data_visualizer_state';
 import {
   buildBaseFilterCriteria,

x-pack/plugins/data_visualizer/public/application/index_data_visualizer/search_strategy/requests/get_fields_stats.ts

@@ -11,7 +11,7 @@ import type { FieldStatsError } from '../../../../../common/types/field_stats';
 import type { ISearchOptions } from '../../../../../../../../src/plugins/data/common';
 import { ISearchStart } from '../../../../../../../../src/plugins/data/public';
 import type { FieldStats } from '../../../../../common/types/field_stats';
-import { JOB_FIELD_TYPES } from '../../../../../common';
+import { JOB_FIELD_TYPES } from '../../../../../common/constants';
 import { fetchDateFieldsStats } from './get_date_field_stats';
 import { fetchBooleanFieldsStats } from './get_boolean_field_stats';
 import { fetchFieldsExamples } from './get_field_examples';

x-pack/plugins/data_visualizer/public/application/index_data_visualizer/utils/saved_search_utils.test.ts

@@ -10,7 +10,7 @@ import {
   createMergedEsQuery,
   getEsQueryFromSavedSearch,
 } from './saved_search_utils';
-import type { SavedSearchSavedObject } from '../../../../common';
+import type { SavedSearchSavedObject } from '../../../../common/types';
 import type { SavedSearch } from '../../../../../../../src/plugins/discover/public';
 import type { Filter, FilterStateStore } from '@kbn/es-query';
 import { stubbedSavedObjectIndexPattern } from '../../../../../../../src/plugins/data_views/common/data_view.stub';

x-pack/plugins/data_visualizer/public/register_home.ts

@@ -9,7 +9,12 @@ import { i18n } from '@kbn/i18n';
 import type { HomePublicPluginSetup } from '../../../../src/plugins/home/public';
 import { FeatureCatalogueCategory } from '../../../../src/plugins/home/public';
 import { FileDataVisualizerWrapper } from './lazy_load_bundle/component_wrapper';
-import { featureTitle, FILE_DATA_VIS_TAB_ID, applicationPath, featureId } from '../common';
+import {
+  featureTitle,
+  FILE_DATA_VIS_TAB_ID,
+  applicationPath,
+  featureId,
+} from '../common/constants';
 
 export function registerHomeAddData(home: HomePublicPluginSetup) {
   home.addData.registerAddDataTab({

x-pack/plugins/data_visualizer/server/register_custom_integration.ts

@@ -7,7 +7,7 @@
 
 import { i18n } from '@kbn/i18n';
 import { CustomIntegrationsPluginSetup } from '../../../../src/plugins/custom_integrations/server';
-import { applicationPath, featureId, featureTitle } from '../common';
+import { applicationPath, featureId, featureTitle } from '../common/constants';
 
 export function registerWithCustomIntegrations(customIntegrations: CustomIntegrationsPluginSetup) {
   customIntegrations.registerCustomIntegration({