removing seriesLabel from constructor function and keeping it as a va…

…riable in the isLegendShown function
elastic · Oct 28, 2014 · a99967b · a99967b
1 parent abfeb41
commit a99967b
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/kibana/components/vislib/lib/data.js b/src/kibana/components/vislib/lib/data.js
@@ -35,7 +35,6 @@ define(function (require) {
 
       this.data = data;
       this._normalizeOrdered();
-      this.seriesLabel;
 
       this._attr = _.defaults(attr || {}, {
 
@@ -93,18 +92,19 @@ define(function (require) {
       var isLegend = false;
       var visData = this.getVisData();
       var sameSeriesLabel = true;
+      var seriesLabel;
 
       _.forEach(visData, function countSeriesLength(obj) {
         var rootSeries = obj.series || (obj.slices && obj.slices.children);
         var dataLength = rootSeries ? rootSeries.length : 0;
         var label = dataLength === 1 ? rootSeries[0].label || rootSeries[0].name : undefined;
         var children = (obj.slices && obj.slices.children && obj.slices.children[0].children);
 
-        if (!this.seriesLabel) {
-          this.seriesLabel = label;
+        if (!seriesLabel) {
+          seriesLabel = label;
         }
 
-        if (this.seriesLabel !== label) {
+        if (seriesLabel !== label) {
           sameSeriesLabel = false;
         }