Adds SCSS as sideEffects

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
elastic · Apr 30, 2020 · af271bf · af271bf
1 parent 8146b35
commit af271bf
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -502,7 +502,7 @@
   },
   "sideEffects": [
     "./webpackShims/*.js",
-    "src/plugins/console/public/application/models/legacy_core_editor/mode/*.js"
+    "./src/plugins/console/public/application/models/legacy_core_editor/mode/*.js"
   ],
   "engines": {
     "node": "10.19.0",

diff --git a/packages/kbn-optimizer/src/worker/webpack.config.ts b/packages/kbn-optimizer/src/worker/webpack.config.ts
@@ -164,6 +164,7 @@ export function getWebpackConfig(bundle: Bundle, worker: WorkerConfig) {
               },
             },
           ],
+          sideEffects: true,
         },
         {
           test: /\.scss$/,
@@ -261,6 +262,7 @@ export function getWebpackConfig(bundle: Bundle, worker: WorkerConfig) {
               loader: require.resolve('./theme_loader'),
             },
           ],
+          sideEffects: true,
         },
         {
           test: /\.(woff|woff2|ttf|eot|svg|ico|png|jpg|gif|jpeg)(\?|$)/,

diff --git a/x-pack/package.json b/x-pack/package.json
@@ -16,9 +16,7 @@
     "test:jest": "node scripts/jest",
     "test:mocha": "node scripts/mocha"
   },
-  "sideEffects": [
-    "./webpackShims/*.js"
-  ],
+  "sideEffects": false,
   "kibana": {
     "build": {
       "intermediateBuildDirectory": "build/plugin/kibana/x-pack",