Skip to content

Commit

Permalink
[tests] Rename apps option to appSuites so we don't override the inte…
Browse files Browse the repository at this point in the history
…rn.apps object
  • Loading branch information
jbudz committed Jul 19, 2016
1 parent bcfc69c commit b053aad
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ Run the tests for just your particular plugin. Assuming you plugin lives outside
The following will start Kibana, Elasticsearch and the chromedriver for you. To run the functional UI tests use the following commands

`npm run test:ui`
Run the functional UI tests one time and exit. This is used by the CI systems and is great for quickly checking that things pass. It is essentially a combination of the next two tasks. This supports options `--grep=foo` for only running tests that match a regular expression, and `--apps=management` for running tests for a specific application.
Run the functional UI tests one time and exit. This is used by the CI systems and is great for quickly checking that things pass. It is essentially a combination of the next two tasks. This supports options `--grep=foo` for only running tests that match a regular expression, and `--appSuites=management` for running tests for a specific application.

`npm run test:ui:server`
Start the server required for the `test:ui:runner` tasks. Once the server is started `test:ui:runner` can be run multiple times without waiting for the server to start.
Expand Down
2 changes: 1 addition & 1 deletion tasks/config/intern.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = function (grunt) {
reporters: ['Console'],
grep: grunt.option('grep'),
functionalSuites: grunt.option('functionalSuites'),
apps: grunt.option('apps')
appSuites: grunt.option('appSuites')
},
dev: {},
api: {
Expand Down
2 changes: 1 addition & 1 deletion test/functional/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ define(function (require) {
const option = arg.split('=');
const key = option[0];
const value = option[1];
if (key === 'apps' && value) return value.split(',');
if (key === 'appSuites' && value) return value.split(',');
});

const apps = [
Expand Down

0 comments on commit b053aad

Please sign in to comment.