[7.x] Upgrade Prettier 1.19 (#50506)

* Upgrade Prettier to 1.19

* Fix all prettier issues

package.json

@@ -427,7 +427,7 @@
     "pngjs": "^3.4.0",
     "postcss": "^7.0.5",
     "postcss-url": "^8.0.0",
-    "prettier": "^1.18.2",
+    "prettier": "^1.19.1",
     "proxyquire": "1.8.0",
     "regenerate": "^1.4.0",
     "sass-lint": "^1.12.1",

packages/kbn-dev-utils/src/proc_runner/observe_readable.ts

@@ -29,10 +29,7 @@ import { first, ignoreElements, mergeMap } from 'rxjs/operators';
  */
 export function observeReadable(readable: Readable): Rx.Observable<never> {
   return Rx.race(
-    Rx.fromEvent(readable, 'end').pipe(
-      first(),
-      ignoreElements()
-    ),
+    Rx.fromEvent(readable, 'end').pipe(first(), ignoreElements()),
 
     Rx.fromEvent(readable, 'error').pipe(
       first(),

packages/kbn-dev-utils/src/tooling_log/tooling_log.test.ts

@@ -112,10 +112,7 @@ describe('#getWritten$()', () => {
     const done$ = new Rx.Subject();
     const promise = log
       .getWritten$()
-      .pipe(
-        takeUntil(done$),
-        toArray()
-      )
+      .pipe(takeUntil(done$), toArray())
       .toPromise();
 
     log.debug('foo');

packages/kbn-pm/package.json

@@ -50,7 +50,7 @@
     "log-symbols": "^2.2.0",
     "ncp": "^2.0.0",
     "ora": "^1.4.0",
-    "prettier": "^1.18.2",
+    "prettier": "^1.19.1",
     "read-pkg": "^5.2.0",
     "rxjs": "^6.5.3",
     "spawn-sync": "^1.0.15",

packages/kbn-pm/src/commands/bootstrap.test.ts

@@ -101,7 +101,12 @@ test('handles dependencies of dependencies', async () => {
     'packages/baz'
   );
 
-  const projects = new Map([['kibana', kibana], ['foo', foo], ['bar', bar], ['baz', baz]]);
+  const projects = new Map([
+    ['kibana', kibana],
+    ['foo', foo],
+    ['bar', bar],
+    ['baz', baz],
+  ]);
   const projectGraph = buildProjectGraph(projects);
 
   const logMock = jest.spyOn(console, 'log').mockImplementation(noop);
@@ -133,7 +138,10 @@ test('does not run installer if no deps in package', async () => {
     'packages/bar'
   );
 
-  const projects = new Map([['kibana', kibana], ['bar', bar]]);
+  const projects = new Map([
+    ['kibana', kibana],
+    ['bar', bar],
+  ]);
   const projectGraph = buildProjectGraph(projects);
 
   const logMock = jest.spyOn(console, 'log').mockImplementation(noop);
@@ -193,7 +201,10 @@ test('calls "kbn:bootstrap" scripts and links executables after installing deps'
     'packages/bar'
   );
 
-  const projects = new Map([['kibana', kibana], ['bar', bar]]);
+  const projects = new Map([
+    ['kibana', kibana],
+    ['bar', bar],
+  ]);
   const projectGraph = buildProjectGraph(projects);
 
   jest.spyOn(console, 'log').mockImplementation(noop);

packages/kbn-spec-to-console/package.json

@@ -18,7 +18,7 @@
   "homepage": "https://github.com/jbudz/spec-to-console#readme",
   "devDependencies": {
     "jest": "^24.9.0",
-    "prettier": "^1.18.2"
+    "prettier": "^1.19.1"
   },
   "dependencies": {
     "commander": "^2.11.0",

src/core/public/chrome/nav_links/nav_links_service.ts

@@ -130,10 +130,7 @@ export class NavLinksService {
 
     return {
       getNavLinks$: () => {
-        return navLinks$.pipe(
-          map(sortNavLinks),
-          takeUntil(this.stop$)
-        );
+        return navLinks$.pipe(map(sortNavLinks), takeUntil(this.stop$));
       },
 
       get(id: string) {
@@ -192,7 +189,10 @@ export class NavLinksService {
 }
 
 function sortNavLinks(navLinks: ReadonlyMap<string, NavLinkWrapper>) {
-  return sortBy([...navLinks.values()].map(link => link.properties), 'order');
+  return sortBy(
+    [...navLinks.values()].map(link => link.properties),
+    'order'
+  );
 }
 
 function relativeToAbsolute(url: string) {

src/core/public/chrome/recently_accessed/recently_accessed_service.test.ts

@@ -106,10 +106,7 @@ describe('RecentlyAccessed#start()', () => {
     const stop$ = new Subject();
     const observedValues$ = recentlyAccessed
       .get$()
-      .pipe(
-        bufferCount(3),
-        takeUntil(stop$)
-      )
+      .pipe(bufferCount(3), takeUntil(stop$))
       .toPromise();
     recentlyAccessed.add('/app/item1', 'Item 1', 'item1');
     recentlyAccessed.add('/app/item2', 'Item 2', 'item2');

src/core/public/core_system.test.ts

@@ -174,7 +174,10 @@ describe('#setup()', () => {
   it('injects legacy dependency to context#setup()', async () => {
     const pluginA = Symbol();
     const pluginB = Symbol();
-    const pluginDependencies = new Map<symbol, symbol[]>([[pluginA, []], [pluginB, [pluginA]]]);
+    const pluginDependencies = new Map<symbol, symbol[]>([
+      [pluginA, []],
+      [pluginB, [pluginA]],
+    ]);
     MockPluginsService.getOpaqueIds.mockReturnValue(pluginDependencies);
     await setupCore();
 

src/core/public/injected_metadata/injected_metadata_service.test.ts

@@ -68,18 +68,27 @@ describe('setup.getPlugins()', () => {
   it('returns injectedMetadata.uiPlugins', () => {
     const injectedMetadata = new InjectedMetadataService({
       injectedMetadata: {
-        uiPlugins: [{ id: 'plugin-1', plugin: {} }, { id: 'plugin-2', plugin: {} }],
+        uiPlugins: [
+          { id: 'plugin-1', plugin: {} },
+          { id: 'plugin-2', plugin: {} },
+        ],
       },
     } as any);
 
     const plugins = injectedMetadata.setup().getPlugins();
-    expect(plugins).toEqual([{ id: 'plugin-1', plugin: {} }, { id: 'plugin-2', plugin: {} }]);
+    expect(plugins).toEqual([
+      { id: 'plugin-1', plugin: {} },
+      { id: 'plugin-2', plugin: {} },
+    ]);
   });
 
   it('returns frozen version of uiPlugins', () => {
     const injectedMetadata = new InjectedMetadataService({
       injectedMetadata: {
-        uiPlugins: [{ id: 'plugin-1', plugin: {} }, { id: 'plugin-2', plugin: {} }],
+        uiPlugins: [
+          { id: 'plugin-1', plugin: {} },
+          { id: 'plugin-2', plugin: {} },
+        ],
       },
     } as any);
 

src/core/public/overlays/banners/priority_map.test.ts

@@ -42,7 +42,10 @@ describe('PriorityMap', () => {
     map = map.add('b', { priority: 3 });
     map = map.add('c', { priority: 2 });
     map = map.remove('c');
-    expect([...map]).toEqual([['b', { priority: 3 }], ['a', { priority: 1 }]]);
+    expect([...map]).toEqual([
+      ['b', { priority: 3 }],
+      ['a', { priority: 1 }],
+    ]);
   });
 
   it('adds duplicate priorities to end', () => {

src/core/public/plugins/plugins_service.test.ts

@@ -223,10 +223,13 @@ test('`PluginsService.setup` exposes dependent setup contracts to plugins', asyn
 
 test('`PluginsService.setup` does not set missing dependent setup contracts', async () => {
   plugins = [{ id: 'pluginD', plugin: createManifest('pluginD', { optional: ['missing'] }) }];
-  mockPluginInitializers.set('pluginD', jest.fn(() => ({
-    setup: jest.fn(),
-    start: jest.fn(),
-  })) as any);
+  mockPluginInitializers.set(
+    'pluginD',
+    jest.fn(() => ({
+      setup: jest.fn(),
+      start: jest.fn(),
+    })) as any
+  );
 
   const pluginsService = new PluginsService(mockCoreContext, plugins);
   await pluginsService.setup(mockSetupDeps);
@@ -268,10 +271,13 @@ test('`PluginsService.start` exposes dependent start contracts to plugins', asyn
 
 test('`PluginsService.start` does not set missing dependent start contracts', async () => {
   plugins = [{ id: 'pluginD', plugin: createManifest('pluginD', { optional: ['missing'] }) }];
-  mockPluginInitializers.set('pluginD', jest.fn(() => ({
-    setup: jest.fn(),
-    start: jest.fn(),
-  })) as any);
+  mockPluginInitializers.set(
+    'pluginD',
+    jest.fn(() => ({
+      setup: jest.fn(),
+      start: jest.fn(),
+    })) as any
+  );
 
   const pluginsService = new PluginsService(mockCoreContext, plugins);
   await pluginsService.setup(mockSetupDeps);

src/core/public/ui_settings/ui_settings_api.test.ts

@@ -183,10 +183,7 @@ describe('#getLoadingCount$()', () => {
     const done$ = new Rx.Subject();
     const promise = uiSettingsApi
       .getLoadingCount$()
-      .pipe(
-        takeUntil(done$),
-        toArray()
-      )
+      .pipe(takeUntil(done$), toArray())
       .toPromise();
 
     await uiSettingsApi.batchSet('foo', 'bar');
@@ -214,10 +211,7 @@ describe('#getLoadingCount$()', () => {
     const done$ = new Rx.Subject();
     const promise = uiSettingsApi
       .getLoadingCount$()
-      .pipe(
-        takeUntil(done$),
-        toArray()
-      )
+      .pipe(takeUntil(done$), toArray())
       .toPromise();
 
     await uiSettingsApi.batchSet('foo', 'bar');
@@ -250,7 +244,10 @@ describe('#stop', () => {
     uiSettingsApi.stop();
 
     // both observables should emit the same values, and complete before the request is done loading
-    await expect(promise).resolves.toEqual([[0, 1], [0, 1]]);
+    await expect(promise).resolves.toEqual([
+      [0, 1],
+      [0, 1],
+    ]);
     await batchSetPromise;
   });
 });

src/core/public/ui_settings/ui_settings_client.test.ts

@@ -83,10 +83,7 @@ describe('#get$', () => {
     const { config } = setup();
     const values = await config
       .get$('dateFormat')
-      .pipe(
-        take(1),
-        toArray()
-      )
+      .pipe(take(1), toArray())
       .toPromise();
 
     expect(values).toEqual(['Browser']);
@@ -122,10 +119,7 @@ You can use \`config.get("unknown key", defaultValue)\`, which will just return
 
     const values = await config
       .get$('dateFormat')
-      .pipe(
-        take(2),
-        toArray()
-      )
+      .pipe(take(2), toArray())
       .toPromise();
 
     expect(values).toEqual(['Browser', 'new format']);
@@ -144,10 +138,7 @@ You can use \`config.get("unknown key", defaultValue)\`, which will just return
 
     const values = await config
       .get$('dateFormat', 'my default')
-      .pipe(
-        take(3),
-        toArray()
-      )
+      .pipe(take(3), toArray())
       .toPromise();
 
     expect(values).toEqual(['my default', 'new format', 'my default']);

src/core/public/utils/share_weak_replay.test.ts

@@ -153,10 +153,7 @@ Array [
 });
 
 it('resubscribes if parent completes', async () => {
-  const shared = counter().pipe(
-    take(4),
-    shareWeakReplay(4)
-  );
+  const shared = counter().pipe(take(4), shareWeakReplay(4));
 
   await expect(Promise.all([record(shared.pipe(take(1))), record(shared)])).resolves
     .toMatchInlineSnapshot(`
@@ -199,10 +196,7 @@ Array [
 it('supports parents that complete synchronously', async () => {
   const next = jest.fn();
   const complete = jest.fn();
-  const shared = counter({ async: false }).pipe(
-    take(3),
-    shareWeakReplay(1)
-  );
+  const shared = counter({ async: false }).pipe(take(3), shareWeakReplay(1));
 
   shared.subscribe({ next, complete });
   expect(next.mock.calls).toMatchInlineSnapshot(`

src/core/server/config/ensure_deep_object.ts

@@ -34,19 +34,16 @@ export function ensureDeepObject(obj: any): any {
     return obj.map(item => ensureDeepObject(item));
   }
 
-  return Object.keys(obj).reduce(
-    (fullObject, propertyKey) => {
-      const propertyValue = obj[propertyKey];
-      if (!propertyKey.includes(separator)) {
-        fullObject[propertyKey] = ensureDeepObject(propertyValue);
-      } else {
-        walk(fullObject, propertyKey.split(separator), propertyValue);
-      }
-
-      return fullObject;
-    },
-    {} as any
-  );
+  return Object.keys(obj).reduce((fullObject, propertyKey) => {
+    const propertyValue = obj[propertyKey];
+    if (!propertyKey.includes(separator)) {
+      fullObject[propertyKey] = ensureDeepObject(propertyValue);
+    } else {
+      walk(fullObject, propertyKey.split(separator), propertyValue);
+    }
+
+    return fullObject;
+  }, {} as any);
 }
 
 function walk(obj: any, keys: string[], value: any) {

src/core/server/plugins/plugins_system.ts

@@ -77,18 +77,15 @@ export class PluginsSystem {
 
       this.log.debug(`Setting up plugin "${pluginName}"...`);
       const pluginDeps = new Set([...plugin.requiredPlugins, ...plugin.optionalPlugins]);
-      const pluginDepContracts = Array.from(pluginDeps).reduce(
-        (depContracts, dependencyName) => {
-          // Only set if present. Could be absent if plugin does not have server-side code or is a
-          // missing optional dependency.
-          if (contracts.has(dependencyName)) {
-            depContracts[dependencyName] = contracts.get(dependencyName);
-          }
-
-          return depContracts;
-        },
-        {} as Record<PluginName, unknown>
-      );
+      const pluginDepContracts = Array.from(pluginDeps).reduce((depContracts, dependencyName) => {
+        // Only set if present. Could be absent if plugin does not have server-side code or is a
+        // missing optional dependency.
+        if (contracts.has(dependencyName)) {
+          depContracts[dependencyName] = contracts.get(dependencyName);
+        }
+
+        return depContracts;
+      }, {} as Record<PluginName, unknown>);
 
       contracts.set(
         pluginName,
@@ -116,18 +113,15 @@ export class PluginsSystem {
       this.log.debug(`Starting plugin "${pluginName}"...`);
       const plugin = this.plugins.get(pluginName)!;
       const pluginDeps = new Set([...plugin.requiredPlugins, ...plugin.optionalPlugins]);
-      const pluginDepContracts = Array.from(pluginDeps).reduce(
-        (depContracts, dependencyName) => {
-          // Only set if present. Could be absent if plugin does not have server-side code or is a
-          // missing optional dependency.
-          if (contracts.has(dependencyName)) {
-            depContracts[dependencyName] = contracts.get(dependencyName);
-          }
-
-          return depContracts;
-        },
-        {} as Record<PluginName, unknown>
-      );
+      const pluginDepContracts = Array.from(pluginDeps).reduce((depContracts, dependencyName) => {
+        // Only set if present. Could be absent if plugin does not have server-side code or is a
+        // missing optional dependency.
+        if (contracts.has(dependencyName)) {
+          depContracts[dependencyName] = contracts.get(dependencyName);
+        }
+
+        return depContracts;
+      }, {} as Record<PluginName, unknown>);
 
       contracts.set(
         pluginName,