Fix type issues after browser duration changes

elastic · Nov 21, 2019 · b433369 · b433369
1 parent 354fa45
commit b433369
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 7 deletions.
diff --git a/x-pack/legacy/plugins/apm/server/lib/transactions/avg_duration_by_browser/fetcher.test.ts b/x-pack/legacy/plugins/apm/server/lib/transactions/avg_duration_by_browser/fetcher.test.ts
@@ -4,7 +4,11 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { Setup } from '../../helpers/setup_request';
+import {
+  Setup,
+  SetupTimeRange,
+  SetupUIFilters
+} from '../../helpers/setup_request';
 import { fetcher } from './fetcher';
 
 describe('fetcher', () => {
@@ -14,7 +18,7 @@ describe('fetcher', () => {
       client: { search },
       indices: {},
       uiFiltersES: []
-    } as unknown) as Setup;
+    } as unknown) as Setup & SetupTimeRange & SetupUIFilters;
 
     await fetcher({ serviceName: 'testServiceName', setup });
 

diff --git a/x-pack/legacy/plugins/apm/server/lib/transactions/avg_duration_by_browser/index.ts b/x-pack/legacy/plugins/apm/server/lib/transactions/avg_duration_by_browser/index.ts
@@ -5,13 +5,17 @@
  */
 
 import { Coordinate } from '../../../../typings/timeseries';
-import { Setup } from '../../helpers/setup_request';
+import {
+  Setup,
+  SetupTimeRange,
+  SetupUIFilters
+} from '../../helpers/setup_request';
 import { fetcher } from './fetcher';
 import { transformer } from './transformer';
 
 export interface Options {
   serviceName: string;
-  setup: Setup;
+  setup: Setup & SetupTimeRange & SetupUIFilters;
 }
 
 export type AvgDurationByBrowserAPIResponse = Array<{

diff --git a/x-pack/legacy/plugins/apm/server/routes/transaction_groups.ts b/x-pack/legacy/plugins/apm/server/routes/transaction_groups.ts
@@ -160,9 +160,9 @@ export const transactionGroupsAvgDurationByBrowser = createRoute(() => ({
       rangeRt
     ])
   },
-  handler: async (req, { path }) => {
-    const setup = await setupRequest(req);
-    const { serviceName } = path;
+  handler: async ({ context, request }) => {
+    const setup = await setupRequest(context, request);
+    const { serviceName } = context.params.path;
 
     return getTransactionAvgDurationByBrowser({
       serviceName,