fix data-shared-items-container on visualise page (#52370)

Addresses #52109 (comment) Should fix #51309, Regression was introduced in: #46910
elastic · Dec 7, 2019 · b66af16 · b66af16
1 parent 5007bbf
commit b66af16
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/src/legacy/core_plugins/kibana/public/visualize/embeddable/visualize_embeddable.ts b/src/legacy/core_plugins/kibana/public/visualize/embeddable/visualize_embeddable.ts
@@ -313,7 +313,6 @@ export class VisualizeEmbeddable extends Embeddable<VisualizeInput, VisualizeOut
 
     div.setAttribute('data-test-subj', 'visualizationLoader');
     div.setAttribute('data-shared-item', '');
-    div.setAttribute('data-shared-item-container', '');
     div.setAttribute('data-rendering-count', '0');
     div.setAttribute('data-render-complete', 'false');
 

diff --git a/src/legacy/ui/public/vis/editors/default/default.html b/src/legacy/ui/public/vis/editors/default/default.html
@@ -11,6 +11,7 @@
 
   <div
     class="visEditor__canvas"
+    data-shared-items-container
   />
 
 </div>
diff --git a/test/functional/page_objects/common_page.ts b/test/functional/page_objects/common_page.ts
@@ -288,7 +288,7 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
     }
 
     async getSharedItemContainers() {
-      const cssSelector = '[data-shared-item-container]';
+      const cssSelector = '[data-shared-items-container]';
       return find.allByCssSelector(cssSelector);
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -11,6 +11,7 @@ @@
       <div
         class="visEditor__canvas"
+        data-shared-items-container
       />
     </div>