fix for mr michael

elastic · Oct 27, 2022 · c0f35b9 · c0f35b9
1 parent d0c8a92
commit c0f35b9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/x-pack/plugins/security_solution/public/common/components/event_details/event_details.tsx b/x-pack/plugins/security_solution/public/common/components/event_details/event_details.tsx
@@ -406,14 +406,19 @@ const EventDetailsComponent: React.FC<Props> = ({
     [tabs, selectedTabId]
   );
 
+  const tourAnchor = useMemo(
+    () => (isTourAnchor ? { 'tour-step': getTourAnchor(3, SecurityStepId.alertsCases) } : {}),
+    [isTourAnchor]
+  );
+
   return (
     <GuidedOnboardingTourStep
       isTourAnchor={isTourAnchor}
       step={3}
       stepId={SecurityStepId.alertsCases}
     >
       <StyledEuiTabbedContent
-        {...(isTourAnchor ? { 'tour-step': getTourAnchor(3, SecurityStepId.alertsCases) } : {})}
+        {...tourAnchor}
         data-test-subj="eventDetails"
         tabs={tabs}
         selectedTab={selectedTab}

diff --git a/...k/plugins/security_solution/public/common/components/guided_onboarding_tour/tour_step.tsx b/...k/plugins/security_solution/public/common/components/guided_onboarding_tour/tour_step.tsx
@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import React, { useMemo } from 'react';
+import React, { useCallback, useMemo } from 'react';
 
 import type { EuiTourStepProps } from '@elastic/eui';
 import { EuiButton, EuiImage, EuiSpacer, EuiText, EuiTourStep } from '@elastic/eui';
@@ -25,6 +25,7 @@ export const SecurityTourStep = ({ children, step, stepId }: SecurityTourStep) =
     () => securityTourConfig[stepId].find((config) => config.step === step),
     [step, stepId]
   );
+  const onClick = useCallback(() => incrementStep(stepId), [incrementStep, stepId]);
   // step === 5 && stepId === SecurityStepId.alertsCases is in Cases app and out of context.
   // If we mount this step, we know we need to render it
   // we are also managing the context on the siem end in the background
@@ -38,7 +39,7 @@ export const SecurityTourStep = ({ children, step, stepId }: SecurityTourStep) =
   const footerAction: EuiTourStepProps['footerAction'] = !hideNextButton ? (
     <EuiButton
       size="s"
-      onClick={() => incrementStep(stepId)}
+      onClick={onClick}
       color="success"
       data-test-subj="onboarding--securityTourNextStepButton"
       tour-step="nextButton"

diff --git a/x-pack/plugins/security_solution/public/timelines/components/timeline/body/actions/index.tsx b/x-pack/plugins/security_solution/public/timelines/components/timeline/body/actions/index.tsx
@@ -211,7 +211,6 @@ const ActionsComponent: React.FC<ActionProps> = ({
     () =>
       isTourShown(SecurityStepId.alertsCases) &&
       eventType === 'signal' &&
-      // TODO: Steph make sure this is right
       isDetectionsAlertsTable(timelineId) &&
       ariaRowindex === 1,
     [isTourShown, ariaRowindex, eventType, timelineId]