Addressing code review comments

elastic · Sep 9, 2020 · c1af6e2 · c1af6e2
1 parent 056a67f
commit c1af6e2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/x-pack/plugins/ml/common/types/file_datavisualizer.ts b/x-pack/plugins/ml/common/types/file_datavisualizer.ts
@@ -84,6 +84,9 @@ export interface Settings {
 }
 
 export interface Mappings {
+  _meta?: {
+    created_by: string;
+  };
   properties: {
     [key: string]: any;
   };

diff --git a/x-pack/plugins/ml/server/models/file_data_visualizer/import_data.ts b/x-pack/plugins/ml/server/models/file_data_visualizer/import_data.ts
@@ -89,7 +89,7 @@ export function importDataProvider({ asCurrentUser }: IScopedClusterClient) {
   }
 
   async function createIndex(index: string, settings: Settings, mappings: Mappings) {
-    const body: { mappings: Mappings } = {
+    const body: { mappings: Mappings; settings?: Settings } = {
       mappings: {
         _meta: {
           created_by: INDEX_META_DATA_CREATED_BY,