Fix more type definitions to require pageSize

- note: to take advantage of the new table pagination defaults, consider removing the initially set `pageSize` state
elastic · Aug 15, 2023 · c6daf9b · c6daf9b
1 parent 7c08114
commit c6daf9b
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/x-pack/packages/security-solution/data_table/components/data_table/index.tsx b/x-pack/packages/security-solution/data_table/components/data_table/index.tsx
@@ -92,7 +92,7 @@ interface BaseDataTableProps {
   rowRenderers: DeprecatedRowRenderer[];
   hasCrudPermissions?: boolean;
   unitCountText: string;
-  pagination: EuiDataGridPaginationProps;
+  pagination: EuiDataGridPaginationProps & { pageSize: number };
   totalItems: number;
   rowHeightsOptions?: EuiDataGridRowHeightsOptions;
   isEventRenderedView?: boolean;

diff --git a/...ud_security_posture/public/pages/configurations/latest_findings/latest_findings_table.tsx b/...ud_security_posture/public/pages/configurations/latest_findings/latest_findings_table.tsx
@@ -31,7 +31,7 @@ type TableProps = Required<EuiBasicTableProps<CspFinding>>;
 interface Props {
   loading: boolean;
   items: CspFinding[];
-  pagination: Pagination;
+  pagination: Pagination & { pageSize: number };
   sorting: TableProps['sorting'];
   setTableOptions(options: CriteriaWithPagination<CspFinding>): void;
   onAddFilter: OnAddFilter;

diff --git a/.../configurations/latest_findings_by_resource/resource_findings/resource_findings_table.tsx b/.../configurations/latest_findings_by_resource/resource_findings/resource_findings_table.tsx
@@ -29,7 +29,7 @@ import { EmptyState } from '../../../../components/empty_state';
 export interface ResourceFindingsTableProps {
   items: CspFinding[];
   loading: boolean;
-  pagination: Pagination;
+  pagination: Pagination & { pageSize: number };
   sorting: Required<EuiBasicTableProps<CspFinding>>['sorting'];
   setTableOptions(options: CriteriaWithPagination<CspFinding>): void;
   onAddFilter: OnAddFilter;

diff --git a/x-pack/plugins/security_solution/public/exceptions/components/exceptions_utility/index.tsx b/x-pack/plugins/security_solution/public/exceptions/components/exceptions_utility/index.tsx
@@ -37,7 +37,7 @@ const StyledCondition = styled.span`
 interface ExceptionsUtilityComponentProps {
   dataTestSubj?: string;
   exceptionsTitle?: string;
-  pagination: Pagination;
+  pagination: Pagination & { pageSize: number };
   // Corresponds to last time exception items were fetched
   lastUpdated: string | number | null;
 }

diff --git a/x-pack/plugins/security_solution/public/exceptions/components/list_exception_items/index.tsx b/x-pack/plugins/security_solution/public/exceptions/components/list_exception_items/index.tsx
@@ -28,7 +28,7 @@ interface ListExceptionItemsProps {
   exceptions: ExceptionListItemSchema[];
   listType: ExceptionListTypeEnum;
   lastUpdated: string | number | null;
-  pagination: Pagination;
+  pagination: Pagination & { pageSize: number };
   emptyViewerTitle?: string;
   emptyViewerBody?: string;
   emptyViewerButtonText?: string;

diff --git a/x-pack/plugins/security_solution/public/exceptions/hooks/use_list_exception_items/index.ts b/x-pack/plugins/security_solution/public/exceptions/hooks/use_list_exception_items/index.ts
@@ -45,7 +45,7 @@ export const useListExceptionItems = ({
 
   const [exceptions, setExceptions] = useState<ExceptionListItemSchema[]>([]);
   const [exceptionListReferences, setExceptionListReferences] = useState<RuleReferences>({});
-  const [pagination, setPagination] = useState<Pagination>({
+  const [pagination, setPagination] = useState<Pagination & { pageSize: number }>({
     pageIndex: 0,
     pageSize: 0,
     totalItemCount: 0,

diff --git a/...riggers_actions_ui/public/application/sections/rule_details/components/rule_error_log.tsx b/...riggers_actions_ui/public/application/sections/rule_details/components/rule_error_log.tsx
@@ -112,7 +112,7 @@ export const RuleErrorLog = (props: RuleErrorLogProps) => {
 
   const isOnLastPage = useMemo(() => {
     const { pageIndex, pageSize } = pagination;
-    return (pageIndex + 1) * pageSize >= MAX_RESULTS;
+    return (pageIndex + 1) * pageSize! >= MAX_RESULTS;
   }, [pagination]);
 
   const formattedSort = useMemo(() => {