fixing crash when zero replicas configured in a phase for policy (#34480

) (#34496)
elastic · Apr 4, 2019 · c74188a · c74188a
1 parent 407f1ba
commit c74188a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/x-pack/plugins/index_lifecycle_management/public/store/selectors/policies.js b/x-pack/plugins/index_lifecycle_management/public/store/selectors/policies.js
@@ -124,7 +124,7 @@ export const splitSizeAndUnits = field => {
 
 export const isNumber = value => typeof value === 'number';
 export const isEmptyObject = (obj) => {
-  return Object.entries(obj).length === 0 && obj.constructor === Object;
+  return !obj || (Object.entries(obj).length === 0 && obj.constructor === Object);
 };
 
 export const phaseFromES = (phase, phaseName, defaultEmptyPolicy) => {
@@ -275,7 +275,7 @@ export const phaseToES = (phase, originalEsPhase) => {
   }
   if (esPhase.actions.allocate
       && !esPhase.actions.allocate.require
-      && !esPhase.actions.allocate.number_of_replicas
+      && !isNumber(esPhase.actions.allocate.number_of_replicas)
       && isEmptyObject(esPhase.actions.allocate.include)
       && isEmptyObject(esPhase.actions.allocate.exclude)
   ) {