pr comments

elastic · Jun 24, 2024 · c898312 · c898312
1 parent 48a462a
commit c898312
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 8 deletions.
diff --git a/...create_package_policy_page/components/steps/components/package_policy_input_var_field.tsx b/...create_package_policy_page/components/steps/components/package_policy_input_var_field.tsx
@@ -420,6 +420,7 @@ function SecretInputField({
           iconType="refresh"
           iconSide="left"
           size="xs"
+          data-test-subj={`button-replace${lowercaseTitle}`}
         >
           <FormattedMessage
             id="xpack.fleet.editPackagePolicy.stepConfigure.fieldSecretValueSetEditButton"

diff --git a/x-pack/test/cloud_security_posture_functional/page_objects/add_cis_integration_form_page.ts b/x-pack/test/cloud_security_posture_functional/page_objects/add_cis_integration_form_page.ts
@@ -263,6 +263,10 @@ export function AddCisIntegrationFormPageProvider({
     return stringToFind;
   };
 
+  const getReplaceSecretButton = async (secretField: string) => {
+    return await testSubjects.find(`button-replace${secretField}`);
+  };
+
   return {
     cisAzure,
     cisAws,
@@ -295,5 +299,6 @@ export function AddCisIntegrationFormPageProvider({
     isOptionChecked,
     checkIntegrationPliAuthBlockExists,
     doesStringExist,
+    getReplaceSecretButton,
   };
 }
diff --git a/...test/cloud_security_posture_functional/pages/cis_integrations/cspm/cis_integration_aws.ts b/...test/cloud_security_posture_functional/pages/cis_integrations/cspm/cis_integration_aws.ts
@@ -124,7 +124,7 @@ export default function (providerContext: FtrProviderContext) {
           (await cisIntegration.getFieldValueInEditPage(DIRECT_ACCESS_KEY_ID_TEST_ID)) ===
             directAccessKeyId
         ).to.be(true);
-        expect(await cisIntegration.doesStringExist('Replace secret access key')).to.not.be(null);
+        expect(await cisIntegration.getReplaceSecretButton('secret access key')).to.not.be(null);
       });
     });
 
@@ -160,7 +160,7 @@ export default function (providerContext: FtrProviderContext) {
           (await cisIntegration.getValueInEditPage(TEMP_ACCESS_SESSION_TOKEN_TEST_ID)) ===
             tempAccessSessionToken
         ).to.be(true);
-        expect(await cisIntegration.doesStringExist('Replace secret access key')).to.not.be(null);
+        expect(await cisIntegration.getReplaceSecretButton('secret access key')).to.not.be(null);
       });
     });
 
@@ -249,7 +249,7 @@ export default function (providerContext: FtrProviderContext) {
           (await cisIntegration.getFieldValueInEditPage(DIRECT_ACCESS_KEY_ID_TEST_ID)) ===
             directAccessKeyId
         ).to.be(true);
-        expect(await cisIntegration.doesStringExist('Replace secret access key')).to.not.be(null);
+        expect(await cisIntegration.getReplaceSecretButton('secret access key')).to.not.be(null);
       });
     });
 
@@ -286,7 +286,7 @@ export default function (providerContext: FtrProviderContext) {
           (await cisIntegration.getValueInEditPage(TEMP_ACCESS_SESSION_TOKEN_TEST_ID)) ===
             tempAccessSessionToken
         ).to.be(true);
-        expect(await cisIntegration.doesStringExist('Replace secret access key')).to.not.be(null);
+        expect(await cisIntegration.getReplaceSecretButton('secret access key')).to.not.be(null);
       });
     });
 

diff --git a/...st/cloud_security_posture_functional/pages/cis_integrations/cspm/cis_integration_azure.ts b/...st/cloud_security_posture_functional/pages/cis_integrations/cspm/cis_integration_azure.ts
@@ -111,7 +111,7 @@ export default function (providerContext: FtrProviderContext) {
             CIS_AZURE_INPUT_FIELDS_TEST_SUBJECTS.TENANT_ID
           )) === tenantId
         ).to.be(true);
-        expect(await cisIntegration.doesStringExist('Replace client secret')).to.not.be(null);
+        expect(await cisIntegration.getReplaceSecretButton('client secret')).to.not.be(null);
       });
     });
 
@@ -223,7 +223,7 @@ export default function (providerContext: FtrProviderContext) {
             CIS_AZURE_INPUT_FIELDS_TEST_SUBJECTS.TENANT_ID
           )) === tenantId
         ).to.be(true);
-        expect(await cisIntegration.doesStringExist('Replace client secret')).to.not.be(null);
+        expect(await cisIntegration.getReplaceSecretButton('client secret')).to.not.be(null);
       });
     });
 

diff --git a/...test/cloud_security_posture_functional/pages/cis_integrations/kspm/cis_integration_eks.ts b/...test/cloud_security_posture_functional/pages/cis_integrations/kspm/cis_integration_eks.ts
@@ -72,7 +72,7 @@ export default function (providerContext: FtrProviderContext) {
           (await cisIntegration.getFieldValueInEditPage(DIRECT_ACCESS_KEY_ID_TEST_ID)) ===
             directAccessKeyId
         ).to.be(true);
-        expect(await cisIntegration.doesStringExist('Replace secret access key')).to.not.be(null);
+        expect(await cisIntegration.getReplaceSecretButton('secret access key')).to.not.be(null);
       });
     });
 
@@ -107,7 +107,7 @@ export default function (providerContext: FtrProviderContext) {
           (await cisIntegration.getValueInEditPage(TEMP_ACCESS_SESSION_TOKEN_TEST_ID)) ===
             tempAccessSessionToken
         ).to.be(true);
-        expect(await cisIntegration.doesStringExist('Replace secret access key')).to.not.be(null);
+        expect(await cisIntegration.getReplaceSecretButton('secret access key')).to.not.be(null);
       });
     });