cleaning up tabify to return Datatable (#89857) (#90139)

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md

@@ -92,8 +92,6 @@
 |  [SearchInterceptorDeps](./kibana-plugin-plugins-data-public.searchinterceptordeps.md) |  |
 |  [SearchSessionInfoProvider](./kibana-plugin-plugins-data-public.searchsessioninfoprovider.md) | Provide info about current search session to be stored in the Search Session saved object |
 |  [SearchSourceFields](./kibana-plugin-plugins-data-public.searchsourcefields.md) | search source fields |
-|  [TabbedAggColumn](./kibana-plugin-plugins-data-public.tabbedaggcolumn.md) | \* |
-|  [TabbedTable](./kibana-plugin-plugins-data-public.tabbedtable.md) | \* |
 
 ## Variables
 
@@ -187,7 +185,6 @@
 |  [SavedQueryTimeFilter](./kibana-plugin-plugins-data-public.savedquerytimefilter.md) |  |
 |  [SearchBarProps](./kibana-plugin-plugins-data-public.searchbarprops.md) |  |
 |  [StatefulSearchBarProps](./kibana-plugin-plugins-data-public.statefulsearchbarprops.md) |  |
-|  [TabbedAggRow](./kibana-plugin-plugins-data-public.tabbedaggrow.md) | \* |
 |  [TimefilterContract](./kibana-plugin-plugins-data-public.timefiltercontract.md) |  |
 |  [TimeHistoryContract](./kibana-plugin-plugins-data-public.timehistorycontract.md) |  |
 |  [TimeRange](./kibana-plugin-plugins-data-public.timerange.md) |  |

docs/development/plugins/data/server/kibana-plugin-plugins-data-server.md

@@ -66,8 +66,6 @@
 |  [RefreshInterval](./kibana-plugin-plugins-data-server.refreshinterval.md) |  |
 |  [SearchStrategyDependencies](./kibana-plugin-plugins-data-server.searchstrategydependencies.md) |  |
 |  [SearchUsage](./kibana-plugin-plugins-data-server.searchusage.md) |  |
-|  [TabbedAggColumn](./kibana-plugin-plugins-data-server.tabbedaggcolumn.md) | \* |
-|  [TabbedTable](./kibana-plugin-plugins-data-server.tabbedtable.md) | \* |
 
 ## Variables
 
@@ -112,6 +110,5 @@
 |  [KibanaContext](./kibana-plugin-plugins-data-server.kibanacontext.md) |  |
 |  [ParsedInterval](./kibana-plugin-plugins-data-server.parsedinterval.md) |  |
 |  [Query](./kibana-plugin-plugins-data-server.query.md) |  |
-|  [TabbedAggRow](./kibana-plugin-plugins-data-server.tabbedaggrow.md) | \* |
 |  [TimeRange](./kibana-plugin-plugins-data-server.timerange.md) |  |
 

src/plugins/data/common/search/expressions/esaggs/create_filter.test.ts

@@ -10,12 +10,12 @@ import { isRangeFilter } from '../../../es_query/filters';
 import { BytesFormat, FieldFormatsGetConfigFn } from '../../../field_formats';
 import { AggConfigs, IAggConfig } from '../../aggs';
 import { mockAggTypesRegistry } from '../../aggs/test_helpers';
-import { TabbedTable } from '../../tabify';
 
 import { createFilter } from './create_filter';
+import { Datatable } from '../../../../../expressions/common';
 
 describe('createFilter', () => {
-  let table: TabbedTable;
+  let table: Datatable;
   let aggConfig: IAggConfig;
 
   const typesRegistry = mockAggTypesRegistry();
@@ -62,11 +62,12 @@ describe('createFilter', () => {
 
   beforeEach(() => {
     table = {
+      type: 'datatable',
       columns: [
         {
           id: '1-1',
           name: 'test',
-          aggConfig,
+          meta: { type: 'number' },
         },
       ],
       rows: [

src/plugins/data/common/search/expressions/esaggs/create_filter.ts

@@ -8,9 +8,9 @@
 
 import { Filter } from '../../../es_query';
 import { IAggConfig } from '../../aggs';
-import { TabbedTable } from '../../tabify';
+import { Datatable } from '../../../../../expressions/common';
 
-const getOtherBucketFilterTerms = (table: TabbedTable, columnIndex: number, rowIndex: number) => {
+const getOtherBucketFilterTerms = (table: Datatable, columnIndex: number, rowIndex: number) => {
   if (rowIndex === -1) {
     return [];
   }
@@ -36,7 +36,7 @@ const getOtherBucketFilterTerms = (table: TabbedTable, columnIndex: number, rowI
 
 export const createFilter = (
   aggConfigs: IAggConfig[],
-  table: TabbedTable,
+  table: Datatable,
   columnIndex: number,
   rowIndex: number,
   cellValue: any