-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updates existing embeddable with updates on edit Select incoming embeddable element on load Fixed ts errors Added use incoming embeddable hook Fixed eslint errors Added comment Fixed typo Fixed story Fix ts errors Fixed failing tests Fixed ts errors Add addUpdater to pluginServiceRegistry.start Fixed plugin appUpdater
- Loading branch information
Showing
28 changed files
with
367 additions
and
69 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
128 changes: 128 additions & 0 deletions
128
...canvas/canvas_plugin_src/renderers/embeddable/input_type_to_expression/embeddable.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { toExpression } from './embeddable'; | ||
| import { EmbeddableInput } from '../../../../types'; | ||
| import { decode } from '../../../../common/lib/embeddable_dataurl'; | ||
| import { fromExpression } from '@kbn/interpreter/common'; | ||
|
|
||
| describe('toExpression', () => { | ||
| describe('by-reference embeddable input', () => { | ||
| const baseEmbeddableInput = { | ||
| id: 'elementId', | ||
| savedObjectId: 'embeddableId', | ||
| filters: [], | ||
| }; | ||
|
|
||
| it('converts to an embeddable expression', () => { | ||
| const input: EmbeddableInput = baseEmbeddableInput; | ||
|
|
||
| const expression = toExpression(input, 'visualization'); | ||
| const ast = fromExpression(expression); | ||
|
|
||
| expect(ast.type).toBe('expression'); | ||
| expect(ast.chain[0].function).toBe('embeddable'); | ||
| expect(ast.chain[0].arguments.type[0]).toBe('visualization'); | ||
|
|
||
| const config = decode(ast.chain[0].arguments.config[0] as string); | ||
|
|
||
| expect(config.savedObjectId).toStrictEqual(input.savedObjectId); | ||
| }); | ||
|
|
||
| it('includes optional input values', () => { | ||
| const input: EmbeddableInput = { | ||
| ...baseEmbeddableInput, | ||
| title: 'title', | ||
| timeRange: { | ||
| from: 'now-1h', | ||
| to: 'now', | ||
| }, | ||
| }; | ||
|
|
||
| const expression = toExpression(input, 'visualization'); | ||
| const ast = fromExpression(expression); | ||
|
|
||
| const config = decode(ast.chain[0].arguments.config[0] as string); | ||
|
|
||
| expect(config).toHaveProperty('title', input.title); | ||
| expect(config).toHaveProperty('timeRange'); | ||
| expect(config.timeRange).toHaveProperty('from', input.timeRange?.from); | ||
| expect(config.timeRange).toHaveProperty('to', input.timeRange?.to); | ||
| }); | ||
|
|
||
| it('includes empty panel title', () => { | ||
| const input: EmbeddableInput = { | ||
| ...baseEmbeddableInput, | ||
| title: '', | ||
| }; | ||
|
|
||
| const expression = toExpression(input, 'visualization'); | ||
| const ast = fromExpression(expression); | ||
|
|
||
| const config = decode(ast.chain[0].arguments.config[0] as string); | ||
|
|
||
| expect(config).toHaveProperty('title', input.title); | ||
| }); | ||
| }); | ||
|
|
||
| describe('by-value embeddable input', () => { | ||
| const baseEmbeddableInput = { | ||
| id: 'elementId', | ||
| disableTriggers: true, | ||
| filters: [], | ||
| }; | ||
| it('converts to an embeddable expression', () => { | ||
| const input: EmbeddableInput = baseEmbeddableInput; | ||
|
|
||
| const expression = toExpression(input, 'visualization'); | ||
| const ast = fromExpression(expression); | ||
|
|
||
| expect(ast.type).toBe('expression'); | ||
| expect(ast.chain[0].function).toBe('embeddable'); | ||
| expect(ast.chain[0].arguments.type[0]).toBe('visualization'); | ||
|
|
||
| const config = decode(ast.chain[0].arguments.config[0] as string); | ||
| expect(config.filters).toStrictEqual(input.filters); | ||
| expect(config.disableTriggers).toStrictEqual(input.disableTriggers); | ||
| }); | ||
|
|
||
| it('includes optional input values', () => { | ||
| const input: EmbeddableInput = { | ||
| ...baseEmbeddableInput, | ||
| title: 'title', | ||
| timeRange: { | ||
| from: 'now-1h', | ||
| to: 'now', | ||
| }, | ||
| }; | ||
|
|
||
| const expression = toExpression(input, 'visualization'); | ||
| const ast = fromExpression(expression); | ||
|
|
||
| const config = decode(ast.chain[0].arguments.config[0] as string); | ||
|
|
||
| expect(config).toHaveProperty('title', input.title); | ||
| expect(config).toHaveProperty('timeRange'); | ||
| expect(config.timeRange).toHaveProperty('from', input.timeRange?.from); | ||
| expect(config.timeRange).toHaveProperty('to', input.timeRange?.to); | ||
| }); | ||
|
|
||
| it('includes empty panel title', () => { | ||
| const input: EmbeddableInput = { | ||
| ...baseEmbeddableInput, | ||
| title: '', | ||
| }; | ||
|
|
||
| const expression = toExpression(input, 'visualization'); | ||
| const ast = fromExpression(expression); | ||
|
|
||
| const config = decode(ast.chain[0].arguments.config[0] as string); | ||
|
|
||
| expect(config).toHaveProperty('title', input.title); | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.