[React@18] fix incorrect useEffect return value (#195421)

elastic · Oct 8, 2024 · d03537f · d03537f
1 parent e1cf8d5
commit d03537f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.../public/applications/elasticsearch/components/elasticsearch_guide/elasticsearch_guide.tsx b/.../public/applications/elasticsearch/components/elasticsearch_guide/elasticsearch_guide.tsx
@@ -35,7 +35,9 @@ export const ElasticsearchGuide = () => {
   const { data } = useValues(FetchApiKeysAPILogic);
   const apiKeys = data?.api_keys || [];
 
-  useEffect(() => makeRequest({}), []);
+  useEffect(() => {
+    makeRequest({});
+  }, []);
 
   return (
     <EnterpriseSearchElasticsearchPageTemplate>

diff --git a/x-pack/plugins/enterprise_search/public/applications/shared/api_key/api_key_panel.tsx b/x-pack/plugins/enterprise_search/public/applications/shared/api_key/api_key_panel.tsx
@@ -42,7 +42,9 @@ export const ApiKeyPanel: React.FC = () => {
   const [isFlyoutOpen, setIsFlyoutOpen] = useState(false);
   const elasticsearchEndpoint = esConfig.elasticsearch_host;
 
-  useEffect(() => makeRequest({}), []);
+  useEffect(() => {
+    makeRequest({});
+  }, []);
 
   const apiKeys = data?.api_keys || [];
   const cloudId = cloud?.cloudId;