Refactor

elastic · Aug 24, 2021 · d6fd6eb · d6fd6eb
1 parent d302db4
commit d6fd6eb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/...grade_assistant/__jest__/client_integration/overview/fix_logs_step/fix_logs_step.test.tsx b/...grade_assistant/__jest__/client_integration/overview/fix_logs_step/fix_logs_step.test.tsx
@@ -154,7 +154,7 @@ describe('Overview - Fix deprecation logs step', () => {
       httpRequestsMockHelpers.setLoadDeprecationLoggingResponse(getLoggingResponse(true));
     });
 
-    test('X deprecation warnings', async () => {
+    test('Has deprecation warnings', async () => {
       httpRequestsMockHelpers.setLoadDeprecationLogsCountResponse({
         count: 10,
       });
@@ -163,12 +163,12 @@ describe('Overview - Fix deprecation logs step', () => {
         testBed = await setupOverviewPage();
       });
 
-      const { exists, component } = testBed;
+      const { find, exists, component } = testBed;
 
       component.update();
 
       expect(exists('hasWarningsCallout')).toBe(true);
-      expect(exists('noWarningsCallout')).toBe(false);
+      expect(find('hasWarningsCallout').text()).toContain('10');
     });
 
     test('No deprecation warnings', async () => {
@@ -180,15 +180,15 @@ describe('Overview - Fix deprecation logs step', () => {
         testBed = await setupOverviewPage();
       });
 
-      const { exists, component } = testBed;
+      const { find, exists, component } = testBed;
 
       component.update();
 
       expect(exists('noWarningsCallout')).toBe(true);
-      expect(exists('hasWarningsCallout')).toBe(false);
+      expect(find('noWarningsCallout').text()).toContain('No deprecation warnings');
     });
 
-    test('Handles errors and has a way to retry', async () => {
+    test('Handles errors and can retry', async () => {
       const error = {
         statusCode: 500,
         error: 'Internal server error',

diff --git a/...nt/public/application/components/overview/fix_logs_step/verify_changes/verify_changes.tsx b/...nt/public/application/components/overview/fix_logs_step/verify_changes/verify_changes.tsx
@@ -53,7 +53,7 @@ const i18nTexts = {
   ),
 };
 
-const getPreviousCheck = () => {
+const getPreviousCheckpointDate = () => {
   const storedValue = moment(localStorage.get(LOCALSTORAGE_KEY));
 
   if (storedValue.isValid()) {
@@ -68,7 +68,7 @@ const getPreviousCheck = () => {
 
 export const VerifyChanges: FunctionComponent = () => {
   const { api } = useAppContext();
-  const [previousCheck, setPreviousCheck] = useState(getPreviousCheck());
+  const [previousCheck, setPreviousCheck] = useState(getPreviousCheckpointDate());
   const { data, error, isLoading, resendRequest } = api.getDeprecationLogsCount(previousCheck);
 
   const warningsCount = data?.count || 0;
@@ -87,7 +87,7 @@ export const VerifyChanges: FunctionComponent = () => {
     localStorage.set(LOCALSTORAGE_KEY, now);
   };
 
-  if (isLoading) {
+  if (!data && isLoading) {
     return (
       <EuiFlexGroup>
         <EuiFlexItem>