hides the embed section on the discover tab

Fixes #5497
elastic · Dec 18, 2015 · d77aafd · d77aafd
1 parent 8534e67
commit d77aafd
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 10 deletions.
diff --git a/src/plugins/kibana/public/discover/partials/share_search.html b/src/plugins/kibana/public/discover/partials/share_search.html
@@ -1,4 +1,5 @@
 <share
   object-type="search"
-  object-id="{{opts.savedSearch.id}}">
+  object-id="{{opts.savedSearch.id}}"
+  allow-embed="false">
 </share>
diff --git a/src/ui/public/share/index.html b/src/ui/public/share/index.html
@@ -1,16 +1,16 @@
 <form role="form" class="vis-share">
-  <p ng-show="objectId">
+  <div ng-show="objectId">
     <input type="checkbox" ng-model="ignoreState" id="ignoreState" />
     <label for="ignoreState">
       Link to saved {{objectType}}
       <small>By selecting this option, future changes to this saved {{objectType}} will be reflected in the shared view. Note: Shared URLs always include globally persisted state such as time picker and auto refresh.</small>
     </label>
-  </p>
-  <p>
+  </div>
+  <div>
     <input type="checkbox" ng-model="shortenUrls" id="shortenUrls" />
     <label for="shortenUrls">Shorten URLs</label>
-  </p>
-  <p>
+  </div>
+  <div ng-if="allowEmbed">
     <div class="input-group">
       <label>
         Embed this {{objectType}}
@@ -26,8 +26,8 @@
         Generating Short URL...
       </div>
     </div>
-  </p>
-  <p>
+  </div>
+  <div>
     <div class="input-group">
       <label>
         Share a link
@@ -42,5 +42,5 @@
         Generating Short URL...
       </div>
     </div>
-  </p>
+  </div>
 </form>
diff --git a/src/ui/public/share/index.js b/src/ui/public/share/index.js
@@ -1,6 +1,7 @@
 const app = require('ui/modules').get('kibana');
 const _ = require('lodash');
 const { parse } = require('querystring');
+const angular = require('angular');
 
 app.directive('share', function (Private) {
   const urlShortener = Private(require('./url_shortener'));
@@ -9,10 +10,12 @@ app.directive('share', function (Private) {
     restrict: 'E',
     scope: {
       objectType: '@',
-      objectId: '@'
+      objectId: '@',
+      setAllowEmbed: '&?allowEmbed'
     },
     template: require('ui/share/index.html'),
     controller: function ($scope, $rootScope, $location) {
+      $scope.allowEmbed = $scope.setAllowEmbed ? $scope.setAllowEmbed() : true;
       $scope.shortUrlsLoading = false;
 
       function updateUrl(url) {