Remove legacy "interpreter" plugin (#61263)

* chore: 🤖 delete legacy interpreter registries * chore: 🤖 completely delete legacy "interpreter" plugin * chore: 🤖 remove dependencies on legacy "interpreter" plugin * chore: 🤖 revert back Canvas global registries * test: 💍 fix Lens test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
elastic · May 5, 2020 · d77d2e4 · d77d2e4
1 parent cf64454
commit d77d2e4
Show file tree

Hide file tree

Showing 11 changed files with 3 additions and 262 deletions.
diff --git a/src/legacy/core_plugins/interpreter/README.md b/src/legacy/core_plugins/interpreter/README.md
diff --git a/src/legacy/core_plugins/interpreter/index.ts b/src/legacy/core_plugins/interpreter/index.ts
diff --git a/src/legacy/core_plugins/interpreter/init.ts b/src/legacy/core_plugins/interpreter/init.ts
diff --git a/src/legacy/core_plugins/interpreter/package.json b/src/legacy/core_plugins/interpreter/package.json
diff --git a/src/legacy/core_plugins/interpreter/public/canvas/load_legacy_server_function_wrappers.ts b/src/legacy/core_plugins/interpreter/public/canvas/load_legacy_server_function_wrappers.ts
diff --git a/src/legacy/core_plugins/interpreter/public/interpreter.ts b/src/legacy/core_plugins/interpreter/public/interpreter.ts
diff --git a/src/legacy/core_plugins/interpreter/public/registries.karma_mock.ts b/src/legacy/core_plugins/interpreter/public/registries.karma_mock.ts
diff --git a/src/legacy/core_plugins/interpreter/public/registries.ts b/src/legacy/core_plugins/interpreter/public/registries.ts
diff --git a/x-pack/legacy/plugins/canvas/.storybook/storyshots.test.js b/x-pack/legacy/plugins/canvas/.storybook/storyshots.test.js
@@ -77,8 +77,6 @@ jest.mock('@elastic/eui/lib/services/accessibility/html_id_generator', () => {
   };
 });
 
-jest.mock('plugins/interpreter/registries', () => ({}));
-
 // Disabling this test due to https://github.com/elastic/eui/issues/2242
 jest.mock(
   '../public/components/workpad_header/share_menu/flyout/__examples__/share_website_flyout.stories',

diff --git a/x-pack/legacy/plugins/canvas/README.md b/x-pack/legacy/plugins/canvas/README.md
@@ -48,7 +48,7 @@ Open your plugin's `index.js` file, and modify it to look something like this (b
 export default function (kibana) {
   return new kibana.Plugin({
     // Tell Kibana that this plugin needs canvas and the Kibana interpreter
-    require: ['interpreter', 'canvas'],
+    require: ['canvas'],
 
     // The name of your plugin. Make this whatever you want.
     name: 'canvas_example',
@@ -132,7 +132,7 @@ In your plugin's root `index.js` file, modify the `kibana.Plugin` definition to
 export default function (kibana) {
   return new kibana.Plugin({
     // Tell Kibana that this plugin needs canvas and the Kibana interpreter
-    require: ['interpreter', 'canvas'],
+    require: ['canvas'],
 
     // The name of your plugin. Make this whatever you want.
     name: 'canvas_example',

diff --git a/x-pack/legacy/plugins/canvas/index.js b/x-pack/legacy/plugins/canvas/index.js
@@ -12,7 +12,7 @@ export function canvas(kibana) {
   return new kibana.Plugin({
     id: CANVAS_APP,
     configPrefix: 'xpack.canvas',
-    require: ['kibana', 'elasticsearch', 'xpack_main', 'interpreter'],
+    require: ['kibana', 'elasticsearch', 'xpack_main'],
     publicDir: resolve(__dirname, 'public'),
     uiExports: {
       app: {