do not add method to IVectorLayer interface

elastic · Jun 16, 2021 · d8de9e4 · d8de9e4
1 parent 3a98b03
commit d8de9e4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/x-pack/plugins/maps/public/classes/layers/blended_vector_layer/blended_vector_layer.ts b/x-pack/plugins/maps/public/classes/layers/blended_vector_layer/blended_vector_layer.ts
@@ -300,7 +300,7 @@ export class BlendedVectorLayer extends VectorLayer implements IVectorLayer {
       prevDataRequest: this.getDataRequest(dataRequestId),
       nextMeta: searchFilters,
       extentAware: source.isFilterByMapBounds(),
-      getUpdateDueToTimeslice: this.getUpdateDueToTimeslice,
+      getUpdateDueToTimeslice: this._getUpdateDueToTimesliceFromSourceRequestMeta,
     });
 
     let activeSource;

diff --git a/x-pack/plugins/maps/public/classes/layers/tiled_vector_layer/tiled_vector_layer.tsx b/x-pack/plugins/maps/public/classes/layers/tiled_vector_layer/tiled_vector_layer.tsx
@@ -86,7 +86,7 @@ export class TiledVectorLayer extends VectorLayer {
           source: this.getSource(),
           prevDataRequest,
           nextMeta: searchFilters,
-          getUpdateDueToTimeslice: this.getUpdateDueToTimeslice,
+          getUpdateDueToTimeslice: this._getUpdateDueToTimesliceFromTileMeta,
         });
         const canSkip = noChangesInSourceState && noChangesInSearchState;
         if (canSkip) {
@@ -251,7 +251,7 @@ export class TiledVectorLayer extends VectorLayer {
     return null;
   }
 
-  getUpdateDueToTimeslice(source: ISource, timeslice?: Timeslice): boolean {
+  _getUpdateDueToTimesliceFromTileMeta(source: ISource, timeslice?: Timeslice): boolean {
     // TODO use meta features to determine if tiles already contain features for timeslice.
     return true;
   }

diff --git a/x-pack/plugins/maps/public/classes/layers/vector_layer/vector_layer.tsx b/x-pack/plugins/maps/public/classes/layers/vector_layer/vector_layer.tsx
@@ -97,7 +97,6 @@ export interface IVectorLayer extends ILayer {
   hasJoins(): boolean;
   canShowTooltip(): boolean;
   getLeftJoinFields(): Promise<IField[]>;
-  getUpdateDueToTimeslice(source: ISource, timeslice?: Timeslice): boolean;
 }
 
 export class VectorLayer extends AbstractLayer implements IVectorLayer {
@@ -343,7 +342,9 @@ export class VectorLayer extends AbstractLayer implements IVectorLayer {
       prevDataRequest,
       nextMeta: searchFilters,
       extentAware: false, // join-sources are term-aggs that are spatially unaware (e.g. ESTermSource/TableSource).
-      getUpdateDueToTimeslice: this.getUpdateDueToTimeslice,
+      getUpdateDueToTimeslice: () => {
+        return true;
+      },
     });
     if (canSkipFetch) {
       return {
@@ -679,7 +680,7 @@ export class VectorLayer extends AbstractLayer implements IVectorLayer {
         requestMeta: await this._getSearchFilters(syncContext.dataFilters, source, style),
         syncContext,
         source,
-        getUpdateDueToTimeslice: this.getUpdateDueToTimeslice,
+        getUpdateDueToTimeslice: this._getUpdateDueToTimesliceFromSourceRequestMeta,
       });
       if (
         !sourceResult.featureCollection ||
@@ -1104,7 +1105,7 @@ export class VectorLayer extends AbstractLayer implements IVectorLayer {
     return await this._source.getLicensedFeatures();
   }
 
-  getUpdateDueToTimeslice(source: ISource, timeslice?: Timeslice): boolean {
+  _getUpdateDueToTimesliceFromSourceRequestMeta(source: ISource, timeslice?: Timeslice): boolean {
     const prevDataRequest = this.getSourceDataRequest();
     const prevMeta = prevDataRequest?.getMeta();
     if (!prevMeta) {