Updates from PR review

x-pack/plugins/security_solution/public/common/components/callouts/callout.test.tsx

@@ -7,8 +7,9 @@
 
 import { mount } from 'enzyme';
 import React from 'react';
-import { CallOut, CallOutMessage } from '.';
 import { TestProviders } from '../../mock';
+import { CallOut } from './callout';
+import { CallOutMessage } from './callout_types';
 
 describe('callout', () => {
   let message: CallOutMessage = {

x-pack/plugins/security_solution/public/detections/components/callouts/need_admin_for_update_callout/index.test.tsx

@@ -7,8 +7,8 @@
 
 import { mount } from 'enzyme';
 import React from 'react';
+import { NeedAdminForUpdateRulesCallOut } from './index';
 import { TestProviders } from '../../../../common/mock';
-import { NeedAdminForUpdateRulesCallOut } from '.';
 import * as userInfo from '../../user_info';
 
 describe('need_admin_for_update_callout', () => {
@@ -18,7 +18,7 @@ describe('need_admin_for_update_callout', () => {
 
   describe('hasIndexManage is "null"', () => {
     const hasIndexManage = null;
-    test('renders when "signalIndexMappingOutdated" is true', () => {
+    test('Does NOT render when "signalIndexMappingOutdated" is true', () => {
       jest
         .spyOn(userInfo, 'useUserData')
         .mockImplementation(
@@ -30,7 +30,7 @@ describe('need_admin_for_update_callout', () => {
         </TestProviders>
       );
       expect(wrapper.exists('[data-test-subj="callout-need-admin-for-update-rules"]')).toEqual(
-        true
+        false
       );
     });
 

x-pack/plugins/security_solution/public/detections/components/callouts/need_admin_for_update_callout/index.tsx

@@ -24,6 +24,11 @@ const needAdminForUpdateRulesMessage: CallOutMessage = {
  * - Have the permissions to be able to read "signalIndexMappingOutdated" and that condition is "true"
  * - Have the permissions to be able to read "hasIndexManage" and that condition is "false"
  *
+ * Some users do not have sufficient privileges to be able to determine if "signalIndexMappingOutdated"
+ * is outdated or not. Same could apply to "hasIndexManage". When users do not have enough permissions
+ * to determine if "signalIndexMappingOutdated" is true or false, the permissions system returns a "null"
+ * instead.
+ *
  * If the user has the permissions to see that signalIndexMappingOutdated is true and that
  * hasIndexManage is also true, then the user should be performing the update on the page which is
  * why we do not show it for that condition.
@@ -34,11 +39,11 @@ const NeedAdminForUpdateCallOutComponent = (): JSX.Element => {
   const signalIndexMappingIsOutdated =
     signalIndexMappingOutdated != null && signalIndexMappingOutdated;
 
-  const userHasIndexManage = hasIndexManage != null && hasIndexManage;
+  const userDoesntHaveIndexManage = hasIndexManage != null && !hasIndexManage;
 
   return (
     <CallOutPersistentSwitcher
-      condition={signalIndexMappingIsOutdated && !userHasIndexManage}
+      condition={signalIndexMappingIsOutdated && userDoesntHaveIndexManage}
       message={needAdminForUpdateRulesMessage}
     />
   );