Persist number formatting on drop too

elastic · Feb 21, 2020 · e002e9d · e002e9d
1 parent fe4c842
commit e002e9d
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 10 deletions.
diff --git a/...ck/legacy/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_panel.tsx b/...ck/legacy/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_panel.tsx
@@ -130,6 +130,7 @@ export const IndexPatternDimensionPanelComponent = function IndexPatternDimensio
                 layerId,
                 suggestedPriority: props.suggestedPriority,
                 field: droppedItem.field,
+                previousColumn: selectedColumn,
               });
 
           trackUiEvent('drop_onto_dimension');

diff --git a/...legacy/plugins/lens/public/indexpattern_datasource/operations/definitions/cardinality.tsx b/...legacy/plugins/lens/public/indexpattern_datasource/operations/definitions/cardinality.tsx
@@ -49,7 +49,7 @@ export const cardinalityOperation: OperationDefinition<CardinalityIndexPatternCo
         (!newField.aggregationRestrictions || newField.aggregationRestrictions.cardinality)
     );
   },
-  buildColumn({ suggestedPriority, field }) {
+  buildColumn({ suggestedPriority, field, previousColumn }) {
     return {
       label: ofName(field.name),
       dataType: 'number',
@@ -58,6 +58,8 @@ export const cardinalityOperation: OperationDefinition<CardinalityIndexPatternCo
       suggestedPriority,
       sourceField: field.name,
       isBucketed: IS_BUCKETED,
+      params:
+        previousColumn && previousColumn.dataType === 'number' ? previousColumn.params : undefined,
     };
   },
   toEsAggsConfig: (column, columnId) => ({

diff --git a/x-pack/legacy/plugins/lens/public/indexpattern_datasource/operations/definitions/count.tsx b/x-pack/legacy/plugins/lens/public/indexpattern_datasource/operations/definitions/count.tsx
@@ -39,7 +39,7 @@ export const countOperation: OperationDefinition<CountIndexPatternColumn> = {
       };
     }
   },
-  buildColumn({ suggestedPriority, field }) {
+  buildColumn({ suggestedPriority, field, previousColumn }) {
     return {
       label: countLabel,
       dataType: 'number',
@@ -48,6 +48,8 @@ export const countOperation: OperationDefinition<CountIndexPatternColumn> = {
       isBucketed: false,
       scale: 'ratio',
       sourceField: field.name,
+      params:
+        previousColumn && previousColumn.dataType === 'number' ? previousColumn.params : undefined,
     };
   },
   toEsAggsConfig: (column, columnId) => ({

diff --git a/x-pack/legacy/plugins/lens/public/indexpattern_datasource/operations/definitions/index.ts b/x-pack/legacy/plugins/lens/public/indexpattern_datasource/operations/definitions/index.ts
@@ -117,6 +117,7 @@ interface FieldBasedOperationDefinition<C extends BaseIndexPatternColumn>
   buildColumn: (
     arg: BaseBuildColumnArgs & {
       field: IndexPatternField;
+      previousColumn?: C;
     }
   ) => C;
   /**

diff --git a/x-pack/legacy/plugins/lens/public/indexpattern_datasource/operations/definitions/metrics.tsx b/x-pack/legacy/plugins/lens/public/indexpattern_datasource/operations/definitions/metrics.tsx
@@ -50,14 +50,16 @@ function buildMetricOperation<T extends MetricColumn<string>>({
           (!newField.aggregationRestrictions || newField.aggregationRestrictions![type])
       );
     },
-    buildColumn: ({ suggestedPriority, field }) => ({
+    buildColumn: ({ suggestedPriority, field, previousColumn }) => ({
       label: ofName(field.name),
       dataType: 'number',
       operationType: type,
       suggestedPriority,
       sourceField: field.name,
       isBucketed: false,
       scale: 'ratio',
+      params:
+        previousColumn && previousColumn.dataType === 'number' ? previousColumn.params : undefined,
     }),
     onFieldChange: (oldColumn, indexPattern, field) => {
       return {

diff --git a/x-pack/legacy/plugins/lens/public/indexpattern_datasource/operations/operations.ts b/x-pack/legacy/plugins/lens/public/indexpattern_datasource/operations/operations.ts
@@ -243,13 +243,6 @@ export function buildColumn({
     field,
   });
 
-  if (
-    newColumn.dataType === 'number' &&
-    previousColumn?.params &&
-    'format' in previousColumn.params
-  ) {
-    newColumn.params = { format: previousColumn.params.format };
-  }
   return newColumn;
 }