Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

…ns/vega

.github/CODEOWNERS

@@ -35,6 +35,7 @@
 /x-pack/test/functional/apps/machine_learning/  @elastic/ml-ui
 /x-pack/test/functional/services/machine_learning/  @elastic/ml-ui
 /x-pack/test/functional/services/ml.ts  @elastic/ml-ui
+/x-pack/legacy/plugins/transform/  @elastic/ml-ui
 
 # Operations
 /renovate.json5 @elastic/kibana-operations

.sass-lint.yml

@@ -8,6 +8,7 @@ files:
     - 'x-pack/legacy/plugins/security/**/*.s+(a|c)ss'
     - 'x-pack/legacy/plugins/canvas/**/*.s+(a|c)ss'
     - 'x-pack/legacy/plugins/lens/**/*.s+(a|c)ss'
+    - 'x-pack/legacy/plugins/maps/**/*.s+(a|c)ss'
 rules:
   quotes:
     - 2

Jenkinsfile

@@ -17,6 +17,8 @@ stage("Kibana Pipeline") { // This stage is just here to help the BlueOcean UI a
               'oss-ciGroup4': getOssCiGroupWorker(4),
               'oss-ciGroup5': getOssCiGroupWorker(5),
               'oss-ciGroup6': getOssCiGroupWorker(6),
+            ]),
+            'kibana-oss-agent2': withWorkers('kibana-oss-tests2', { buildOss() }, [
               'oss-ciGroup7': getOssCiGroupWorker(7),
               'oss-ciGroup8': getOssCiGroupWorker(8),
               'oss-ciGroup9': getOssCiGroupWorker(9),
@@ -32,6 +34,8 @@ stage("Kibana Pipeline") { // This stage is just here to help the BlueOcean UI a
               'xpack-ciGroup3': getXpackCiGroupWorker(3),
               'xpack-ciGroup4': getXpackCiGroupWorker(4),
               'xpack-ciGroup5': getXpackCiGroupWorker(5),
+            ]),
+            'kibana-xpack-agent2': withWorkers('kibana-xpack-tests2', { buildXpack() }, [
               'xpack-ciGroup6': getXpackCiGroupWorker(6),
               'xpack-ciGroup7': getXpackCiGroupWorker(7),
               'xpack-ciGroup8': getXpackCiGroupWorker(8),
@@ -290,6 +294,6 @@ def buildXpack() {
 def runErrorReporter() {
   bash """
     source src/dev/ci_setup/setup_env.sh
-    node src/dev/failed_tests/cli
+    node scripts/report_failed_tests
   """
 }

docs/apm/troubleshooting.asciidoc

@@ -0,0 +1,44 @@
+[[troubleshooting]] 
+=== Troubleshooting common problems
+
+If you have something to add to this section, please consider creating a pull request with
+your proposed changes at https://github.com/elastic/kibana.
+
+Also check out the https://discuss.elastic.co/c/apm[APM discussion forum].
+
+==== No APM data found
+
+This section can help with any of the following:
+
+* Data isn't displaying in the APM app
+* You're seeing a message like "No Services Found",
+* You're seeing errors like "Fielddata is disabled on text fields by default..."
+
+There are a number of factors that could be at play here.
+One important thing to double-check first is your index template.
+
+An APM index template must exist for the APM app to work correctly.
+By default, this index template is created by APM Server on startup.
+However, this only happens if `setup.template.enabled` is `true` in `apm-server.yml`.
+You can create the index template manually by running `apm-server setup`.
+Take note that index templates *cannot* be applied retroactively -- they are only applied at index creation time.
+More information is available in {apm-server-ref}/apm-server-configuration.html[Set up and configure].
+
+You can check for the existence of an APM index template using the
+{ref}/indices-get-template.html[Get index template API].
+If you're using the default index naming pattern, that request would be:
+
+[source,js]
+--------------------------------------------------
+GET /_template/apm-{version}
+--------------------------------------------------
+// CONSOLE
+
+If you're not outputting data directly from APM Server to Elasticsearch (perhaps you're using Logstash or Kafka),
+then the index template will not be set up automatically. Instead, you'll need to
+{apm-server-ref}/_manually_loading_template_configuration.html#load-template-manually-alternate[load the template manually].
+
+Finally, this problem can also occur if you've changed the index name that you write APM data to.
+The default index pattern can be found {apm-server-ref}/elasticsearch-output.html#index-option-es[here].
+If you change this setting, you must also configure the `setup.template.name` and `setup.template.pattern` options.
+See {apm-server-ref}/configuration-template.html[Load the Elasticsearch index template].

docs/apm/using-the-apm-ui.asciidoc

@@ -35,3 +35,5 @@ include::metrics.asciidoc[]
 include::agent-configuration.asciidoc[]
 
 include::advanced-queries.asciidoc[]
+
+include::troubleshooting.asciidoc[]

docs/developer/visualize/development-create-visualization.asciidoc

@@ -64,7 +64,7 @@ The list of common parameters:
 - *responseHandler*: <string> one of the available response handlers or a <function> for a custom response handler
 - *editor*: <string> one of the available editors or Editor class for custom one
 - *editorConfig*: object holding editor parameters
-- *options.showTimePicker*: <bool> show or hide time picker (defaults to true)
+- *options.showTimePicker*: <bool> show or hide time filter (defaults to true)
 - *options.showQueryBar*: <bool> show or hide query bar (defaults to true)
 - *options.showFilterBar*: <bool> show or hide filter bar (defaults to true)
 - *options.showIndexSelection*: <bool> show or hide index selection (defaults to true)
@@ -275,7 +275,7 @@ VisTypesRegistryProvider.register(MyNewVisType);
 [[development-visualization-request-handlers]]
 === Visualization Request Handlers
 Request handler gets called when one of the following keys on AppState change:
-`vis`, `query`, `filters` or `uiState` and when timepicker is updated. On top
+`vis`, `query`, `filters` or `uiState` and when the time filter is updated. On top
 of that it will also get called on force refresh.
 
 By default visualizations will use the `courier` request handler. They can also choose to use any of the other provided 
@@ -417,7 +417,7 @@ The `vis` object holds the visualization state and is the window into kibana:
 - *vis.getUiState()*: gets UI state of visualization
 - *vis.uiStateVal(name, val)*: updates a property in UI state
 - *vis.isEditorMode()*: returns true if in editor mode
-- *vis.API.timeFilter*: allows you to access time picker
+- *vis.API.timeFilter*: allows you to access time filter
 - *vis.API.queryFilter*: gives you access to queryFilter
 - *vis.API.events.click*: default click handler
 - *vis.API.events.brush*: default brush handler
@@ -430,12 +430,12 @@ visualization's render method.
 For the parameters that should not be saved with the visualization you should use the UI state. 
 These hold viewer-specific state, such as popup open/closed, custom colors applied to the series etc.
 
-You can access filter bar and time picker through the objects defined on `vis.API`
+You can access the filter bar and time filter through the objects defined on `vis.API`
 
 [[development-vis-timefilter]]
 ==== timeFilter
 
-Update the timefilter time values and call update() method on it to update time picker
+Update the timefilter time values and call update() method on it to update the time filter
 
 ["source","js"]
 -----------

docs/development/core/public/kibana-plugin-public.applicationsetup.registermountcontext.md

@@ -9,15 +9,15 @@ Register a context provider for application mounting. Will only be available to
 <b>Signature:</b>
 
 ```typescript
-registerMountContext<T extends keyof AppMountContext>(contextName: T, provider: IContextProvider<AppMountContext, T>): void;
+registerMountContext<T extends keyof AppMountContext>(contextName: T, provider: IContextProvider<App['mount'], T>): void;
 ```
 
 ## Parameters
 
 |  Parameter | Type | Description |
 |  --- | --- | --- |
 |  contextName | <code>T</code> | The key of [AppMountContext](./kibana-plugin-public.appmountcontext.md) this provider's return value should be attached to. |
-|  provider | <code>IContextProvider&lt;AppMountContext, T&gt;</code> | A [IContextProvider](./kibana-plugin-public.icontextprovider.md) function |
+|  provider | <code>IContextProvider&lt;App['mount'], T&gt;</code> | A [IContextProvider](./kibana-plugin-public.icontextprovider.md) function |
 
 <b>Returns:</b>
 

docs/development/core/public/kibana-plugin-public.applicationstart.registermountcontext.md

@@ -9,15 +9,15 @@ Register a context provider for application mounting. Will only be available to
 <b>Signature:</b>
 
 ```typescript
-registerMountContext<T extends keyof AppMountContext>(contextName: T, provider: IContextProvider<AppMountContext, T>): void;
+registerMountContext<T extends keyof AppMountContext>(contextName: T, provider: IContextProvider<App['mount'], T>): void;
 ```
 
 ## Parameters
 
 |  Parameter | Type | Description |
 |  --- | --- | --- |
 |  contextName | <code>T</code> | The key of [AppMountContext](./kibana-plugin-public.appmountcontext.md) this provider's return value should be attached to. |
-|  provider | <code>IContextProvider&lt;AppMountContext, T&gt;</code> | A [IContextProvider](./kibana-plugin-public.icontextprovider.md) function |
+|  provider | <code>IContextProvider&lt;App['mount'], T&gt;</code> | A [IContextProvider](./kibana-plugin-public.icontextprovider.md) function |
 
 <b>Returns:</b>
 

docs/development/core/public/kibana-plugin-public.appmountcontext.core.md

@@ -18,5 +18,8 @@ core: {
         notifications: NotificationsStart;
         overlays: OverlayStart;
         uiSettings: UiSettingsClientContract;
+        injectedMetadata: {
+            getInjectedVar: (name: string, defaultValue?: any) => unknown;
+        };
     };
 ```

docs/development/core/public/kibana-plugin-public.appmountcontext.md

@@ -16,5 +16,5 @@ export interface AppMountContext
 
 |  Property | Type | Description |
 |  --- | --- | --- |
-|  [core](./kibana-plugin-public.appmountcontext.core.md) | <code>{</code><br/><code>        application: Pick&lt;ApplicationStart, 'capabilities' &#124; 'navigateToApp'&gt;;</code><br/><code>        chrome: ChromeStart;</code><br/><code>        docLinks: DocLinksStart;</code><br/><code>        http: HttpStart;</code><br/><code>        i18n: I18nStart;</code><br/><code>        notifications: NotificationsStart;</code><br/><code>        overlays: OverlayStart;</code><br/><code>        uiSettings: UiSettingsClientContract;</code><br/><code>    }</code> | Core service APIs available to mounted applications. |
+|  [core](./kibana-plugin-public.appmountcontext.core.md) | <code>{</code><br/><code>        application: Pick&lt;ApplicationStart, 'capabilities' &#124; 'navigateToApp'&gt;;</code><br/><code>        chrome: ChromeStart;</code><br/><code>        docLinks: DocLinksStart;</code><br/><code>        http: HttpStart;</code><br/><code>        i18n: I18nStart;</code><br/><code>        notifications: NotificationsStart;</code><br/><code>        overlays: OverlayStart;</code><br/><code>        uiSettings: UiSettingsClientContract;</code><br/><code>        injectedMetadata: {</code><br/><code>            getInjectedVar: (name: string, defaultValue?: any) =&gt; unknown;</code><br/><code>        };</code><br/><code>    }</code> | Core service APIs available to mounted applications. |
 

docs/development/core/public/kibana-plugin-public.contextsetup.createcontextcontainer.md

@@ -9,9 +9,9 @@ Creates a new [IContextContainer](./kibana-plugin-public.icontextcontainer.md) f
 <b>Signature:</b>
 
 ```typescript
-createContextContainer<TContext extends {}, THandlerReturn, THandlerParmaters extends any[] = []>(): IContextContainer<TContext, THandlerReturn, THandlerParmaters>;
+createContextContainer<THandler extends HandlerFunction<any>>(): IContextContainer<THandler>;
 ```
 <b>Returns:</b>
 
-`IContextContainer<TContext, THandlerReturn, THandlerParmaters>`
+`IContextContainer<THandler>`
 

docs/development/core/public/kibana-plugin-public.coresetup.injectedmetadata.md

@@ -0,0 +1,19 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [CoreSetup](./kibana-plugin-public.coresetup.md) &gt; [injectedMetadata](./kibana-plugin-public.coresetup.injectedmetadata.md)
+
+## CoreSetup.injectedMetadata property
+
+> Warning: This API is now obsolete.
+> 
+> 
+
+exposed temporarily until https://github.com/elastic/kibana/issues/41990 done use \*only\* to retrieve config values. There is no way to set injected values in the new platform. Use the legacy platform API instead.
+
+<b>Signature:</b>
+
+```typescript
+injectedMetadata: {
+        getInjectedVar: (name: string, defaultValue?: any) => unknown;
+    };
+```

docs/development/core/public/kibana-plugin-public.coresetup.md

@@ -20,6 +20,7 @@ export interface CoreSetup
 |  [context](./kibana-plugin-public.coresetup.context.md) | <code>ContextSetup</code> | [ContextSetup](./kibana-plugin-public.contextsetup.md) |
 |  [fatalErrors](./kibana-plugin-public.coresetup.fatalerrors.md) | <code>FatalErrorsSetup</code> | [FatalErrorsSetup](./kibana-plugin-public.fatalerrorssetup.md) |
 |  [http](./kibana-plugin-public.coresetup.http.md) | <code>HttpSetup</code> | [HttpSetup](./kibana-plugin-public.httpsetup.md) |
+|  [injectedMetadata](./kibana-plugin-public.coresetup.injectedmetadata.md) | <code>{</code><br/><code>        getInjectedVar: (name: string, defaultValue?: any) =&gt; unknown;</code><br/><code>    }</code> | exposed temporarily until https://github.com/elastic/kibana/issues/41990 done use \*only\* to retrieve config values. There is no way to set injected values in the new platform. Use the legacy platform API instead. |
 |  [notifications](./kibana-plugin-public.coresetup.notifications.md) | <code>NotificationsSetup</code> | [NotificationsSetup](./kibana-plugin-public.notificationssetup.md) |
 |  [uiSettings](./kibana-plugin-public.coresetup.uisettings.md) | <code>UiSettingsClientContract</code> | [UiSettingsClient](./kibana-plugin-public.uisettingsclient.md) |
 

docs/development/core/public/kibana-plugin-public.corestart.injectedmetadata.md

@@ -0,0 +1,19 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [CoreStart](./kibana-plugin-public.corestart.md) &gt; [injectedMetadata](./kibana-plugin-public.corestart.injectedmetadata.md)
+
+## CoreStart.injectedMetadata property
+
+> Warning: This API is now obsolete.
+> 
+> 
+
+exposed temporarily until https://github.com/elastic/kibana/issues/41990 done use \*only\* to retrieve config values. There is no way to set injected values in the new platform. Use the legacy platform API instead.
+
+<b>Signature:</b>
+
+```typescript
+injectedMetadata: {
+        getInjectedVar: (name: string, defaultValue?: any) => unknown;
+    };
+```

docs/development/core/public/kibana-plugin-public.corestart.md

@@ -21,6 +21,7 @@ export interface CoreStart
 |  [docLinks](./kibana-plugin-public.corestart.doclinks.md) | <code>DocLinksStart</code> | [DocLinksStart](./kibana-plugin-public.doclinksstart.md) |
 |  [http](./kibana-plugin-public.corestart.http.md) | <code>HttpStart</code> | [HttpStart](./kibana-plugin-public.httpstart.md) |
 |  [i18n](./kibana-plugin-public.corestart.i18n.md) | <code>I18nStart</code> | [I18nStart](./kibana-plugin-public.i18nstart.md) |
+|  [injectedMetadata](./kibana-plugin-public.corestart.injectedmetadata.md) | <code>{</code><br/><code>        getInjectedVar: (name: string, defaultValue?: any) =&gt; unknown;</code><br/><code>    }</code> | exposed temporarily until https://github.com/elastic/kibana/issues/41990 done use \*only\* to retrieve config values. There is no way to set injected values in the new platform. Use the legacy platform API instead. |
 |  [notifications](./kibana-plugin-public.corestart.notifications.md) | <code>NotificationsStart</code> | [NotificationsStart](./kibana-plugin-public.notificationsstart.md) |
 |  [overlays](./kibana-plugin-public.corestart.overlays.md) | <code>OverlayStart</code> | [OverlayStart](./kibana-plugin-public.overlaystart.md) |
 |  [savedObjects](./kibana-plugin-public.corestart.savedobjects.md) | <code>SavedObjectsStart</code> | [SavedObjectsStart](./kibana-plugin-public.savedobjectsstart.md) |

docs/development/core/public/kibana-plugin-public.handlercontexttype.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [HandlerContextType](./kibana-plugin-public.handlercontexttype.md)
+
+## HandlerContextType type
+
+Extracts the type of the first argument of a [HandlerFunction](./kibana-plugin-public.handlerfunction.md) to represent the type of the context.
+
+<b>Signature:</b>
+
+```typescript
+export declare type HandlerContextType<T extends HandlerFunction<any>> = T extends HandlerFunction<infer U> ? U : never;
+```

docs/development/core/public/kibana-plugin-public.handlerfunction.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [HandlerFunction](./kibana-plugin-public.handlerfunction.md)
+
+## HandlerFunction type
+
+A function that accepts a context object and an optional number of additional arguments. Used for the generic types in [IContextContainer](./kibana-plugin-public.icontextcontainer.md)
+
+<b>Signature:</b>
+
+```typescript
+export declare type HandlerFunction<T extends object> = (context: T, ...args: any[]) => any;
+```

docs/development/core/public/kibana-plugin-public.handlerparameters.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [HandlerParameters](./kibana-plugin-public.handlerparameters.md)
+
+## HandlerParameters type
+
+Extracts the types of the additional arguments of a [HandlerFunction](./kibana-plugin-public.handlerfunction.md)<!-- -->, excluding the [HandlerContextType](./kibana-plugin-public.handlercontexttype.md)<!-- -->.
+
+<b>Signature:</b>
+
+```typescript
+export declare type HandlerParameters<T extends HandlerFunction<any>> = T extends (context: any, ...args: infer U) => any ? U : never;
+```

docs/development/core/public/kibana-plugin-public.icontextcontainer.createhandler.md

@@ -9,19 +9,19 @@ Create a new handler function pre-wired to context for the plugin.
 <b>Signature:</b>
 
 ```typescript
-createHandler(pluginOpaqueId: PluginOpaqueId, handler: IContextHandler<TContext, THandlerReturn, THandlerParameters>): (...rest: THandlerParameters) => THandlerReturn extends Promise<any> ? THandlerReturn : Promise<THandlerReturn>;
+createHandler(pluginOpaqueId: PluginOpaqueId, handler: THandler): (...rest: HandlerParameters<THandler>) => ShallowPromise<ReturnType<THandler>>;
 ```
 
 ## Parameters
 
 |  Parameter | Type | Description |
 |  --- | --- | --- |
 |  pluginOpaqueId | <code>PluginOpaqueId</code> | The plugin opaque ID for the plugin that registers this handler. |
-|  handler | <code>IContextHandler&lt;TContext, THandlerReturn, THandlerParameters&gt;</code> | Handler function to pass context object to. |
+|  handler | <code>THandler</code> | Handler function to pass context object to. |
 
 <b>Returns:</b>
 
-`(...rest: THandlerParameters) => THandlerReturn extends Promise<any> ? THandlerReturn : Promise<THandlerReturn>`
+`(...rest: HandlerParameters<THandler>) => ShallowPromise<ReturnType<THandler>>`
 
 A function that takes `THandlerParameters`<!-- -->, calls `handler` with a new context, and returns a Promise of the `handler` return value.
 

docs/development/core/public/kibana-plugin-public.icontextcontainer.md

@@ -9,7 +9,7 @@ An object that handles registration of context providers and configuring handler
 <b>Signature:</b>
 
 ```typescript
-export interface IContextContainer<TContext extends {}, THandlerReturn, THandlerParameters extends any[] = []> 
+export interface IContextContainer<THandler extends HandlerFunction<any>> 
 ```
 
 ## Methods

docs/development/core/public/kibana-plugin-public.icontextcontainer.registercontext.md

@@ -9,7 +9,7 @@ Register a new context provider.
 <b>Signature:</b>
 
 ```typescript
-registerContext<TContextName extends keyof TContext>(pluginOpaqueId: PluginOpaqueId, contextName: TContextName, provider: IContextProvider<TContext, TContextName, THandlerParameters>): this;
+registerContext<TContextName extends keyof HandlerContextType<THandler>>(pluginOpaqueId: PluginOpaqueId, contextName: TContextName, provider: IContextProvider<THandler, TContextName>): this;
 ```
 
 ## Parameters
@@ -18,7 +18,7 @@ registerContext<TContextName extends keyof TContext>(pluginOpaqueId: PluginOpaqu
 |  --- | --- | --- |
 |  pluginOpaqueId | <code>PluginOpaqueId</code> | The plugin opaque ID for the plugin that registers this context. |
 |  contextName | <code>TContextName</code> | The key of the <code>TContext</code> object this provider supplies the value for. |
-|  provider | <code>IContextProvider&lt;TContext, TContextName, THandlerParameters&gt;</code> | A [IContextProvider](./kibana-plugin-public.icontextprovider.md) to be called each time a new context is created. |
+|  provider | <code>IContextProvider&lt;THandler, TContextName&gt;</code> | A [IContextProvider](./kibana-plugin-public.icontextprovider.md) to be called each time a new context is created. |
 
 <b>Returns:</b>