Fix used saved objects types

elastic · Jan 18, 2023 · e8eb772 · e8eb772
1 parent 2e4e4b6
commit e8eb772
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/src/plugins/saved_objects_management/public/lib/bulk_delete_objects.ts b/src/plugins/saved_objects_management/public/lib/bulk_delete_objects.ts
@@ -7,12 +7,7 @@
  */
 
 import { HttpStart } from '@kbn/core/public';
-import { SavedObjectError } from '@kbn/core-saved-objects-common';
-
-interface SavedObjectDeleteRequest {
-  id: string;
-  type: string;
-}
+import { SavedObjectError, SavedObjectTypeIdTuple } from '@kbn/core-saved-objects-common';
 
 interface SavedObjectDeleteStatus {
   id: string;
@@ -23,7 +18,7 @@ interface SavedObjectDeleteStatus {
 
 export function bulkDeleteObjects(
   http: HttpStart,
-  objects: SavedObjectDeleteRequest[]
+  objects: SavedObjectTypeIdTuple[]
 ): Promise<SavedObjectDeleteStatus[]> {
   return http.post<SavedObjectDeleteStatus[]>(
     '/internal/kibana/management/saved_objects/_bulk_delete',

diff --git a/...gins/saved_objects_management/public/management_section/object_view/saved_object_view.tsx b/...gins/saved_objects_management/public/management_section/object_view/saved_object_view.tsx
@@ -144,7 +144,7 @@ export class SavedObjectEdition extends Component<
         title: i18n.translate('savedObjectsManagement.deleteConfirm.modalTitle', {
           defaultMessage: `Delete '{title}'?`,
           values: {
-            title: object?.attributes?.title || 'saved Kibana object',
+            title: object?.meta?.title || 'saved Kibana object',
           },
         }),
         buttonColor: 'danger',
@@ -155,7 +155,6 @@ export class SavedObjectEdition extends Component<
     }
 
     const [{ success, error }] = await bulkDeleteObjects(http, [{ id, type }]);
-
     if (!success) {
       notifications.toasts.addDanger({
         title: i18n.translate(
@@ -164,7 +163,7 @@ export class SavedObjectEdition extends Component<
             defaultMessage: `Failed to delete '{title}' {type} object`,
             values: {
               type,
-              title: object!.attributes.title,
+              title: object?.meta?.title,
             },
           }
         ),
@@ -174,7 +173,7 @@ export class SavedObjectEdition extends Component<
       return;
     }
 
-    notifications.toasts.addSuccess(`Deleted '${object!.attributes.title}' ${type} object`);
+    notifications.toasts.addSuccess(`Deleted '${object?.meta?.title}' ${type} object`);
     this.redirectToListing();
   }
 

diff --git a/src/plugins/saved_objects_management/tsconfig.json b/src/plugins/saved_objects_management/tsconfig.json
@@ -22,6 +22,7 @@
     "@kbn/i18n-react",
     "@kbn/test-jest-helpers",
     "@kbn/core-saved-objects-api-server",
+    "@kbn/core-saved-objects-common",
     "@kbn/monaco",
     "@kbn/config-schema",
   ],