remove todos already addressed

elastic · Feb 6, 2023 · eb6dfe5 · eb6dfe5
1 parent 2da1121
commit eb6dfe5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 34 deletions.
diff --git a/...solution/server/lib/detection_engine/rule_management/api/rules/import_rules/route.test.ts b/...solution/server/lib/detection_engine/rule_management/api/rules/import_rules/route.test.ts
@@ -34,8 +34,6 @@ import { importRulesRoute } from './route';
 
 jest.mock('../../../../../machine_learning/authz');
 
-// TODO add tests for connectors
-
 describe('Import rules route', () => {
   let config: ReturnType<typeof createMockConfig>;
   let server: ReturnType<typeof serverMock.create>;
@@ -115,37 +113,6 @@ describe('Import rules route', () => {
         action_connectors_errors: [],
       });
     });
-    test('returns a 403 error object if importing actions connectors  fails', async () => {
-      (buildMlAuthz as jest.Mock).mockReturnValueOnce({
-        validateRuleType: jest
-          .fn()
-          .mockResolvedValue({ valid: false, message: 'mocked validation message' }),
-      });
-
-      const response = await server.inject(request, requestContextMock.convertContext(context));
-      expect(response.status).toEqual(200);
-      expect(response.body).toEqual({
-        errors: [
-          {
-            error: {
-              message: 'mocked validation message',
-              status_code: 403,
-            },
-            rule_id: 'rule-1',
-          },
-        ],
-        success: false,
-        success_count: 0,
-        rules_count: 1,
-        exceptions_errors: [],
-        exceptions_success: true,
-        exceptions_success_count: 0,
-        action_connectors_success: true,
-        action_connectors_success_count: 0,
-        action_connectors_warnings: [],
-        action_connectors_errors: [],
-      });
-    });
 
     test('returns error if createRulesAndExceptionsStreamFromNdJson throws error', async () => {
       const transformMock = jest

diff --git a/...server/lib/detection_engine/rule_management/logic/import/action_connectors/utils/index.ts b/...server/lib/detection_engine/rule_management/logic/import/action_connectors/utils/index.ts
@@ -73,7 +73,7 @@ export const handleActionConnectorsErrors = (error: ErrorType, id?: string): Bul
         statusCode: 500,
         message:
           (error as ConflictError)?.type === 'conflict'
-            ? 'There is a conflict' // TODO : choose a message when conflict happen
+            ? 'There is a conflict'
             : (error as Error).message
             ? (error as Error).message
             : '',