-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[apm][uptime][monitoring] Remove
color="ghost"
buttons (#169312)
## Summary 👋 Hey y'all - EUI will shortly be deprecating the `ghost` color in all button components (see https://eui.elastic.co/v89.0.0/#/navigation/button#ghost-vs-dark-mode). In this PR, components using `color="ghost"` within an `EuiBottomBar` already automatically inherit dark mode coloring and should be changed to `color="text"` instead. For the legacy uptime change that adds a theme wrapper, I'm unsure what context it's being used in (does not appear to be a bottom bar) and would appreciate help QAing it. I'm opening this PR ahead of time for your team so you can test this migration and ensure no UI regressions have occurred as a result. ### Checklist - [ ] Tested in light and dark mode --------- Co-authored-by: shahzad31 <shahzad31comp@gmail.com>
- Loading branch information
Showing
4 changed files
with
34 additions
and
51 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 20 additions & 28 deletions
48
x-pack/plugins/monitoring/public/components/renderers/__snapshots__/setup_mode.test.js.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters