Update index.tsx

elastic · Apr 8, 2021 · f4ddeb7 · f4ddeb7
1 parent 032825c
commit f4ddeb7
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/plugins/vis_type_xy/public/editor/components/options/metrics_axes/index.tsx b/src/plugins/vis_type_xy/public/editor/components/options/metrics_axes/index.tsx
@@ -283,27 +283,25 @@ function MetricsAxisOptions(props: ValidationVisOptionsProps<VisParams>) {
     const updatedSeries = metrics.map((agg) => {
       const params = stateParams.seriesParams.find((param) => param.data.id === agg.id);
       const label = agg.makeLabel();
-      let series: SeriesParam;
 
       // update labels for existing params or create new one
       if (params) {
-        series = {
+        return {
           ...params,
           data: {
             ...params.data,
             label,
           },
         };
       } else {
-        series = makeSerie(
+        const series = makeSerie(
           agg.id,
           label,
           firstValueAxesId,
           stateParams.seriesParams[stateParams.seriesParams.length - 1]
         );
+        return series;
       }
-
-      return series;
     });
 
     setValue('seriesParams', updatedSeries);