@streamich review

src/plugins/ui_actions/public/actions/action_internal.ts

@@ -58,11 +58,10 @@ export class ActionInternal<A extends ActionDefinition = ActionDefinition>
   }
 
   public async isCompatible(context: Context<A>): Promise<boolean> {
-    const isCompatibleFromHooks = this.getActionHooks()
-      .map((hook) => hook.onIsCompatible)
-      .filter(Boolean)
-      .reduce((isCompatible, nextHook) => isCompatible && nextHook!(this, context), true);
-    if (!isCompatibleFromHooks) return false;
+    for (const { onIsCompatible } of this.getActionHooks()) {
+      if (onIsCompatible && !onIsCompatible(this, context)) return false;
+    }
+
     if (!this.definition.isCompatible) return true;
     return await this.definition.isCompatible(context);
   }

src/plugins/ui_actions/public/service/ui_actions_service.ts

@@ -52,7 +52,7 @@ export class UiActionsService {
     triggers = new Map(),
     actions = new Map(),
     triggerToActions = new Map(),
-    actionHooks = new Set(),
+    actionHooks = [],
   }: UiActionsServiceParams = {}) {
     this.triggers = triggers;
     this.actions = actions;
@@ -88,9 +88,7 @@ export class UiActionsService {
       throw new Error(`Action [action.id = ${definition.id}] already registered.`);
     }
 
-    const action = new ActionInternal(definition, () =>
-      Array.from(this.actionHooksRegistry.values())
-    );
+    const action = new ActionInternal(definition, () => this.actionHooksRegistry);
 
     this.actions.set(action.id, action);
 
@@ -155,7 +153,7 @@ export class UiActionsService {
   };
 
   public readonly registerActionHook = (hook: ActionHook) => {
-    this.actionHooksRegistry.add(hook);
+    this.actionHooksRegistry.push(hook);
   };
 
   public readonly getAction = <T extends ActionDefinition>(

src/plugins/ui_actions/public/types.ts

@@ -28,7 +28,7 @@ import { ActionHook } from './actions';
 export type TriggerRegistry = Map<TriggerId, TriggerInternal<any>>;
 export type ActionRegistry = Map<string, ActionInternal>;
 export type TriggerToActionsRegistry = Map<TriggerId, string[]>;
-export type ActionHooksRegistry = Set<ActionHook>;
+export type ActionHooksRegistry = ActionHook[];
 
 const DEFAULT_TRIGGER = '';