[Vis Editor] - console error on opening the Inspector from visualizat…

…ion editor Closes: #65268
elastic · May 5, 2020 · fb23482 · fb23482
1 parent f2d1095
commit fb23482
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/plugins/visualizations/public/embeddable/visualize_embeddable.ts b/src/plugins/visualizations/public/embeddable/visualize_embeddable.ts
@@ -138,7 +138,7 @@ export class VisualizeEmbeddable extends Embeddable<VisualizeInput, VisualizeOut
     const adapters = this.handler.inspect();
     if (!adapters) return;
 
-    this.deps.start().plugins.inspector.open(adapters, {
+    return this.deps.start().plugins.inspector.open(adapters, {
       title: this.getTitle() || '',
     });
   };

diff --git a/src/plugins/visualize/public/application/editor/editor.js b/src/plugins/visualize/public/application/editor/editor.js
@@ -260,10 +260,13 @@ function VisualizeAppController($scope, $route, $injector, $timeout, kbnUrlState
       },
       run() {
         const inspectorSession = embeddableHandler.openInspector();
-        // Close the inspector if this scope is destroyed (e.g. because the user navigates away).
-        const removeWatch = $scope.$on('$destroy', () => inspectorSession.close());
-        // Remove that watch in case the user closes the inspector session herself.
-        inspectorSession.onClose.finally(removeWatch);
+
+        if (inspectorSession) {
+          // Close the inspector if this scope is destroyed (e.g. because the user navigates away).
+          const removeWatch = $scope.$on('$destroy', () => inspectorSession.close());
+          // Remove that watch in case the user closes the inspector session herself.
+          inspectorSession.onClose.finally(removeWatch);
+        }
       },
       tooltip() {
         if (!embeddableHandler.hasInspector || !embeddableHandler.hasInspector()) {