Skip to content

Commit

Permalink
[ML] Remove "Are you sure" from data frame analytics jobs (#76214)
Browse files Browse the repository at this point in the history
  • Loading branch information
lcawl authored Sep 1, 2020
1 parent 8466474 commit ff7e7ef
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import {
EuiFlexItem,
EUI_MODAL_CONFIRM_BUTTON,
} from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react';

import { DeleteAction } from './use_delete_action';

Expand All @@ -40,7 +39,7 @@ export const DeleteActionModal: FC<DeleteAction> = ({
<EuiConfirmModal
data-test-subj="mlAnalyticsJobDeleteModal"
title={i18n.translate('xpack.ml.dataframe.analyticsList.deleteModalTitle', {
defaultMessage: 'Delete {analyticsId}',
defaultMessage: 'Delete {analyticsId}?',
values: { analyticsId: item.config.id },
})}
onCancel={closeModal}
Expand All @@ -60,13 +59,6 @@ export const DeleteActionModal: FC<DeleteAction> = ({
defaultFocusedButton={EUI_MODAL_CONFIRM_BUTTON}
buttonColor="danger"
>
<p>
<FormattedMessage
id="xpack.ml.dataframe.analyticsList.deleteModalBody"
defaultMessage="Are you sure you want to delete this analytics job?"
/>
</p>

<EuiFlexGroup direction="column" gutterSize="none">
<EuiFlexItem>
{userCanDeleteIndex && (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const StartActionModal: FC<StartAction> = ({ closeModal, item, startAndCl
<EuiOverlayMask>
<EuiConfirmModal
title={i18n.translate('xpack.ml.dataframe.analyticsList.startModalTitle', {
defaultMessage: 'Start {analyticsId}',
defaultMessage: 'Start {analyticsId}?',
values: { analyticsId: item.config.id },
})}
onCancel={closeModal}
Expand All @@ -40,7 +40,7 @@ export const StartActionModal: FC<StartAction> = ({ closeModal, item, startAndCl
<p>
{i18n.translate('xpack.ml.dataframe.analyticsList.startModalBody', {
defaultMessage:
'A data frame analytics job will increase search and indexing load in your cluster. Please stop the analytics job if excessive load is experienced. Are you sure you want to start this analytics job?',
'A data frame analytics job increases search and indexing load in your cluster. If excessive load occurs, stop the job.',
})}
</p>
</EuiConfirmModal>
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -11113,7 +11113,6 @@
"xpack.ml.dataframe.analyticsList.deleteAnalyticsWithIndexPatternSuccessMessage": "インデックスパターン{destinationIndex}を削除する要求が確認されました。",
"xpack.ml.dataframe.analyticsList.deleteAnalyticsWithIndexSuccessMessage": "ディスティネーションインデックス{destinationIndex}を削除する要求が確認されました。",
"xpack.ml.dataframe.analyticsList.deleteDestinationIndexTitle": "ディスティネーションインデックス{indexName}を削除",
"xpack.ml.dataframe.analyticsList.deleteModalBody": "この分析ジョブを削除してよろしいですか?",
"xpack.ml.dataframe.analyticsList.deleteModalCancelButton": "キャンセル",
"xpack.ml.dataframe.analyticsList.deleteModalDeleteButton": "削除",
"xpack.ml.dataframe.analyticsList.deleteModalTitle": "{analyticsId}の削除",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -11116,7 +11116,6 @@
"xpack.ml.dataframe.analyticsList.deleteAnalyticsWithIndexPatternSuccessMessage": "删除索引模式 {destinationIndex} 的请求已确认。",
"xpack.ml.dataframe.analyticsList.deleteAnalyticsWithIndexSuccessMessage": "删除目标索引 {destinationIndex} 的请求已确认。",
"xpack.ml.dataframe.analyticsList.deleteDestinationIndexTitle": "删除目标索引 {indexName}",
"xpack.ml.dataframe.analyticsList.deleteModalBody": "是否确定要删除此分析作业?",
"xpack.ml.dataframe.analyticsList.deleteModalCancelButton": "取消",
"xpack.ml.dataframe.analyticsList.deleteModalDeleteButton": "删除",
"xpack.ml.dataframe.analyticsList.deleteModalTitle": "删除 {analyticsId}",
Expand Down

0 comments on commit ff7e7ef

Please sign in to comment.