Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Allow palette configuration for heatmap #102034

Closed
flash1293 opened this issue Jun 14, 2021 · 4 comments · Fixed by #102636
Closed

[Lens] Allow palette configuration for heatmap #102034

flash1293 opened this issue Jun 14, 2021 · 4 comments · Fixed by #102636
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

There is a nice palette configuration UI for table coloring, but heatmaps are statically using the temperature palette. We should expose the same palette configuration UI to allow the user to change the coloring scheme of the heatmap in a way they are accustomed to.

@flash1293 flash1293 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@dej611
Copy link
Contributor

dej611 commented Jun 18, 2021

Created a first MVP for this: #102034

Note that the color continuity has been removed in the panel due to some limitations of the Heatmap visualization component and a chat with @markov00 from the dataviz team.

In the current PR the color continuity value set is Above and below range, which extends the color palette on both extremities as in the Heatmap defualt behaviour.
It would be possible to enable also the Above range strategy, possibly, but that requires some discussion about null values and out of range values representation:

Screenshot 2021-06-18 at 14 24 28

The popover is showing an out of value there, colored in white (it depends on the current kibana theme). The previous cell is still white but it has no value, therefore no popup as well, and there's no way, other than hovering to know about the difference between the two.
In the datatable case this was "resolved" by the different representation of null values (-) and out of range values (actual value just not coloured), but in this case there's no way to differenciate it (yet).

As for the Below range and Within range strategies, there are also some component limitations which need to be addressed.

Probably before starting to address the technical limitations of the component it is worth discussing whether it makes sense for the Heatmap visualization to represent a filtered set of data via a filtered palette representation, or whether it makes more sense to handle the filtering at higher level, as Kibana/Lens filters directly.

@flash1293
Copy link
Contributor Author

I think it makes sense to always do "Above and below range" for a heatmap - the color of a cell is whole deal, so it doesn't make sense to not assign a color. If they really want, the user could work around this by setting the first/last color stop to white (emulating out of range)

@flash1293
Copy link
Contributor Author

cc @ghudgins @MichaelMarcialis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants