Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Regression: embeddable frames show up as dashed grey frames #107498

Closed
kesslerm opened this issue Aug 3, 2021 · 3 comments
Closed

[Canvas] Regression: embeddable frames show up as dashed grey frames #107498

kesslerm opened this issue Aug 3, 2021 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas triage_needed

Comments

@kesslerm
Copy link

kesslerm commented Aug 3, 2021

Kibana version: 7.13.4

Elasticsearch version:

Server OS version:

Browser version: any, tested with Firefox 90.0.2

Browser OS version: any, tested with Mac OS, Linux

Original install method (e.g. download page, yum, from source, etc.):

Describe the bug:

As a regression from pre-7.13 Kibana, previously invisible frames are now displayed as dashed grey frames and cannot easily be hidden by attaching custom CSS styles.

Steps to reproduce:

  1. Place an embeddable frame on a canvas (e.g. time selector)
  2. The frame will show up as a dashed frame with its light grey default colour, even if the parent elements have a different setting.

Expected behavior:

The embeddable frame should remain invisible

Screenshots (if relevant):
strange_border

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

The current behaviour was introduced by https://github.com/elastic/kibana/pull/98507/files#diff-903b4c8556f82e2152dbc439f2a8d92022ec07e14ccc9c8038e163b2497c9996, which marked CSS elements a !important. Embeddable frames are reused in many contexts across Kibana. Maybe in Canvas a different class needs to be chosen for affected elements such as the time period chooser?

@kesslerm kesslerm added the bug Fixes for quality problems that affect the customer experience label Aug 3, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 3, 2021
@kertal kertal added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Aug 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 9, 2021
@lucabelluccini
Copy link
Contributor

lucabelluccini commented Aug 12, 2021

Possible workaround described at https://discuss.elastic.co/t/how-to-remove-dotted-border-from-visualizations-when-imported-to-canvas-workpads/276785/2

In the expression editor, add to the render directive:

css=".embPanel--editing {
  border:none !important;
}"

@poffdeluxe
Copy link
Contributor

Fixed by #113985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas triage_needed
Projects
None yet
Development

No branches or pull requests

7 participants