Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Hide dashed border on embeddable panel #113985

Merged
merged 1 commit into from
Oct 6, 2021
Merged

[Canvas] Hide dashed border on embeddable panel #113985

merged 1 commit into from
Oct 6, 2021

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Oct 5, 2021 •
edited
Loading

Summary

Closes #113984.

This hides the dashed border surrounding embeddables in Canvas. Canvas already has it's own dashed border around selected elements, so we can just hide the one provided by the embeddable panel.

Before:
Screen Shot 2021-10-05 at 11 10 15 AM

After:
Screen Shot 2021-10-05 at 11 11 25 AM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cqliu1 cqliu1 added release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort v8.0.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:Canvas v7.16.0 labels Oct 5, 2021
@cqliu1 cqliu1 requested a review from a team as a code owner October 5, 2021 18:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

This was referenced Oct 5, 2021
Closed
Merged
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB +116.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

andreadelrio
andreadelrio approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sass change LGTM

@cqliu1 cqliu1 added v7.15.1 auto-backport Deprecated - use backport:version if exact versions are needed labels Oct 6, 2021
@cqliu1 cqliu1 merged commit 27215ec into elastic:master Oct 6, 2021
@cqliu1 cqliu1 deleted the fix/hide-embeddable-dashed-border branch October 6, 2021 00:50
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 6, 2021
@cqliu1 @kibanamachine
[Canvas] Hide dashed border on embeddable panel (elastic#113985)
8d82069
@kibanamachine kibanamachine mentioned this pull request Oct 6, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 6, 2021
@cqliu1 @kibanamachine
[Canvas] Hide dashed border on embeddable panel (elastic#113985)
768372f
@kibanamachine kibanamachine mentioned this pull request Oct 6, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x
✅ 7.15

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 6, 2021
@kibanamachine @cqliu1
[Canvas] Hide dashed border on embeddable panel (#113985) (#114044)
1f5edd2 
Co-authored-by: Catherine Liu <catherine.liu@elastic.co>
kibanamachine added a commit that referenced this pull request Oct 6, 2021
@kibanamachine @cqliu1
[Canvas] Hide dashed border on embeddable panel (#113985) (#114043)
6dcaa9d 
Co-authored-by: Catherine Liu <catherine.liu@elastic.co>
@poffdeluxe poffdeluxe mentioned this pull request Nov 15, 2021
Closed
@cqliu1 cqliu1 restored the fix/hide-embeddable-dashed-border branch June 8, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreadelrio andreadelrio andreadelrio approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.15.1 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Canvas] Dashed border on embeddable elements in view/fullscreen mode
4 participants
@cqliu1 @elasticmachine @kibanamachine @andreadelrio