Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring][Angular removal] Add error handling to requests #111842

Closed
Tracked by #111309
estermv opened this issue Sep 10, 2021 · 1 comment · Fixed by #114029
Closed
Tracked by #111309

[Stack Monitoring][Angular removal] Add error handling to requests #111842

estermv opened this issue Sep 10, 2021 · 1 comment · Fixed by #114029
Assignees
Labels
Epic: Stack Monitoring de-angularization Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@estermv
Copy link
Contributor

estermv commented Sep 10, 2021

Add error handling to stack monitoring requests.

Technical notes

In Angular we are using this error handler to show some toast when there is an error in a request.
Since we still have the Legacy class in react, it could be easily migrated just replacing history with the useHistory hook.
It's also using a formatMsg function from kibana_legacy that we would need to check if we can still use.

@estermv estermv added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Stack Monitoring Epic: Stack Monitoring de-angularization labels Sep 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Stack Monitoring de-angularization Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
3 participants