[Stack Monitoring] Adding alerts to react app #114029

simianhacker · 2021-10-05T23:10:19Z

Summary

This PR closes #111774 by adding the alerts dropdown to the header and loading alerts on all the pages that needed alerts. This PR also closes #111842 by adding an error handler for the requests that had // TODO: handle error.

…add-alerts-to-sm-react

elasticmachine · 2021-10-05T23:29:59Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

estermv

Are you still working on this? There are missing some features:

The modal doesn't appear on the overview page
Alerts needs to be loaded also in other pages, for example in the elasticsearch nodes page like in angular:

(from your description is not clear if you plan to do this in following PRs, so sorry if that's the case, and I'm also not sure if all the views that load alerts are merged to master...)

There is an error when loading the application:
ERROR in ./public/application/setup_mode/setup_mode_renderer.js │ Module not found: Error: Can't resolve '../../application/global_state_context' because the path just needs to be updated.

I also see an error when clicking on the "Create default rules" link in the dropdown:

But the request seems to work fine and alerts are created. Maybe it's an error parsing the response.

x-pack/plugins/monitoring/public/application/pages/page_template.tsx

neptunian · 2021-10-06T13:59:30Z

@simianhacker Alerts were not added to any of the views as @estermv pointed out. I wonder if that would be too many changes for one PR or if we should go back through each section to make the changes and test?

simianhacker · 2021-10-06T18:34:28Z

I can add them in this PR. I wasn't sure where all the alerts needed to be loaded.

…ving loadAlerts from page template

…add-alerts-to-sm-react

…ponse.json call

…add-alerts-to-sm-react

neptunian · 2021-10-07T17:08:41Z

In the Angular version only, when trying to edit any rule from within SM app I get:

This doesn't happen in Stack Management -> RAC

neptunian · 2021-10-07T17:25:04Z

It looks like all the rules are being passed instead of the ones that belong to that page.

Nodes should have 6 rules. Open the dropdown by clicking the badge to see too many rules.

Indicies should have 1 rule

I think that gets done like this: https://github.com/elastic/kibana/blob/master/x-pack/plugins/monitoring/public/views/elasticsearch/nodes/index.js#L96

estermv · 2021-10-07T17:25:23Z

Code looks good. I'll leave to someone else to approve it.

simianhacker · 2021-10-07T17:30:24Z

@neptunian The error in #114029 (comment) is happening on master too. We should file a bug and fix that in a separate PR.

neptunian · 2021-10-07T17:55:01Z

In the react version only of this branch when I click on Kibana -> Instances, the page doesn't load

Cannot read properties of undefined (reading 'total')

neptunian · 2021-10-07T18:53:09Z

When alerts are firing for several nodes, clicking on an individual node should only list alert information for that node

correct version screenshot

neptunian · 2021-10-07T20:37:00Z

I have alerts firing on the logstash nodes but they don't appear in the Logstash nodes listing page. Also the "Alerts" that has the alert count above the table is missing.

correct version screenshot

Use this to get alert firing https://gist.github.com/chrisronline/3b982d95710ef820d11c7443a1e49091

neptunian · 2021-10-11T13:06:41Z

@elasticmachine merge upstream

kibanamachine · 2021-10-11T15:44:16Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 0e73f5a
Storybooks Preview
Flaky suites:
- xpack-kibana-ciGroup8

Test Failures

Kibana Pipeline / general / Performance Tests.x-pack/test/performance/tests/reporting_dashboard·ts.performance reporting dashbaord downloaded PDF has OK status

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 3 times on tracked branches: https://github.com/elastic/kibana/issues/110470

[00:00:00]                         │
[00:00:00]                           └-: performance
[00:00:00]                             └-> "before all" hook in "performance"
[00:00:00]                             └-: reporting dashbaord
[00:00:00]                               └-> "before all" hook for "downloaded PDF has OK status"
[00:00:00]                               └-> "before all" hook for "downloaded PDF has OK status"
[00:00:00]                                 │ debg resolved import for x-pack/test/performance/kbn_archives/reporting_dashboard to /dev/shm/workspace/parallel/21/kibana/x-pack/test/performance/kbn_archives/reporting_dashboard.json
[00:00:00]                                 │ info importing 4 saved objects { space: undefined }
[00:00:00]                                 │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/HIlZuoBNSI-OJyaEQlKkgg] update_mapping [_doc]
[00:00:00]                                 │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/HIlZuoBNSI-OJyaEQlKkgg] update_mapping [_doc]
[00:00:00]                                 │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/HIlZuoBNSI-OJyaEQlKkgg] update_mapping [_doc]
[00:00:00]                                 │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/HIlZuoBNSI-OJyaEQlKkgg] update_mapping [_doc]
[00:00:00]                                 │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/HIlZuoBNSI-OJyaEQlKkgg] update_mapping [_doc]
[00:00:00]                                 │ succ import success
[00:00:00]                                 │ info [x-pack/test/performance/es_archives/reporting_dashboard] Loading "mappings.json"
[00:00:00]                                 │ info [x-pack/test/performance/es_archives/reporting_dashboard] Loading "data.json.gz"
[00:00:00]                                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [foo] creating index, cause [api], templates [], shards [1]/[1]
[00:00:00]                                 │ info [x-pack/test/performance/es_archives/reporting_dashboard] Created index "foo"
[00:00:00]                                 │ debg [x-pack/test/performance/es_archives/reporting_dashboard] "foo" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:00:02]                                 │ info [x-pack/test/performance/es_archives/reporting_dashboard] Indexed 10000 docs into "foo"
[00:00:02]                               └-> downloaded PDF has OK status
[00:00:02]                                 └-> "before each" hook: global before each for "downloaded PDF has OK status"
[00:00:02]                                 │ debg navigating to dashboards url: http://localhost:61211/app/dashboards
[00:00:02]                                 │ debg navigate to: http://localhost:61211/app/dashboards
[00:00:03]                                 │ debg browser[INFO] http://localhost:61211/login?next=%2Fapp%2Fdashboards%3F_t%3D1633963219924 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:03]                                 │
[00:00:03]                                 │ debg browser[INFO] http://localhost:61211/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:03]                                 │ debg ... sleep(700) start
[00:00:03]                                 │ debg ... sleep(700) end
[00:00:03]                                 │ debg returned from get, calling refresh
[00:00:04]                                 │ debg browser[INFO] http://localhost:61211/login?next=%2Fapp%2Fdashboards%3F_t%3D1633963219924 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:04]                                 │
[00:00:04]                                 │ debg browser[INFO] http://localhost:61211/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:05]                                 │ debg currentUrl = http://localhost:61211/login?next=%2Fapp%2Fdashboards%3F_t%3D1633963219924
[00:00:05]                                 │          appUrl = http://localhost:61211/app/dashboards
[00:00:05]                                 │ debg TestSubjects.find(kibanaChrome)
[00:00:05]                                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:05]                                 │ debg Found login page
[00:00:05]                                 │ debg TestSubjects.setValue(loginUsername, test_user)
[00:00:05]                                 │ debg TestSubjects.click(loginUsername)
[00:00:05]                                 │ debg Find.clickByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:00:05]                                 │ debg Find.findByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:00:05]                                 │ERROR browser[SEVERE] http://localhost:61211/api/licensing/info - Failed to load resource: the server responded with a status of 401 (Unauthorized)
[00:00:06]                                 │ debg TestSubjects.setValue(loginPassword, changeme)
[00:00:06]                                 │ debg TestSubjects.click(loginPassword)
[00:00:06]                                 │ debg Find.clickByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:00:06]                                 │ debg Find.findByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:00:06]                                 │ debg TestSubjects.click(loginSubmit)
[00:00:06]                                 │ debg Find.clickByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:00:06]                                 │ debg Find.findByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:00:06]                                 │ debg Find.waitForDeletedByCssSelector('.kibanaWelcomeLogo') with timeout=10000
[00:00:06]                                 │ proc [kibana] [2021-10-11T14:40:23.388+00:00][INFO ][plugins.security.routes] Logging in with provider "basic" (basic)
[00:00:07]                                 │ debg browser[INFO] http://localhost:61211/app/dashboards?_t=1633963219924 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:07]                                 │
[00:00:07]                                 │ debg browser[INFO] http://localhost:61211/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:07]                                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:08]                                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"] nav:not(.ng-hide)') with timeout=60000
[00:00:09]                                 │ debg browser[INFO] http://localhost:61211/app/dashboards?_t=1633963226005 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:09]                                 │
[00:00:09]                                 │ debg browser[INFO] http://localhost:61211/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:10]                                 │ debg Finished login process currentUrl = http://localhost:61211/app/dashboards
[00:00:10]                                 │ debg ... sleep(501) start
[00:00:10]                                 │ debg ... sleep(501) end
[00:00:10]                                 │ debg in navigateTo url = http://localhost:61211/app/dashboards
[00:00:10]                                 │ debg Waiting up to 20000ms for dashboard landing page...
[00:00:10]                                 │ debg onDashboardLandingPage
[00:00:10]                                 │ debg TestSubjects.exists(dashboardLandingPage)
[00:00:10]                                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="dashboardLandingPage"]') with timeout=5000
[00:00:11]                                 │ debg Load Saved Dashboard dashboard
[00:00:11]                                 │ debg gotoDashboardLandingPage
[00:00:11]                                 │ debg onDashboardLandingPage
[00:00:11]                                 │ debg TestSubjects.exists(dashboardLandingPage)
[00:00:11]                                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="dashboardLandingPage"]') with timeout=5000
[00:00:11]                                 │ debg searchForItemWithName: dashboard
[00:00:11]                                 │ debg TestSubjects.find(tableListSearchBox)
[00:00:11]                                 │ debg Find.findByCssSelector('[data-test-subj="tableListSearchBox"]') with timeout=10000
[00:00:11]                                 │ debg isGlobalLoadingIndicatorVisible
[00:00:11]                                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:00:11]                                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:00:11]                                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:00:11]                                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:00:13]                                 │ debg TestSubjects.click(dashboardListingTitleLink-dashboard)
[00:00:13]                                 │ debg Find.clickByCssSelector('[data-test-subj="dashboardListingTitleLink-dashboard"]') with timeout=10000
[00:00:13]                                 │ debg Find.findByCssSelector('[data-test-subj="dashboardListingTitleLink-dashboard"]') with timeout=10000
[00:00:13]                                 │ debg isGlobalLoadingIndicatorVisible
[00:00:13]                                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:00:13]                                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:00:13]                                 │ debg browser[INFO] http://localhost:61211/app/dashboards#/view/37b49c50-2dc6-11eb-8af3-cb3aa84dbabd?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now)) 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:13]                                 │
[00:00:13]                                 │ debg browser[INFO] http://localhost:61211/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:15]                                 │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:00:16]                                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:00:16]                                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:00:16]                                 │ debg TestSubjects.missingOrFail(dashboardLandingPage)
[00:00:16]                                 │ debg Find.waitForDeletedByCssSelector('[data-test-subj="dashboardLandingPage"]') with timeout=10000
[00:00:16]                                 │ debg openPdfReportingPanel
[00:00:16]                                 │ debg openShareMenuItem title:PDF Reports
[00:00:16]                                 │ debg TestSubjects.exists(shareContextMenu)
[00:00:16]                                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="shareContextMenu"]') with timeout=2500
[00:00:17]                                 │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.async-search] creating index, cause [auto(bulk api)], templates [], shards [1]/[0]
[00:00:19]                                 │ debg --- retry.tryForTime error: [data-test-subj="shareContextMenu"] is not displayed
[00:00:19]                                 │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/HIlZuoBNSI-OJyaEQlKkgg] update_mapping [_doc]
[00:00:20]                                 │ debg TestSubjects.click(shareTopNavButton)
[00:00:20]                                 │ debg Find.clickByCssSelector('[data-test-subj="shareTopNavButton"]') with timeout=10000
[00:00:20]                                 │ debg Find.findByCssSelector('[data-test-subj="shareTopNavButton"]') with timeout=10000
[00:00:21]                                 │ debg Find.findByCssSelector('div.euiContextMenuPanel') with timeout=10000
[00:00:21]                                 │ debg TestSubjects.click(sharePanel-PDFReports)
[00:00:21]                                 │ debg Find.clickByCssSelector('[data-test-subj="sharePanel-PDFReports"]') with timeout=10000
[00:00:21]                                 │ debg Find.findByCssSelector('[data-test-subj="sharePanel-PDFReports"]') with timeout=10000
[00:00:22]                                 │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/HIlZuoBNSI-OJyaEQlKkgg] update_mapping [_doc]
[00:00:22]                                 │ debg Find.waitForElementStale with timeout=10000
[00:00:22]                                 │ debg TestSubjects.click(generateReportButton)
[00:00:22]                                 │ debg Find.clickByCssSelector('[data-test-subj="generateReportButton"]') with timeout=10000
[00:00:22]                                 │ debg Find.findByCssSelector('[data-test-subj="generateReportButton"]') with timeout=10000
[00:00:24]                                 │ debg getReportURL
[00:00:24]                                 │ debg TestSubjects.getAttribute(downloadCompletedReportButton, href, tryTimeout=120000, findTimeout=60000)
[00:00:24]                                 │ debg TestSubjects.find(downloadCompletedReportButton)
[00:00:24]                                 │ debg Find.findByCssSelector('[data-test-subj="downloadCompletedReportButton"]') with timeout=60000
[00:01:25]                                 │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="downloadCompletedReportButton"])
[00:01:25]                                 │      Wait timed out after 61199ms
[00:01:26]                                 │ debg TestSubjects.find(downloadCompletedReportButton)
[00:01:26]                                 │ debg Find.findByCssSelector('[data-test-subj="downloadCompletedReportButton"]') with timeout=60000
[00:02:27]                                 │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="downloadCompletedReportButton"])
[00:02:27]                                 │      Wait timed out after 61169ms
[00:02:27]                                 │ info Taking screenshot "/dev/shm/workspace/parallel/21/kibana/x-pack/test/functional/screenshots/failure/performance reporting dashbaord downloaded PDF has OK status.png"
[00:02:27]                                 │ info Current URL is: http://localhost:61211/app/dashboards#/view/37b49c50-2dc6-11eb-8af3-cb3aa84dbabd?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:02:28]                                 │ info Saving page source to: /dev/shm/workspace/parallel/21/kibana/x-pack/test/performance/failure_debug/html/performance reporting dashbaord downloaded PDF has OK status.html
[00:02:28]                                 └- ✖ fail: performance reporting dashbaord downloaded PDF has OK status
[00:02:28]                                 │      Error: retry.tryForTime timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="downloadCompletedReportButton"])
[00:02:28]                                 │ Wait timed out after 61169ms
[00:02:28]                                 │     at /dev/shm/workspace/parallel/21/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:02:28]                                 │     at runMicrotasks (<anonymous>)
[00:02:28]                                 │     at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:02:28]                                 │       at onFailure (/dev/shm/workspace/parallel/21/kibana/test/common/services/retry/retry_for_success.ts:17:9)
[00:02:28]                                 │       at retryForSuccess (/dev/shm/workspace/parallel/21/kibana/test/common/services/retry/retry_for_success.ts:59:13)
[00:02:28]                                 │       at RetryService.tryForTime (/dev/shm/workspace/parallel/21/kibana/test/common/services/retry/retry.ts:22:12)
[00:02:28]                                 │       at TestSubjects.getAttribute (/dev/shm/workspace/parallel/21/kibana/test/functional/services/common/test_subjects.ts:190:12)
[00:02:28]                                 │       at ReportingPageObject.getReportURL (test/functional/page_objects/reporting_page.ts:36:17)
[00:02:28]                                 │       at Context.<anonymous> (test/performance/tests/reporting_dashboard.ts:50:7)
[00:02:28]                                 │       at Object.apply (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:02:28]                                 │ 
[00:02:28]                                 │

Stack Trace

Error: retry.tryForTime timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="downloadCompletedReportButton"])
Wait timed out after 61169ms
    at /dev/shm/workspace/parallel/21/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at onFailure (/dev/shm/workspace/parallel/21/kibana/test/common/services/retry/retry_for_success.ts:17:9)
    at retryForSuccess (/dev/shm/workspace/parallel/21/kibana/test/common/services/retry/retry_for_success.ts:59:13)
    at RetryService.tryForTime (/dev/shm/workspace/parallel/21/kibana/test/common/services/retry/retry.ts:22:12)
    at TestSubjects.getAttribute (/dev/shm/workspace/parallel/21/kibana/test/functional/services/common/test_subjects.ts:190:12)
    at ReportingPageObject.getReportURL (test/functional/page_objects/reporting_page.ts:36:17)
    at Context.<anonymous> (test/performance/tests/reporting_dashboard.ts:50:7)
    at Object.apply (/dev/shm/workspace/parallel/21/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`monitoring`	650	654	+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`monitoring`	1.1MB	1.1MB	+13.9KB

History

💚 Build #159152 succeeded 3a126f2
💚 Build #159113 succeeded 225ee7e
💚 Build #159089 succeeded 6c5110e
💚 Build #159081 succeeded c1de323
💚 Build #159048 succeeded 40a6d2e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Reviewer on PTO

kibanamachine · 2021-10-11T16:57:47Z

💔 Backport failed

Status	Branch	Result
❌	7.x	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 114029

* [Stack Monitoring] Adding alerts to react app * Fixing global state context path * adding alerts to pages; adding alerts model to cluster_overview; removing loadAlerts from page template * Fixing request for enable alerts * remove loadAlerts from page template * Adding request error handlers * removing redundent error handling * Changing useRequestErrorHandler function to be async due to error.response.json call * removing old comment * Fixing contexts paths * Converting ajaxRequestErrorHandler to useRequestErrorHandler * Refactoring error handler for page template and setup mode * Removing unnecessary async/await * Removing unnecessary async/await in useClusters * adding alertTypeIds to each page * fixing instance count * Adding alertTypeIds to index page * Adding alert filters for specific pages * Adding alerts to Logstash nodes Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Stack Monitoring] Adding alerts to react app (#114029) * [Stack Monitoring] Adding alerts to react app * Fixing global state context path * adding alerts to pages; adding alerts model to cluster_overview; removing loadAlerts from page template * Fixing request for enable alerts * remove loadAlerts from page template * Adding request error handlers * removing redundent error handling * Changing useRequestErrorHandler function to be async due to error.response.json call * removing old comment * Fixing contexts paths * Converting ajaxRequestErrorHandler to useRequestErrorHandler * Refactoring error handler for page template and setup mode * Removing unnecessary async/await * Removing unnecessary async/await in useClusters * adding alertTypeIds to each page * fixing instance count * Adding alertTypeIds to index page * Adding alert filters for specific pages * Adding alerts to Logstash nodes Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Fixing types from merge Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

[Stack Monitoring] Adding alerts to react app

1c1c70e

Merge branch 'master' of github.com:elastic/kibana into issue-111774-…

0be936a

…add-alerts-to-sm-react

simianhacker marked this pull request as ready for review October 5, 2021 23:29

simianhacker requested a review from a team as a code owner October 5, 2021 23:29

simianhacker requested review from a team October 5, 2021 23:29

simianhacker added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 5, 2021

simianhacker enabled auto-merge (squash) October 5, 2021 23:30

estermv reviewed Oct 6, 2021

View reviewed changes

x-pack/plugins/monitoring/public/application/pages/page_template.tsx Outdated Show resolved Hide resolved

simianhacker marked this pull request as draft October 6, 2021 18:34

auto-merge was automatically disabled October 6, 2021 18:34
Pull request was converted to draft

simianhacker added 10 commits October 6, 2021 12:49

Fixing global state context path

bd9071c

adding alerts to pages; adding alerts model to cluster_overview; remo…

eb13d50

…ving loadAlerts from page template

Fixing request for enable alerts

6c4dbdc

remove loadAlerts from page template

45a10a8

Adding request error handlers

e71f91c

Merge branch 'master' of github.com:elastic/kibana into issue-111774-…

ba3c7ff

…add-alerts-to-sm-react

removing redundent error handling

924aa88

Changing useRequestErrorHandler function to be async due to error.res…

344852b

…ponse.json call

removing old comment

716a1dd

Fixing contexts paths

58d2888

simianhacker added 3 commits October 7, 2021 10:44

Merge branch 'master' of github.com:elastic/kibana into issue-111774-…

d19b722

…add-alerts-to-sm-react

Removing unnecessary async/await

6d733c6

Removing unnecessary async/await in useClusters

40a6d2e

simianhacker requested a review from estermv October 7, 2021 16:53

simianhacker added 3 commits October 7, 2021 12:06

adding alertTypeIds to each page

0c059ad

fixing instance count

c1de323

Adding alertTypeIds to index page

6c5110e

Adding alert filters for specific pages

225ee7e

simianhacker requested review from neptunian and removed request for estermv October 7, 2021 19:34

Adding alerts to Logstash nodes

3a126f2

Merge branch 'master' into issue-111774-add-alerts-to-sm-react

0e73f5a

neptunian approved these changes Oct 11, 2021

View reviewed changes

simianhacker merged commit c8a0108 into elastic:master Oct 11, 2021

simianhacker mentioned this pull request Oct 11, 2021

[7.x] [Stack Monitoring] Adding alerts to react app (#114029) #114538

Merged

simianhacker deleted the issue-111774-add-alerts-to-sm-react branch April 17, 2024 15:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Stack Monitoring] Adding alerts to react app #114029

[Stack Monitoring] Adding alerts to react app #114029

simianhacker commented Oct 5, 2021 •

edited

Loading

elasticmachine commented Oct 5, 2021

estermv left a comment •

edited

Loading

neptunian commented Oct 6, 2021 •

edited

Loading

simianhacker commented Oct 6, 2021

neptunian commented Oct 7, 2021 •

edited

Loading

neptunian commented Oct 7, 2021 •

edited

Loading

estermv commented Oct 7, 2021

simianhacker commented Oct 7, 2021

neptunian commented Oct 7, 2021

neptunian commented Oct 7, 2021

neptunian commented Oct 7, 2021 •

edited

Loading

neptunian commented Oct 11, 2021

kibanamachine commented Oct 11, 2021

Standard Out

Stack Trace

kibanamachine commented Oct 11, 2021

[Stack Monitoring] Adding alerts to react app #114029

[Stack Monitoring] Adding alerts to react app #114029

Conversation

simianhacker commented Oct 5, 2021 • edited Loading

Summary

elasticmachine commented Oct 5, 2021

estermv left a comment • edited Loading

Choose a reason for hiding this comment

neptunian commented Oct 6, 2021 • edited Loading

simianhacker commented Oct 6, 2021

neptunian commented Oct 7, 2021 • edited Loading

neptunian commented Oct 7, 2021 • edited Loading

estermv commented Oct 7, 2021

simianhacker commented Oct 7, 2021

neptunian commented Oct 7, 2021

neptunian commented Oct 7, 2021

neptunian commented Oct 7, 2021 • edited Loading

neptunian commented Oct 11, 2021

kibanamachine commented Oct 11, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Module Count

Async chunks

History

kibanamachine commented Oct 11, 2021

💔 Backport failed

simianhacker commented Oct 5, 2021 •

edited

Loading

estermv left a comment •

edited

Loading

neptunian commented Oct 6, 2021 •

edited

Loading

neptunian commented Oct 7, 2021 •

edited

Loading

neptunian commented Oct 7, 2021 •

edited

Loading

neptunian commented Oct 7, 2021 •

edited

Loading