-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and re-enable legacy import functional tests #114053
Comments
Pinging @elastic/kibana-core (Team:Core) |
I think it is now! |
@pgayvallet, sorry for the delay, I have updated the description. |
Legacy imports aren't supported in 8.0 and we deleted the tests:
Since legacy format imports are theoretically still supported in 7.16, there isn't an "easy" option to delete them from those branches. We'll need to get them re-enabled. |
@tylersmalley these tests are still failing on CI but pass locally 😦 . I see your initial attempt at re-enabling them failed the build too. |
@TinaHeiligers, all the failures are regarding not being able to locate the index pattern as seen in the screenshots. I, too was unable to reproduce locally. I am prett sure it's timing related, so I will leave it up to your team how to proceed. |
I isolated one of the failed tests ( The debugging exercise confirms that there is a discrepancy in behavior between the local environment and the CI environment: During the import file, the UI calls the The aforementioned method returns different values: Local environment CI tests (link here) This, in turn, triggers different UI flows in the I believe the other failing tests reported in this issue are due to the same problem, since the errors captured in the screenshots are the same. Now we need to find out what is causing this discrepancy. |
Drilling down a bit further, it seems that the errors that occur during the JSON file processing have slightly different names for their constructors: Local environment: error.constructor.name: That's what's causing the errors to be treated differently. |
Very interesting, and would totally make sense to have this broken during a Babel update. Now the main question, why would this be different between CI and Local? @tylersmalley Are you aware of any difference on the way Babel perform its transpilation between a local and CI run? |
Whilst waiting for feedback from @elastic/kibana-operations regarding the reason behind the We still need to clarify the source of the discrepancy though, as it might be impacting other places where |
These tests failed on the backport of #113680, and ended up needing to be skipped.
Failures:
I went through the tests manually and was not able to reproduce them, so seems to be a race condition of sorts with the test.
The text was updated successfully, but these errors were encountered: