Removes support for legacy exports #110738

TinaHeiligers · 2021-09-01T00:30:10Z

Summary

Removes support for legacy imports from the top most UI layer of saved objects management.
Handles Phase 1 of #103921

The documentation about importing saved objects only talks about importing .ndjson files, so we don't need to do anything there.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

Risk Matrix

Risk	Probability	Severity	Mitigation/Notes
Saved objects in legacy format will not be usable	Low	Low	Users should export their saved objects from the UI or rely on snapshots as backups for their data rather than raw exports from versions < 7 that are in the legacy format. We've been warning about the support for legacy format going away since 7.0, which should have given users plenty of time to convert their data.

For maintainers

This was checked for breaking API changes and was labeled appropriately (none)

Release note:

In Kibana 8.0, we will no longer support the legacy export format from Kibana 6.x. Importing saved objects using the UI is restricted to .ndjson format imports.

…etest fixture

TinaHeiligers · 2021-09-01T23:02:12Z

@elasticmachine merge upstream

TinaHeiligers · 2021-09-01T23:07:25Z

...d_objects_management/public/management_section/objects_table/components/flyout.test.mocks.ts

@@ -16,11 +16,6 @@ jest.doMock('../../../lib/resolve_import_errors', () => ({
  resolveImportErrors: resolveImportErrorsMock,
 }));

-export const importLegacyFileMock = jest.fn();


I only removed the mock for the method we're removing here.

TinaHeiligers · 2021-09-01T23:10:18Z

...ugins/saved_objects_management/public/management_section/objects_table/components/flyout.tsx

-    this.setState({ status: 'loading', error: undefined });
-
-    // Log warning on server, don't wait for response
-    logLegacyImport(http);


The method and route will be removed in a follow up that handles the second bullet point of #103921

TinaHeiligers · 2021-09-01T23:11:27Z

...ugins/saved_objects_management/public/management_section/objects_table/components/flyout.tsx

@@ -635,7 +440,8 @@ export class Flyout extends Component<FlyoutProps, FlyoutState> {
      );
    }

-    if (!isLegacyFile && status === 'success') {
+    // Import summary for completed import


Not sure if the code comment is needed here so I added one anyway. We only had a comment for handling legacy imports and that's gone now.

TinaHeiligers · 2021-09-02T01:33:24Z

@elastic/kibana-presentation I've had to address some failing functional tests that were either directly testing methods to handle legacy saved object imports or had legacy objects being imported for a test. Here's an issue for that: #111004

pgayvallet

A few comments, but looking fine.

Do you think the second bullet point of #103921 requires a distinct PR (the third definitely does though) ? It may be easier to review those two parts as the same time (but that's just an opinion, splitting is fine too)

pgayvallet · 2021-09-02T07:04:05Z

test/functional/apps/dashboard/exports/timezonetest_6_2_4.json

-      "panelsJSON": "[{\"gridData\":{\"h\":3,\"i\":\"1\",\"w\":6,\"x\":0,\"y\":0},\"id\":\"3fe22200-3dcb-11e8-8660-4d65aa086b3c\",\"panelIndex\":\"1\",\"type\":\"visualization\",\"version\":\"6.2.4\"}]",
-      "optionsJSON": "{\"hidePanelTitles\":false,\"useMargins\":true}",


Is that fine to remove those files/tests , or should we just skip the tests and open an issue for the presentation team to adapt them?

Um, good idea! Done in c0299e6 (#110738)
I've also created the follow up issue for the presentation team and let them know: #111004

pgayvallet · 2021-09-02T07:06:02Z

test/functional/apps/management/_import_objects.ts

-        await esArchiver.load('test/functional/fixtures/es_archiver/saved_objects_imports');
-        await kibanaServer.uiSettings.replace({});
-        await PageObjects.settings.navigateTo();
-        await PageObjects.settings.clickKibanaSavedObjects();
-      });


You can remove all the .json export files that should no longer be used in test/functional/apps/management/exports

Attempt 1: 912c588 (#110738)

pgayvallet · 2021-09-02T07:07:31Z

test/functional/page_objects/management/saved_objects_page.ts

    await this.testSubjects.existOrFail('importSavedObjectsSuccess', { timeout: 20000 });
+    await this.testSubjects.existOrFail('importSavedObjectsSuccess', { timeout: 20000 });


Was this added by mistake?

Oops, yes, I've removed the duplicate in 317a448 (#110738) 😊

pgayvallet · 2021-09-02T07:09:53Z

...bjects_management/public/management_section/objects_table/components/import_mode_control.tsx

-  if (isLegacyFile) {
-    return overwriteRadio;
-  }


NIT: Now that this condition is removed, we no longer need to use this overwriteRadio variable, and we can directly inline it's value inside the returned value

Done in 317a448 (#110738)

TinaHeiligers · 2021-09-02T13:41:16Z

Do you think the second bullet point of #103921 requires a distinct PR

@pgayvallet I started looking into removing the files and it's a lot more work that one might think. I think it'll be easier to follow the split pattern and unblock other teams from moving forward with their work.

I've started to work on a draft and will follow up in new PR with the remaining parts as soon as priorities allow.

…on team to address

TinaHeiligers · 2021-09-02T19:23:31Z

@elasticmachine merge upstream

…/remove_legacy_import_support

pgayvallet · 2021-09-03T09:21:34Z

I started looking into removing the files and it's a lot more work that one might think.

Who would have expected that coming from an SO feature 😅 . Follow-up it is, then

pgayvallet

LGTM

rudolf

🎉

poffdeluxe

Presentation changes lgtm

kibanamachine · 2021-09-03T20:10:49Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`savedObjectsManagement`	140.0KB	131.1KB	-8.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`savedObjectsManagement`	38.3KB	37.5KB	-818.0B

History

💛 Build #150785 was flaky 317a448
💚 Build #150773 succeeded 7fac104
💔 Build #150657 failed 912c588
💔 Build #150635 failed c0299e6
💚 Build #150429 succeeded 1f61d9e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-09-07T14:31:51Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 110738 or prevent reminders by adding the backport:skip label.

kibanamachine · 2021-09-08T14:40:27Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 110738 or prevent reminders by adding the backport:skip label.

TinaHeiligers added 3 commits August 31, 2021 17:09

Removes support for legacy exports

95316f7

Removes code that hooks into legacy imports

c98a48f

Updates flyout component unit tests

48076d7

TinaHeiligers added the release_note:skip Skip the PR/issue when compiling release notes label Sep 1, 2021

TinaHeiligers added 7 commits August 31, 2021 17:42

Removes commented out code from import_mode_control

b6f34d8

Fix types, fix i18n

b14dd50

removes another unused const

a284dd6

Updates test but should remove it because it tests legacy imports

8f5261a

deletes dashboard bwc_import test and fixture, deletes legacy timezon…

b7e7a18

…etest fixture

Deletes timezone test as that used to test against legacy imports

b2d990b

Updates mgmt import objects fixture to normal format

ffa9bfc

TinaHeiligers added Feature:Saved Objects release_note:breaking v8.0.0 and removed release_note:skip Skip the PR/issue when compiling release notes labels Sep 1, 2021

Merge branch 'master' into so-management/remove_legacy_import_support

1f61d9e

TinaHeiligers commented Sep 1, 2021

View reviewed changes

TinaHeiligers marked this pull request as ready for review September 2, 2021 01:30

TinaHeiligers requested review from a team as code owners September 2, 2021 01:31

pgayvallet reviewed Sep 2, 2021

View reviewed changes

Restores dashboard functional tests and skips them for the presentati…

c0299e6

…on team to address

TinaHeiligers mentioned this pull request Sep 2, 2021

Update dashboard legacy format saved objects import functional tests #111004

Closed

Deletes unused json exports

912c588

Merge branch 'master' of github.com:elastic/kibana into so-management…

7fac104

…/remove_legacy_import_support

TinaHeiligers force-pushed the so-management/remove_legacy_import_support branch from ab16382 to 7fac104 Compare September 2, 2021 21:59

Removes duplicate code, moves component contents inline

317a448

pgayvallet approved these changes Sep 3, 2021

View reviewed changes

rudolf approved these changes Sep 3, 2021

View reviewed changes

poffdeluxe approved these changes Sep 3, 2021

View reviewed changes

TinaHeiligers merged commit 66cb058 into elastic:master Sep 3, 2021

TinaHeiligers deleted the so-management/remove_legacy_import_support branch September 3, 2021 14:22

TinaHeiligers mentioned this pull request Sep 3, 2021

Remove unused legacy import code #111071

Merged

2 tasks

pgayvallet mentioned this pull request Sep 6, 2021

SO import/export: Improve JSON import experience #110514

Closed

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 7, 2021

pgayvallet added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Sep 9, 2021

This was referenced Sep 21, 2021

Decouple saved object management from SavedObjectLoader #67607

Closed

Changes edit view to json read-only view #112034

Merged

Decouples saved objects management from legacy saved objects loaders #113031

Merged

This was referenced Oct 21, 2021

Removing tests that support legacy exports #116009

Closed

Removing tests that support legacy exports #116011

Merged

TinaHeiligers mentioned this pull request Dec 15, 2021

Fix and re-enable legacy import functional tests #114053

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removes support for legacy exports #110738

Removes support for legacy exports #110738

TinaHeiligers commented Sep 1, 2021 •

edited

Loading

TinaHeiligers commented Sep 1, 2021

TinaHeiligers Sep 1, 2021

TinaHeiligers Sep 1, 2021

TinaHeiligers Sep 1, 2021

TinaHeiligers commented Sep 2, 2021 •

edited

Loading

pgayvallet left a comment

pgayvallet Sep 2, 2021

TinaHeiligers Sep 2, 2021 •

edited

Loading

pgayvallet Sep 2, 2021

TinaHeiligers Sep 2, 2021

pgayvallet Sep 2, 2021

TinaHeiligers Sep 2, 2021 •

edited

Loading

pgayvallet Sep 2, 2021

TinaHeiligers Sep 2, 2021

TinaHeiligers commented Sep 2, 2021 •

edited

Loading

TinaHeiligers commented Sep 2, 2021

pgayvallet commented Sep 3, 2021

pgayvallet left a comment

rudolf left a comment

poffdeluxe left a comment

kibanamachine commented Sep 3, 2021

kibanamachine commented Sep 7, 2021

kibanamachine commented Sep 8, 2021

		"panelsJSON": "[{\"gridData\":{\"h\":3,\"i\":\"1\",\"w\":6,\"x\":0,\"y\":0},\"id\":\"3fe22200-3dcb-11e8-8660-4d65aa086b3c\",\"panelIndex\":\"1\",\"type\":\"visualization\",\"version\":\"6.2.4\"}]",
		"optionsJSON": "{\"hidePanelTitles\":false,\"useMargins\":true}",

		await this.testSubjects.existOrFail('importSavedObjectsSuccess', { timeout: 20000 });
		await this.testSubjects.existOrFail('importSavedObjectsSuccess', { timeout: 20000 });

Removes support for legacy exports #110738

Removes support for legacy exports #110738

Conversation

TinaHeiligers commented Sep 1, 2021 • edited Loading

Summary

Checklist

Risk Matrix

For maintainers

Release note:

TinaHeiligers commented Sep 1, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TinaHeiligers commented Sep 2, 2021 • edited Loading

pgayvallet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TinaHeiligers Sep 2, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TinaHeiligers Sep 2, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TinaHeiligers commented Sep 2, 2021 • edited Loading

TinaHeiligers commented Sep 2, 2021

pgayvallet commented Sep 3, 2021

pgayvallet left a comment

Choose a reason for hiding this comment

rudolf left a comment

Choose a reason for hiding this comment

poffdeluxe left a comment

Choose a reason for hiding this comment

kibanamachine commented Sep 3, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

kibanamachine commented Sep 7, 2021

kibanamachine commented Sep 8, 2021

TinaHeiligers commented Sep 1, 2021 •

edited

Loading

TinaHeiligers commented Sep 2, 2021 •

edited

Loading

TinaHeiligers Sep 2, 2021 •

edited

Loading

TinaHeiligers Sep 2, 2021 •

edited

Loading

TinaHeiligers commented Sep 2, 2021 •

edited

Loading