Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing tests that support legacy exports #116011

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

rashmivkulkarni
Copy link
Contributor

Fixes: #111004
The following dashboard functional tests are skipped in #110738 and need to be adapted/removed to reflect the changes:

bwc_import (https://github.com/elastic/kibana/blob/master/test/functional/apps/dashboard/bwc_import.ts)
time_zones (https://github.com/elastic/kibana/blob/master/test/functional/apps/dashboard/time_zones.ts)

@rashmivkulkarni rashmivkulkarni requested a review from a team as a code owner October 21, 2021 19:57
@rashmivkulkarni rashmivkulkarni added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Oct 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@rashmivkulkarni rashmivkulkarni added test_ui_functional release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.0.0 labels Oct 21, 2021
@rashmivkulkarni rashmivkulkarni self-assigned this Oct 21, 2021
@bhavyarm bhavyarm added backport:skip This commit does not require backporting and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Oct 21, 2021
Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Removed auto-backport and added backport:skip as this change is valid for 8.0.0

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rashmivkulkarni

Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, test removal LGTM!

@rashmivkulkarni rashmivkulkarni merged commit 776ad48 into elastic:master Oct 22, 2021
shivindera pushed a commit to shivindera/kibana that referenced this pull request Oct 25, 2021
* deleted 2 files

* removing the references of the deleted file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas test_ui_functional v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dashboard legacy format saved objects import functional tests
5 participants